ipu3-cio2 format and other fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 7 repliesIn review
- v15 patches 13 repliesSuperseded
Changes in v3 from the cover letter
- Cc the fixes to the stable tree, cleanups to master only
- Add the size checks first, then make size (as well as a bunch of other constants) unsigned. Then remove the explicit type from size checks.
- Add a patch to rename the length macro as height (which it really is about)
- Add a patch to remove driver queue references to buffers returned to vb2 (cc that to stable, too).
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | ipu3-cio2: Return actual subdev formatdrivers/ | +3 | 0 replies | |
| 2/8 | ipu3-cio2: Serialise access to pad formatdrivers/ drivers/ | +12 | 0 replies | |
| 3/8 | ipu3-cio2: Validate mbus format in setting subdev formatdrivers/ | +20 | 0 replies | |
| 4/8 | ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONEdrivers/ | +1 | 0 replies | |
| 5/8 | ipu3-cio2: Use unsigned values where appropriatedrivers/ | +78 | 0 replies | |
| 6/8 | ipu3-cio2: Remove explicit type from frame size checksdrivers/ | +2 | 2 replies | |
| 7/8 | ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHTdrivers/ drivers/ | +4 | 2 replies | |
| 8/8 | ipu3-cio2: Remove traces of returned buffersdrivers/ | +1 | 3 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Pinchart | Bingbu Cao | Andy Shevchenko |
|---|---|---|---|
| 1/8 | R-b | R-b | R-b |
| 2/8 | R-b | R-b | R-b |
| 3/8 | R-b | R-b | |
| 4/8 | R-b | R-b | R-b |
| 5/8 | A-b | R-b | |
| 6/8 | R-b | R-b | |
| 7/8 | R-b | R-b | |
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/8] ipu3-cio2 format and other fixes
Hello all,
This set addresses most notable subdev format related issues, namely the sub-device sink format being unaccessible. The result of accessing it varied from oopses to crashes.
since v2:
- Cc the fixes to the stable tree, cleanups to master only
- Add the size checks first, then make size (as well as a bunch of other constants) unsigned. Then remove the explicit type from size checks.
- Add a patch to rename the length macro as height (which it really is about)
- Add a patch to remove driver queue references to buffers returned to vb2 (cc that to stable, too).
since v1:
- Validate try format, too
- Set field in subdev format to V4L2_FIELD_NONE
- Add a comment explaining the lock
- Make values that should be unsigned, unsigned
Sakari Ailus (8):
ipu3-cio2: Return actual subdev format
ipu3-cio2: Serialise access to pad format
ipu3-cio2: Validate mbus format in setting subdev format
ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE
ipu3-cio2: Use unsigned values where appropriate
ipu3-cio2: Remove explicit type from frame size checks
ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHT
ipu3-cio2: Remove traces of returned buffers
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 65 +++++----- drivers/media/pci/intel/ipu3/ipu3-cio2.h | 157 ++++++++++++----------- 2 files changed, 114 insertions(+), 108 deletions(-)
Signature · 1 line
2.27.0