Skip to content

ipu3-cio2 format and other fixes

Sakari Ailus linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 7 repliesIn review
  2. v15 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- Cc the fixes to the stable tree, cleanups to master only

- Add the size checks first, then make size (as well as a bunch of other constants) unsigned. Then remove the explicit type from size checks.

- Add a patch to rename the length macro as height (which it really is about)

- Add a patch to remove driver queue references to buffers returned to vb2 (cc that to stable, too).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ipu3-cio2: Return actual subdev formatdrivers/media/pci/intel/ipu3/ipu3-cio2.c+3 -210 replies
2/8ipu3-cio2: Serialise access to pad formatdrivers/media/pci/intel/ipu3/ipu3-cio2.c drivers/media/pci/intel/ipu3/ipu3-cio2.h+12 -00 replies
3/8ipu3-cio2: Validate mbus format in setting subdev formatdrivers/media/pci/intel/ipu3/ipu3-cio2.c+20 -90 replies
4/8ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONEdrivers/media/pci/intel/ipu3/ipu3-cio2.c+1 -00 replies
5/8ipu3-cio2: Use unsigned values where appropriatedrivers/media/pci/intel/ipu3/ipu3-cio2.h+78 -780 replies
6/8ipu3-cio2: Remove explicit type from frame size checksdrivers/media/pci/intel/ipu3/ipu3-cio2.c+2 -32 replies
7/8ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHTdrivers/media/pci/intel/ipu3/ipu3-cio2.c drivers/media/pci/intel/ipu3/ipu3-cio2.h+4 -42 replies
8/8ipu3-cio2: Remove traces of returned buffersdrivers/media/pci/intel/ipu3/ipu3-cio2.c+1 -03 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartBingbu CaoAndy Shevchenko
1/8R-b R-b R-b
2/8R-b R-b R-b
3/8R-b R-b
4/8R-b R-b R-b
5/8A-b R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] ipu3-cio2 format and other fixes

Hello all,

This set addresses most notable subdev format related issues, namely the sub-device sink format being unaccessible. The result of accessing it varied from oopses to crashes.

since v2:

- Cc the fixes to the stable tree, cleanups to master only

- Add the size checks first, then make size (as well as a bunch of other constants) unsigned. Then remove the explicit type from size checks.

- Add a patch to rename the length macro as height (which it really is about)

- Add a patch to remove driver queue references to buffers returned to vb2 (cc that to stable, too).

since v1:

- Validate try format, too

- Set field in subdev format to V4L2_FIELD_NONE

- Add a comment explaining the lock

- Make values that should be unsigned, unsigned

Sakari Ailus (8):
ipu3-cio2: Return actual subdev format
ipu3-cio2: Serialise access to pad format
ipu3-cio2: Validate mbus format in setting subdev format
ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE
ipu3-cio2: Use unsigned values where appropriate
ipu3-cio2: Remove explicit type from frame size checks
ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHT
ipu3-cio2: Remove traces of returned buffers

 drivers/media/pci/intel/ipu3/ipu3-cio2.c |  65 +++++-----
 drivers/media/pci/intel/ipu3/ipu3-cio2.h | 157 ++++++++++++-----------
 2 files changed, 114 insertions(+), 108 deletions(-)
Signature · 1 line
2.27.0