unbreak non-tcg builds
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 5 repliesIn review
- v33 patches 10 repliesSuperseded
- v23 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 4 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
* abandon attempts to avoid the code duplication and functional code in stubs, just providing the minimal changes to get things working.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tests/Makefile.include: unbreak non-tcg buildstests/ | +1 | 0 replies | |
| 2/3 | qtest: unbreak non-TCG builds in bios-tables-testtests/ | +10 | 0 replies | |
| 3/3 | replay: do not build if TCG is not availableblock/ migration/ net/ +8 more | +125 | 3 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini |
|---|---|
| 1/3 | |
| 2/3 | A-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] unbreak non-tcg builds
This series now unbreaks current non-tcg builds (!CONFIG_TCG).
tests Makefiles need to avoid relying on all non-native archs binaries to be present,
bios-tables-test needs to skip tests that are tcg-only,
and notably the replay framework needs to consider that it might not be functional (or its code present at all) without TCG.
Tested ok target x86_64-softmmu on x86_64 host with:
./configure --enable-tcg --disable-kvm
./configure --enable-kvm --disable-tcg
./configure --enable-tcg --enable-kvm
running make check-qtest
v3 => v4:
* abandon attempts to avoid the code duplication and functional code in stubs, just providing the minimal changes to get things working.
v2 => v3:
* do not alter the replay api, provide a block wrapper instead to call into replay events handling
or the normal call flow depending on whether replay events are enabled.
v1: initial RFC
Claudio Fontana (2):
qtest: unbreak non-TCG builds in bios-tables-test
replay: do not build if TCG is not available
Paolo Bonzini (1):
tests/Makefile.include: unbreak non-tcg builds
block/meson.build | 3 +- migration/savevm.c | 11 ++-- net/meson.build | 3 +- replay/meson.build | 2 +- replay/replay-input.c | 4 +- stubs/meson.build | 1 - stubs/replay-user.c | 9 ---- stubs/replay.c | 98 ++++++++++++++++++++++++++++++++++ tests/Makefile.include | 2 +- tests/ptimer-test-stubs.c | 5 -- tests/qtest/bios-tables-test.c | 10 ++++ tests/qtest/qmp-cmd-test.c | 3 ++ ui/input.c | 12 ++++- 13 files changed, 136 insertions(+), 27 deletions(-) delete mode 100644 stubs/replay-user.c
Signature · 1 line
2.26.2