python/qemu: strictly typed mypy conversion, pt3
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | python: add mypy configpython/ | +4 | 2 replies | |
| 2/3 | python/qemu/qmp.py: re-raise OSError when encounteredpython/ | +6 | 1 reply | |
| 3/3 | python/qemu/qmp.py: Fix settimeout operationpython/ | +17 | 1 reply |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé |
|---|---|
| 1/3 | |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3
This is actually quite short; it's already fully typed. Attached are two fixes for settimeout and error handling. There are actually more fixes that need to be made here, because use of readline() in non-blocking mode is actually undefined behavior, so a more thorough re-work of the error classes used by this library must be put on hold pending a more aggressive re-write.
That's a problem for later, so for now, call the initial conversion to the statically typed subset of python done so we can move on to adding the regression tests that will maintain this baseline for us.
John Snow (3):
python: add mypy config
python/qemu/qmp.py: re-raise OSError when encountered python/qemu/qmp.py: Fix settimeout operation
python/mypy.ini | 4 ++++ python/qemu/qmp.py | 30 +++++++++++++++++++++--------- 2 files changed, 25 insertions(+), 9 deletions(-) create mode 100644 python/mypy.ini
Signature · 1 line
2.26.2