Skip to content

python/qemu: strictly typed mypy conversion, pt3

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3python: add mypy configpython/mypy.ini+4 -02 replies
2/3python/qemu/qmp.py: re-raise OSError when encounteredpython/qemu/qmp.py+6 -51 reply
3/3python/qemu/qmp.py: Fix settimeout operationpython/qemu/qmp.py+17 -61 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3

This is actually quite short; it's already fully typed. Attached are two fixes for settimeout and error handling. There are actually more fixes that need to be made here, because use of readline() in non-blocking mode is actually undefined behavior, so a more thorough re-work of the error classes used by this library must be put on hold pending a more aggressive re-write.

That's a problem for later, so for now, call the initial conversion to the statically typed subset of python done so we can move on to adding the regression tests that will maintain this baseline for us.

John Snow (3):
python: add mypy config
python/qemu/qmp.py: re-raise OSError when encountered python/qemu/qmp.py: Fix settimeout operation

 python/mypy.ini    |  4 ++++
 python/qemu/qmp.py | 30 +++++++++++++++++++++---------
 2 files changed, 25 insertions(+), 9 deletions(-)
 create mode 100644 python/mypy.ini
Signature · 1 line
2.26.2