Skip to content

qom: Simplify pointer property getters/setters

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3acpi: Don't pass const pointers to object_property_add_uint*_ptr()hw/acpi/ich9.c hw/acpi/piix4.c hw/isa/lpc_ich9.c+8 -80 replies
2/3qom: Make object_property_add_uint*_ptr() get non-const pointersinclude/qom/object.h qom/object.c+8 -80 replies
3/3qom: Simplify and merge pointer property getters/settersqom/object.c+22 -922 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] qom: Simplify pointer property getters/setters

The existing pointer property getters/setters are awkward because they are expected to work with const variables. If we remove that requirement, they can become a lot simpler and simply call the visit_type_uint*() functions directly.

Git tree: https://github.com/ehabkost/qemu work/qom-ptr-prop-not-const
Based-on: [email protected]

Eduardo Habkost (3):
acpi: Don't pass const pointers to object_property_add_uint*_ptr()
qom: Make object_property_add_uint*_ptr() get non-const pointers
qom: Simplify and merge pointer property getters/setters

 include/qom/object.h |   8 +--
 hw/acpi/ich9.c       |   2 +-
 hw/acpi/piix4.c      |  10 ++--
 hw/isa/lpc_ich9.c    |   4 +-
 qom/object.c         | 122 +++++++++----------------------------------
 5 files changed, 38 insertions(+), 108 deletions(-)
Signature · 1 line
2.26.2