Skip to content

Add GPIO support for MStar/SigmaStar ARMv7

Daniel Palmer linux-arm-kernel linux-devicetree linux-gpio lkml soc 4 versions – Applied

Status from this message: Applied to arm/dt, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 13 repliesApplied
  2. v35 patches 3 repliesSuperseded
  3. v25 patches 16 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches14 repliesSuperseded

Changes in v4 from the cover letter

- Remove unneeded "gpio-ranges-group-names" property from binding yaml.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: gpio: Add a binding header for the MSC313 GPIO driverMAINTAINERS include/dt-bindings/gpio/msc313-gpio.h+54 -00 replies
2/5dt-bindings: gpio: Binding for MStar MSC313 GPIO controllerDocumentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml MAINTAINERS+60 -01 reply
3/5gpio: msc313: MStar MSC313 GPIO driverMAINTAINERS drivers/gpio/Kconfig drivers/gpio/Makefile +1 more+473 -07 replies
4/5ARM: mstar: Add gpio controller to MStar base dtsiarch/arm/boot/dts/mstar-v7.dtsi+10 -00 replies
5/5ARM: mstar: Fill in GPIO controller properties for infinityarch/arm/boot/dts/mstar-infinity.dtsi+7 -00 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchRob HerringLinus Walleij
1/5R-b
2/5R-b
3/5
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Add GPIO support for MStar/SigmaStar ARMv7

At the moment the MStar/SigmaStar support is only really capable of shell from an initramfs and not much else.

Most of the interesting drivers are blocked on clock and pinctrl drivers and those are going to take me a little while to get cleaned up.

Clock and pinctrl aren't needed for basic GPIO to work (all pins start off as GPIOs..) and it makes it possible to actually do something so this series adds everything that is needed for the main GPIO block in these chips.

Changes since v3:
- Remove unneeded "gpio-ranges-group-names" property from binding yaml.

Changes since v2:

- Numerous style and code cleanups as suggested by Andy Shevchenko, Linus Walleij, Marc Zyngier and Rob Herring.

- Pad names moved out of the binding header because they are no longer needed there. The pin/pad numbers are still there as I couldn't think of a better way to do this. meson8b-gpio.h seems to be similar.

Changes since v1:

- Moves the binding header commit before the yaml commit

- Fixes the license on the binding header to include BSD-2-Clause

- The driver has been reworked to use the gpiolib irqchip functionality as suggested by Linus[0]. I think I got this right. The gpio controller doesn't actually do anything with interrupts itself.. It just happens to have 4 lines that are also wired to lines on one of the interrupt controllers.

- Now that the driver is an interrupt controller in it's own right for the gpio lines that have associated interrupts the binding description has been updated to add the interrupt-controller bits and remove the description of the interrupt-names that described how the interrupts used to be passed in.

Daniel Palmer (5):
dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver
dt-bindings: gpio: Binding for MStar MSC313 GPIO controller
gpio: msc313: MStar MSC313 GPIO driver
ARM: mstar: Add gpio controller to MStar base dtsi
ARM: mstar: Fill in GPIO controller properties for infinity

 .../bindings/gpio/mstar,msc313-gpio.yaml      |  59 +++
 MAINTAINERS                                   |   3 +
 arch/arm/boot/dts/mstar-infinity.dtsi         |   7 +
 arch/arm/boot/dts/mstar-v7.dtsi               |  10 +
 drivers/gpio/Kconfig                          |  11 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-msc313.c                    | 460 ++++++++++++++++++
 include/dt-bindings/gpio/msc313-gpio.h        |  53 ++
 8 files changed, 604 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
 create mode 100644 drivers/gpio/gpio-msc313.c
 create mode 100644 include/dt-bindings/gpio/msc313-gpio.h
Signature · 1 line
2.29.2