Skip to content

macb: support the 2-deep Tx queue on at91

Willy Tarreau netdev 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3macb: add RM9200's interrupt flag TBREdrivers/net/ethernet/cadence/macb.h+2 -00 replies
2/3macb: prepare at91 to use a 2-frame TX queuedrivers/net/ethernet/cadence/macb.h drivers/net/ethernet/cadence/macb_main.c+18 -160 replies
3/3macb: support the two tx descriptors on at91rm9200drivers/net/ethernet/cadence/macb.h drivers/net/ethernet/cadence/macb_main.c+40 -83 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

Hi,

while running some tests on my Breadbee board, I noticed poor network Tx performance. I had a look at the driver (macb, at91ether variant) and noticed that at91ether_start_xmit() immediately stops the queue after sending a frame and waits for the interrupt to restart the queue, causing a dead time after each packet is sent.

The AT91RM9200 datasheet states that the controller supports two frames, one being sent and the other one being queued, so I performed minimal changes to support this. The transmit performance on my board has increased by 50% on medium-sized packets (HTTP traffic), and with large packets I can now reach line rate.

Since this driver is shared by various platforms, I tried my best to isolate and limit the changes as much as possible and I think it's pretty reasonable as-is. I've run extensive tests and couldn't meet any unexpected situation (no stall, overflow nor lockup).

There are 3 patches in this series. The first one adds the missing interrupt flag for RM9200 (TBRE, indicating the tx buffer is willing to take a new packet). The second one replaces the single skb with a 2-array and uses only index 0. It does no other change, this is just to prepare the code for the third one. The third one implements the queue. Packets are added at the tail of the queue, the queue is stopped at 2 packets and the interrupt releases 0, 1 or 2 depending on what the transmit status register reports.

Thanks,
Willy

Willy Tarreau (3):
macb: add RM9200's interrupt flag TBRE
macb: prepare at91 to use a 2-frame TX queue
macb: support the two tx descriptors on at91rm9200

 drivers/net/ethernet/cadence/macb.h      | 10 ++--
 drivers/net/ethernet/cadence/macb_main.c | 66 ++++++++++++++++++------
 2 files changed, 56 insertions(+), 20 deletions(-)
Signature · 1 line
2.28.0