qcow2: don't leave partially initialized file on image creation
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 4 repliesApplied
- v54 patches 6 repliesSuperseded
- v44 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 2 patches | 7 replies | Superseded | |
| v2 | 2 patches | 2 replies | Superseded |
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | crypto: luks: Fix tiny memory leakblock/ | +2 | 0 replies | |
| 2/3 | block: add bdrv_co_delete_file_noerrblock.c block/ include/ | +25 | 1 reply | |
| 3/3 | block: qcow2: remove the created file on initialization errorblock/ | +5 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Alberto Garcia | Vladimir Sementsov-Ogievskiy |
|---|---|---|
| 1/3 | R-b | R-b |
| 2/3 | R-b | R-b |
| 3/3 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/3] qcow2: don't leave partially initialized file on image creation
Use the bdrv_co_delete_file interface to delete the underlying file if qcow2 initialization fails (e.g due to bad encryption secret)
This makes the qcow2 driver behave the same way as the luks driver behaves.
V3: addressed review feedback and reworked commit messages
V4: got rid of code duplication by adding bdrv_co_delete_file_noerr and made the qcow2 driver use this function to delete both the main and the data file.
V5: addresssed review feedback on reworked version.
V6: addressed most of the review feedback.
Best regards,
Maxim Levitsky
Maxim Levitsky (3):
crypto: luks: Fix tiny memory leak
block: add bdrv_co_delete_file_noerr
block: qcow2: remove the created file on initialization error
block.c | 22 ++++++++++++++++++++++ block/crypto.c | 13 ++----------- block/qcow2.c | 8 +++++--- include/block/block.h | 1 + 4 files changed, 30 insertions(+), 14 deletions(-)
Signature · 1 line
2.26.2