drm/msm: de-struct_mutex-ification
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest23 patches 6 repliesIn review
- v323 patches 4 repliesSuperseded
- v10 of 14 patches 0 repliesSuperseded
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | drm/msm: Fix a couple incorrect usages of get_vaddr_active()drivers/ drivers/ | +2 | 0 replies | |
| 2/23 | drm/msm/gem: Add obj->lock wrappersdrivers/ drivers/ | +74 | 0 replies | |
| 3/23 | drm/msm/gem: Rename internal get_iova_locked helperdrivers/ | +3 | 0 replies | |
| 4/23 | drm/msm/gem: Move prototypes to msm_gem.hdrivers/ drivers/ drivers/ +3 more | +60 | 0 replies | |
| 5/23 | drm/msm/gem: Add some _locked() helpersdrivers/ drivers/ | +75 | 0 replies | |
| 6/23 | drm/msm/gem: Move locking in shrinker pathdrivers/ drivers/ drivers/ | +35 | 0 replies | |
| 7/23 | drm/msm/submit: Move copy_from_user ahead of locking bosdrivers/ drivers/ | +82 | 0 replies | |
| 8/23 | drm/msm: Do rpm get sooner in the submit pathdrivers/ | +13 | 0 replies | |
| 9/23 | drm/msm/gem: Switch over to obj->resv for lockingdrivers/ drivers/ drivers/ +2 more | +29 | 0 replies | |
| 10/23 | drm/msm: Use correct drm_gem_object_put() in fail casedrivers/ | +5 | 0 replies | |
| 11/23 | drm/msm: Drop chatty tracedrivers/ | +0 | 0 replies | |
| 12/23 | drm/msm: Move update_fences()drivers/ | +14 | 0 replies | |
| 13/23 | drm/msm: Add priv->mm_lock to protect active/inactive listsdrivers/ drivers/ drivers/ +3 more | +58 | 0 replies | |
| 14/23 | drm/msm: Document and rename preempt_lockdrivers/ drivers/ drivers/ +2 more | +17 | 0 replies | |
| 15/23 | drm/msm: Protect ring->submits with it's own lockdrivers/ drivers/ drivers/ +1 more | +39 | 0 replies | |
| 16/23 | drm/msm: Refcount submitsdrivers/ drivers/ drivers/ +1 more | +34 | 0 replies | |
| 17/23 | drm/msm: Remove obj->gpudrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 18/23 | drm/msm: Drop struct_mutex from the retire pathdrivers/ | +1 | 0 replies | |
| 19/23 | drm/msm: Drop struct_mutex in free_object() pathdrivers/ | +0 | 0 replies | |
| 20/23 | drm/msm: Remove msm_gem_free_workdrivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 21/23 | drm/msm: Drop struct_mutex in madvise pathdrivers/ drivers/ drivers/ | +3 | 0 replies | |
| 22/23 | drm/msm: Drop struct_mutex in shrinker pathdrivers/ drivers/ | +0 | 0 replies | |
| 23/23 | drm/msm: Don't implicit-sync if only a single ringdrivers/ | +4 | 6 replies |
Reviews trailers per patch
All 23 patches have a Reviewed-by or Acked-by.
| Patch | Kristian H. Kristensen | Jordan Crouse |
|---|---|---|
| 1/23 | R-b | |
| 2/23 | R-b | |
| 3/23 | R-b | |
| 4/23 | R-b | |
| 5/23 | R-b | |
| 6/23 | R-b | |
| 7/23 | R-b | |
| 8/23 | R-b | |
| 9/23 | R-b | |
| 10/23 | R-b | |
| 11/23 | R-b | R-b |
| 12/23 | R-b | R-b |
| 13/23 | R-b | R-b |
| 14/23 | R-b | R-b |
| 15/23 | R-b | R-b |
| 16/23 | R-b | R-b |
| 17/23 | R-b | |
| 18/23 | R-b | R-b |
| 19/23 | R-b | |
| 20/23 | R-b | |
| 21/23 | R-b | |
| 22/23 | R-b | |
| 23/23 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/23] drm/msm: de-struct_mutex-ification
From: Rob Clark <[email protected]>
This doesn't remove *all* the struct_mutex, but it covers the worst of it, ie. shrinker/madvise/free/retire. The submit path still uses struct_mutex, but it still needs *something* serialize a portion of the submit path, and lock_stat mostly just shows the lock contention there being with other submits. And there are a few other bits of struct_mutex usage in less critical paths (debugfs, etc). But this seems like a reasonable step in the right direction.
v2: teach lockdep about shrinker locking patters (danvet) and
convert to obj->resv locking (danvet)
v3: fix get_vaddr locking for legacy userspace (relocs), devcoredump,
and rd/hangrd
v4: couple minor review comments (krh), fix deadlock with imported
dma-buf's (ie. from v4l2, etc)Rob Clark (23):
drm/msm: Fix a couple incorrect usages of get_vaddr_active() drm/msm/gem: Add obj->lock wrappers
drm/msm/gem: Rename internal get_iova_locked helper drm/msm/gem: Move prototypes to msm_gem.h drm/msm/gem: Add some _locked() helpers drm/msm/gem: Move locking in shrinker path drm/msm/submit: Move copy_from_user ahead of locking bos drm/msm: Do rpm get sooner in the submit path drm/msm/gem: Switch over to obj->resv for locking drm/msm: Use correct drm_gem_object_put() in fail case drm/msm: Drop chatty trace
drm/msm: Move update_fences()
drm/msm: Add priv->mm_lock to protect active/inactive lists drm/msm: Document and rename preempt_lock
drm/msm: Protect ring->submits with it's own lock drm/msm: Refcount submits
drm/msm: Remove obj->gpu
drm/msm: Drop struct_mutex from the retire path drm/msm: Drop struct_mutex in free_object() path drm/msm: Remove msm_gem_free_work
drm/msm: Drop struct_mutex in madvise path drm/msm: Drop struct_mutex in shrinker path drm/msm: Don't implicit-sync if only a single ring
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 12 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c | 1 + drivers/gpu/drm/msm/msm_debugfs.c | 7 + drivers/gpu/drm/msm/msm_drv.c | 21 +- drivers/gpu/drm/msm/msm_drv.h | 73 +----- drivers/gpu/drm/msm/msm_fbdev.c | 1 + drivers/gpu/drm/msm/msm_gem.c | 271 +++++++++++----------- drivers/gpu/drm/msm/msm_gem.h | 133 +++++++++-- drivers/gpu/drm/msm/msm_gem_shrinker.c | 81 ++----- drivers/gpu/drm/msm/msm_gem_submit.c | 164 ++++++++----- drivers/gpu/drm/msm/msm_gpu.c | 110 +++++---- drivers/gpu/drm/msm/msm_gpu.h | 5 +- drivers/gpu/drm/msm/msm_rd.c | 2 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 3 +- drivers/gpu/drm/msm/msm_ringbuffer.h | 13 +- 19 files changed, 506 insertions(+), 405 deletions(-)
Signature · 1 line
2.26.2