Skip to content

dmaengine: dw-axi-dmac: support Intel KeemBay AxiDMA

Sia Jee Heng dmaengine linux-devicetree lkml 12 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest17 patches 1 replyApplied
  2. v1116 patches 0 repliesSuperseded
  3. v1016 patches 0 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v916 patches1 replySuperseded
v816 patches2 repliesSuperseded
v716 patches1 replySuperseded
v616 patches4 repliesSuperseded
v516 patches7 repliesSuperseded
v415 patches7 repliesSuperseded
v315 patches3 repliesSuperseded
v215 patches10 repliesSuperseded
v115 patches9 repliesSuperseded

Changes in v12 from the cover letter

- Fixed bot build error by adding HAS_IOMEM dependency to Kconfig.

Patches in v12 Applied

#Subject and filesSizeRepliesApplied
1/17dt-bindings: dma: Add YAML schemas for dw-axi-dmacDocumentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml+121 -390 replies
2/17dmaengine: dw-axi-dmac: simplify descriptor managementdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+102 -710 replies
3/17dmaengine: dw-axi-dmac: move dma_pool_create() to alloc_chan_resources()drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+14 -120 replies
4/17dmaengine: dw-axi-dmac: Add device_synchronize() callbackdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c+8 -00 replies
5/17dmaengine: dw-axi-dmac: Add device_config operationdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+12 -00 replies
6/17dmaengine: dw-axi-dmac: Support device_prep_slave_sgdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+155 -00 replies
7/17dmaegine: dw-axi-dmac: Support device_prep_dma_cyclic()drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+106 -70 replies
8/17dmaengine: dw-axi-dmac: Support of_dma_controller_register()drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+27 -00 replies
9/17dmaengine: dw-axi-dmac: Support burst residue granularitydrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+38 -70 replies
10/17dt-binding: dma: dw-axi-dmac: Add support for Intel KeemBay AxiDMADocumentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml+5 -00 replies
11/17dmaengine: dw-axi-dmac: Add Intel KeemBay DMA register fieldsdrivers/dma/dw-axi-dmac/dw-axi-dmac.h+14 -00 replies
12/17dmaengine: drivers: Kconfig: add HAS_IOMEM dependency to DW_AXI_DMACdrivers/dma/Kconfig+1 -00 replies
13/17dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA supportdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c+8 -00 replies
14/17dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA handshakedrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c+50 -00 replies
15/17dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA BYTE and HALFWORD registersdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c+26 -00 replies
16/17dmaengine: dw-axi-dmac: Set constraint to the Max segment sizedrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+9 -00 replies
17/17dmaengine: dw-axi-dmac: Virtually split the linked-listdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c drivers/dma/dw-axi-dmac/dw-axi-dmac.h+92 -200 replies

Reviews trailers per patch

16 of 17 patches have a Reviewed-by or Acked-by.

PatchEugeniy PaltsevRob HerringAndy Shevchenko
1/17R-b R-b
2/17R-b T-b R-b
3/17R-b T-b R-b
4/17R-b T-b R-b
5/17R-b T-b R-b
6/17R-b T-b R-b
7/17R-b T-b R-b
8/17R-b T-b R-b
9/17R-b T-b R-b
10/17R-b R-b
11/17R-b T-b R-b
12/17
13/17R-b T-b R-b
14/17R-b T-b R-b
15/17R-b T-b R-b
16/17R-b T-b R-b
17/17R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/17] dmaengine: dw-axi-dmac: support Intel KeemBay AxiDMA

The below patch series are to support AxiDMA running on Intel KeemBay SoC. The base driver is dw-axi-dmac. This driver only support DMA memory copy transfers. Code refactoring is needed so that additional features can be supported. The features added in this patch series are:
- Replacing Linked List with virtual descriptor management.
- Remove unrelated hw desc stuff from dma memory pool.
- Manage dma memory pool alloc/destroy based on channel activity.
- Support dmaengine device_sync() callback.
- Support dmaengine device_config().
- Support dmaengine device_prep_slave_sg().
- Support dmaengine device_prep_dma_cyclic().
- Support of_dma_controller_register().
- Support burst residue granularity.
- Support Intel KeemBay AxiDMA registers.
- Support Intel KeemBay AxiDMA device handshake.
- Support Intel KeemBay AxiDMA BYTE and HALFWORD device operation.
- Add constraint to Max segment size.
- Virtually split the linked-list.

This patch series are tested on Intel KeemBay platform. Eugeniy Paltsev has runtime tested this patch series on HSDK SoC/board.

v12:
- Fixed bot build error by adding HAS_IOMEM dependency to Kconfig.

v11:
- Fixed bot build warning.

v10:
- Rebased to kernel v5.11-rc4
- Added Reviewed-by and Tested-by tag from Eugeniy Paltsev.

v9:
- Logic checked on apb_regs inside the function.
- Improved code scalability so that missing of apb_regs wouldn't failed the common callback functions.

v8:
- Rebased to kernel v5.11-rc1.
- Added reviewed-by tag from Rob.

v7:
- Added 'allOf' and '$ref:dma-controller.yaml#' in DT binding.
- Removed the dma-channels common description in DT binding.
- Removed the default fields in DT binding.

v6:
- Removed 'allOf' cases in DT binding.
- Added '>' at the end of the email address.
- Removed additional '|' at the start of description.
- Fixed space indent.
- Added proper constraint in DT binding.
- Removed second example in DT binding.

v5:
- Added comment to the Apb registers used by Intel KeemBay Soc.
- Renamed "hs_num" to "handshake_num".
- Conditional check for the compatible property and return error instead of printing warning.
- Added patch 16th to virtually split the linked-list as per request from ALSA team.

v4:
- Fixed bot found errors running make_dt_binding_check.
- Added minItems: 1 to the YAML schemas DT binding.
- Updated "reg" field to the YAML schemas DT binding.

v3:
- Added additionalProperties: false to the YAML schemas DT binding.
- Reordered patch sequence for patch 10th, 11th and 12th so that DT binding come first, follow by adding Intel KeemBay SoC registers and update .compatible field.
- Checked txstate NULL condition.
- Created helper function dw_axi_dma_set_hw_desc() to handle common code.

v2:
- Rebased to v5.10-rc1 kernel.
- Added support for dmaengine device_config().
- Added support for dmaengine device_prep_slave_sg().
- Added support for dmaengine device_prep_dma_cyclic().
- Added support for of_dma_controller_register().
- Added support for burst residue granularity.
- Added support for Intel KeemBay AxiDMA registers.
- Added support for Intel KeemBay AxiDMA device handshake.
- Added support for Intel KeemBay AxiDMA BYTE and HALFWORD device operation.
- Added constraint to Max segment size.

v1:
- Initial version. Patch on top of dw-axi-dma driver. This version improve the descriptor management by replacing Linked List Item (LLI) with virtual descriptor management, only allocate hardware LLI memories from DMA memory pool, manage DMA memory pool alloc/destroy based on channel activity and to support device_sync callback.

Sia Jee Heng (17):
dt-bindings: dma: Add YAML schemas for dw-axi-dmac
dmaengine: dw-axi-dmac: simplify descriptor management
dmaengine: dw-axi-dmac: move dma_pool_create() to
alloc_chan_resources()
dmaengine: dw-axi-dmac: Add device_synchronize() callback
dmaengine: dw-axi-dmac: Add device_config operation
dmaengine: dw-axi-dmac: Support device_prep_slave_sg
dmaegine: dw-axi-dmac: Support device_prep_dma_cyclic()
dmaengine: dw-axi-dmac: Support of_dma_controller_register()
dmaengine: dw-axi-dmac: Support burst residue granularity
dt-binding: dma: dw-axi-dmac: Add support for Intel KeemBay AxiDMA
dmaengine: dw-axi-dmac: Add Intel KeemBay DMA register fields
dmaengine: drivers: Kconfig: add HAS_IOMEM dependency to DW_AXI_DMAC
dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA support
dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA handshake
dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA BYTE and HALFWORD
registers
dmaengine: dw-axi-dmac: Set constraint to the Max segment size
dmaengine: dw-axi-dmac: Virtually split the linked-list

 .../bindings/dma/snps,dw-axi-dmac.txt         |  39 -
 .../bindings/dma/snps,dw-axi-dmac.yaml        | 126 ++++
 drivers/dma/Kconfig                           |   1 +
 .../dma/dw-axi-dmac/dw-axi-dmac-platform.c    | 696 +++++++++++++++---
 drivers/dma/dw-axi-dmac/dw-axi-dmac.h         |  34 +-
 5 files changed, 764 insertions(+), 132 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
 create mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml

base-commit: 228a65d4544af5086bd167dcc5a0cb4fae2c42b4

Signature · 1 line
2.18.0