Skip to content

devtools: abi breakage checks

Conor Walsh dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 6 repliesIn review
  2. v64 patches 6 repliesSuperseded
  3. v54 patches 0 repliesSuperseded

v5 from the cover letter

- Patchset has been completely reworked following feedback
- Patchset is now part of test-meson-builds.sh not the meson build system

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4devtools: add generation of compressed abi dump archivesdevtools/gen-abi-tarballs.sh+48 -01 reply
2/4devtools: abi and UX changes for test-meson-builds.shdevtools/test-meson-builds.sh+139 -321 reply
3/4devtools: change not found to warning check-abi.shdevtools/check-abi.sh+1 -20 replies
4/4doc: test-meson-builds.sh doc updatesdoc/guides/contributing/patches.rst+14 -120 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRay Kinsella
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [dpdk-dev] [PATCH v7 0/4] devtools: abi breakage checks

This patchset introduces changes to test-meson-builds.sh, check-abi.sh and adds a new script gen-abi-tarballs.sh. The changes to test-meson-builds.sh include UX improvements such as adding command line arguments and allowing the use of relative paths. Reduced the number of abi checks to just two, one for both x86_64 and ARM, the references for these tests can now be prebuilt and downloaded by test-meson-builds.sh, these changes will allow the tests to run much faster. check-abi.sh is updated to use the prebuilt references. gen-abi-tarballs.sh is a new script to generate the prebuilt abi references used by test-meson-builds.sh, these compressed archives can be retrieved from either a local directory or a remote http location.

---
v7: Changes resulting from list feedback

v6: Corrected a mistake in the doc patch

v5:
- Patchset has been completely reworked following feedback
- Patchset is now part of test-meson-builds.sh not the meson build system

v4:
- Reworked both Python scripts to use more native Python functions and modules.
- Python scripts are now in line with how other Python scripts in DPDK are structured.

v3:
- Fix for bug which now allows meson < 0.48.0 to be used
- Various coding style changes throughout
- Minor bug fixes to the various meson.build files

v2: Spelling mistake, corrected spelling of environmental

Conor Walsh (4):
devtools: add generation of compressed abi dump archives
devtools: abi and UX changes for test-meson-builds.sh
devtools: change dump file not found to warning in check-abi.sh
doc: test-meson-builds.sh doc updates

 devtools/check-abi.sh               |   3 +-
 devtools/gen-abi-tarballs.sh        |  48 ++++++++
 devtools/test-meson-builds.sh       | 171 ++++++++++++++++++++++------
 doc/guides/contributing/patches.rst |  26 +++--
 4 files changed, 202 insertions(+), 46 deletions(-)
 create mode 100755 devtools/gen-abi-tarballs.sh
Signature · 1 line
2.25.1