Skip to content

efct: Broadcom (Emulex) FC Target driver

James Smart linux-scsi oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest31 patches 39 repliesIn review

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31elx: libefc_sli: SLI-4 register offsets and field definitionsMAINTAINERS drivers/scsi/elx/libefc_sli/sli4.c drivers/scsi/elx/libefc_sli/sli4.h+324 -02 replies
2/31elx: libefc_sli: SLI Descriptors and Queue entriesdrivers/scsi/elx/include/efc_common.h drivers/scsi/elx/libefc_sli/sli4.h+1808 -03 replies
3/31elx: libefc_sli: Data structures and defines for mbox commandsdrivers/scsi/elx/libefc_sli/sli4.h+1624 -01 reply
4/31elx: libefc_sli: queue create/destroy/parse routinesdrivers/scsi/elx/include/efc_common.h drivers/scsi/elx/libefc_sli/sli4.c drivers/scsi/elx/libefc_sli/sli4.h+1391 -01 reply
5/31elx: libefc_sli: Populate and post different WQEsdrivers/scsi/elx/libefc_sli/sli4.c+1499 -02 replies
6/31elx: libefc_sli: bmbx routines and SLI config commandsdrivers/scsi/elx/libefc_sli/sli4.c+1167 -02 replies
7/31elx: libefc_sli: APIs to setup SLI librarydrivers/scsi/elx/libefc_sli/sli4.c drivers/scsi/elx/libefc_sli/sli4.h+1531 -02 replies
8/31elx: libefc: Generic state machine frameworkdrivers/scsi/elx/libefc/efc_sm.c drivers/scsi/elx/libefc/efc_sm.h+251 -02 replies
9/31elx: libefc: Emulex FC discovery library APIs and definitionsdrivers/scsi/elx/libefc/efc.h drivers/scsi/elx/libefc/efc_lib.c drivers/scsi/elx/libefc/efclib.h+771 -01 reply
10/31elx: libefc: FC Domain state machine interfacesdrivers/scsi/elx/libefc/efc_domain.c drivers/scsi/elx/libefc/efc_domain.h+1149 -01 reply
11/31elx: libefc: SLI and FC PORT state machine interfacesdrivers/scsi/elx/libefc/efc_nport.c drivers/scsi/elx/libefc/efc_nport.h+875 -01 reply
12/31elx: libefc: Remote node state machine interfacesdrivers/scsi/elx/libefc/efc_node.c drivers/scsi/elx/libefc/efc_node.h+1348 -01 reply
13/31elx: libefc: Fabric node state machine interfacesdrivers/scsi/elx/libefc/efc_fabric.c drivers/scsi/elx/libefc/efc_fabric.h+1681 -01 reply
14/31elx: libefc: FC node ELS and state handlingdrivers/scsi/elx/libefc/efc_device.c drivers/scsi/elx/libefc/efc_device.h+1672 -01 reply
15/31elx: libefc: Extended link Service IO handlingdrivers/scsi/elx/libefc/efc_els.c drivers/scsi/elx/libefc/efc_els.h+1259 -01 reply
16/31elx: libefc: Register discovery objects with hardwaredrivers/scsi/elx/libefc/efc_cmds.c drivers/scsi/elx/libefc/efc_cmds.h+911 -01 reply
17/31elx: efct: Data structures and defines for hw operationsdrivers/scsi/elx/efct/efct_hw.h+603 -01 reply
18/31elx: efct: Driver initialization routinesdrivers/scsi/elx/efct/efct_driver.c drivers/scsi/elx/efct/efct_driver.h drivers/scsi/elx/efct/efct_hw.c +3 more+2805 -01 reply
19/31elx: efct: Hardware queues creation and deletiondrivers/scsi/elx/efct/efct_hw.h drivers/scsi/elx/efct/efct_hw_queues.c+681 -01 reply
20/31elx: efct: RQ buffer, memory pool allocation and deallocation APIsdrivers/scsi/elx/efct/efct_hw.c drivers/scsi/elx/efct/efct_hw.h+420 -01 reply
21/31elx: efct: Hardware IO and SGL initializationdrivers/scsi/elx/efct/efct_hw.c drivers/scsi/elx/efct/efct_hw.h+631 -01 reply
22/31elx: efct: Hardware queues processingdrivers/scsi/elx/efct/efct_hw.c drivers/scsi/elx/efct/efct_hw.h drivers/scsi/elx/efct/efct_io.c +1 more+761 -01 reply
23/31elx: efct: Unsolicited FC frame processing routinesdrivers/scsi/elx/efct/efct_unsol.c drivers/scsi/elx/efct/efct_unsol.h+512 -01 reply
24/31elx: efct: SCSI IO handling routinesdrivers/scsi/elx/efct/efct_scsi.c drivers/scsi/elx/efct/efct_scsi.h+1378 -01 reply
25/31elx: efct: LIO backend interface routinesdrivers/scsi/elx/efct/efct_lio.c drivers/scsi/elx/efct/efct_lio.h+1886 -01 reply
26/31elx: efct: Hardware IO submission routinesdrivers/scsi/elx/efct/efct_hw.c drivers/scsi/elx/efct/efct_hw.h+529 -01 reply
27/31elx: efct: link and host statisticsdrivers/scsi/elx/efct/efct_hw.c drivers/scsi/elx/efct/efct_hw.h+357 -01 reply
28/31elx: efct: xport and hardware teardown routinesdrivers/scsi/elx/efct/efct_hw.c drivers/scsi/elx/efct/efct_hw.h drivers/scsi/elx/efct/efct_xport.c+565 -01 reply
29/31elx: efct: scsi_transport_fc host interface supportdrivers/scsi/elx/efct/efct_xport.c+500 -01 reply
30/31elx: efct: Add Makefile and Kconfig for efct driverdrivers/scsi/elx/Kconfig drivers/scsi/elx/Makefile+27 -01 reply
31/31elx: efct: Tie into kernel Kconfig and build processdrivers/scsi/Kconfig drivers/scsi/Makefile+3 -01 reply

Reviews trailers per patch

19 of 31 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeDaniel Wagner
1/31R-b R-b
2/31R-b
3/31
4/31
5/31R-b R-b
6/31R-b R-b
7/31R-b R-b
8/31R-b R-b
9/31
10/31R-b
11/31
12/31
13/31R-b
14/31R-b
15/31
16/31
17/31R-b
18/31
19/31R-b
20/31
21/31
22/31R-b
23/31R-b
24/31R-b
25/31R-b
26/31R-b
27/31R-b
28/31
29/31
30/31R-b
31/31R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/31] [NEW] efct: Broadcom (Emulex) FC Target driver

This patch set is a request to incorporate the new Broadcom (Emulex) FC target driver, efct, into the kernel source tree.

The driver source has been Announced a couple of times, the last version on 4/11/2020. The driver has been hosted on gitlab for review has had contributions from the community.
gitlab ([email protected]:jsmart/efct-Emulex_FC_Target.git)

The driver integrates into the source tree at the (new) drivers/scsi/elx subdirectory.

The driver consists of the following components:
- A libefc_sli subdirectory: This subdirectory contains a library that encapsulates common definitions and routines for an Emulex SLI-4 adapter.
- A libefc subdirectory: This subdirectory contains a library of common routines. Of major import is a number of routines that implement a FC Discovery engine for target mode.
- An efct subdirectory: This subdirectory contains the efct target mode device driver. The driver utilizes the above librarys and plugs into the SCSI LIO interfaces. The driver is SCSI only at this time.

The patches populate the libraries and device driver and can only be compiled as a complete set.

This driver is completely independent from the lpfc device driver and there is no overlap on PCI ID's.

The patches have been cut against the 5.10/scsi-queue branch.

Thank you to those that have contributed to the driver in the past.

Review comments welcome!

-- james

V4 modifications:
Copyright year change.
Fixed cppcheck tool reported warnings.
Ran pahole tool, fixed padding for most of the structures. Support for Multiple RQs and EQs.
New user driver node structure to avoid lock contension in IO path. libefc_sli:
Add [email protected] in MAINTAINERS
Changed doorbell defines to inline functions
Code cleanup: Indentation, code simplification, unnecessary brackets Added SLI4_ prefix to missing defines
Moved driver specific structures to the end of the file. Page size calculation changes
Reduce function parameters for WQE filling functions Changed wait functions to use usleep_range and time_before apis Removed size input for all the cmds as its fixed to SLI4_BMBX_SIZE. Changed all SLI mbox routines to memset using SLI_BMBX_SIZE. All WQE helper routines to use sli->wqe_size for memset.
libefc:
Remove the " EFC_SM_EVENT_START" id and define SM events serially. Moved hold frames and pending frames handling to library. Added efc locking notes.
Added kref to domain, nport and node objects.
Renamed efc_sli_port object to efc_nport
Reworked on APIs and libefc_function_template.
Moved ELS handling to Library
Moved registering discovery objects to library.
Added issue_mbox_rqst, send_els, send_bls template functions. Changes to use new function template
Get Domain Ref count when a new nport is added
Release domain ref when nport is freed.
Renamed efc_sport.[ch] to efc_nport.[ch]
Add kref support for Nport structure.
Upon received PRLI, wait for LIO session registation before sending
the PRLI response.
Changes to call new els functions.
Move all state machine functions return value from void * to void. Replace fall through commnet with fallthrough statement. New patch added ELS handling to libefc library.
New els_io_req for discovery io object.
New patch cmds to register VFI, VPI and RPI.
Removed all hw related template calls and added issue_mbox_rqst
template call.
Consolidate all the discovery related mbox related cmds in discovery
library.
Replaced allocation of command buffer for mailbox with stack variable.
efct driver:
New library Template registration and associated functions Muti-RQ support, configure mrq.
Configure filter to send all ELS traffic to one RQ and remaining IOs
to all RQs.
CPU based WQ scaling.
Allocate loop map during initialization
Remove redundant includes in efc_driver.h
Remove els entries from scsi io object as discovery object handles it. Changed unsol frame handling.
Lookup for efct target node based on d_id and s_id.
Rework IO path to not look up discovery object every time. Changes to reduce function params for efct_hw_io_send Changes to create efct_node(user driver specific node) and store
lookup id.
Removed debugfs interface.
Reduced the argument list for WQE filling routines.

V3 modifications:
Changed anonymous enums to named enums
Split gaint enums into multiple enums
Use defines to spell out _MASK values directly
Changed multiple #defines to named enums and a few vice versa cases
for consistency
Added Link Speed support for up to 128G
Removed efc_assert define. Replaced with WARN_ON. Returned defined return values EFC_SUCCESS & EFC_FAIL Added return values for routines returning more than those 2 values Reduction of calling arguments in various routines. Expanded dump type and status handling
Fixed locking in discovery handling routines.
Fixed line formatting length and indentation issues. Removed code that was not used.
Removed Sparse Vector APIs and structures. Use xarray api instead. Changed node pool creation. Use mempool and allocate dma memory when
required
Bug Fix: Send LS_RJT for non FCP PRLIs
Removed Queue topology string and parsing routines and rework queue
creation. Adapter configuration is implicitly known by the driver
Used request_threaded_irq instead of using our thread Reworked efct_device_attach function to use if statements and gotos Changed efct_fw_reset, removed accessing other port Convert to used pci_alloc_irq_vectors api
Removed proc interface.
Changed assertion log messages.
Unified log message using cmd_name
Removed DIF related code which is not used
Removed SCSI get property
Incorporated LIO interface review comments
Reworked xxx_reg_vpi/vfi routines
Use SPDX license in elx/Makefile
Many more small changes.

V2 modifications:
Contains the following modifications based on prior review comments:
Indentation/Alignment/Spacing changes
Comments: format cleanup; removed obvious or unnecessary comments;
Added comments for clarity.
Headers use #ifndef comparing for prior inclusion
Cleanup structure names (remove _s suffix)
Encapsulate use of macro arguments
Refactor to remove static function declarations for static local routines Removed unused variables
Fix SLI4_INTF_VALID_MASK for 32bits
Ensure no BIT() use
Use __ffs() in page count macro
Reorg to move field defines out of structure definition Commonize command building routines to reduce duplication
LIO interface:
Removed scsi initiator includes
Cleaned up interface defines
Removed lio WWN version attribute.
Expanded macros within logging macros
Cleaned up lio state setting macro
Remove __force use
Modularized session debugfs code so can be easily replaced. Cleaned up abort task handling. Return after initiating. Modularized where possible to reduce duplication
Convert from kthread to workqueue use
Remove unused macros
Add missing TARGET_CORE build attribute
Fix kbuild test robot warnings

Comments not addressed:
Use of __packed: not believed necessary
Session debugfs code remains. There is not yet a common lio
mechanism to replace with.

James Smart (31):
elx: libefc_sli: SLI-4 register offsets and field definitions
elx: libefc_sli: SLI Descriptors and Queue entries
elx: libefc_sli: Data structures and defines for mbox commands
elx: libefc_sli: queue create/destroy/parse routines
elx: libefc_sli: Populate and post different WQEs
elx: libefc_sli: bmbx routines and SLI config commands
elx: libefc_sli: APIs to setup SLI library
elx: libefc: Generic state machine framework
elx: libefc: Emulex FC discovery library APIs and definitions
elx: libefc: FC Domain state machine interfaces
elx: libefc: SLI and FC PORT state machine interfaces
elx: libefc: Remote node state machine interfaces
elx: libefc: Fabric node state machine interfaces
elx: libefc: FC node ELS and state handling
elx: libefc: Extended link Service IO handling
elx: libefc: Register discovery objects with hardware
elx: efct: Data structures and defines for hw operations
elx: efct: Driver initialization routines
elx: efct: Hardware queues creation and deletion
elx: efct: RQ buffer, memory pool allocation and deallocation APIs
elx: efct: Hardware IO and SGL initialization
elx: efct: Hardware queues processing
elx: efct: Unsolicited FC frame processing routines
elx: efct: SCSI IO handling routines
elx: efct: LIO backend interface routines
elx: efct: Hardware IO submission routines
elx: efct: link and host statistics
elx: efct: xport and hardware teardown routines
elx: efct: scsi_transport_fc host interface support
elx: efct: Add Makefile and Kconfig for efct driver
elx: efct: Tie into kernel Kconfig and build process

 MAINTAINERS                            |    9 +
 drivers/scsi/Kconfig                   |    2 +
 drivers/scsi/Makefile                  |    1 +
 drivers/scsi/elx/Kconfig               |    9 +
 drivers/scsi/elx/Makefile              |   18 +
 drivers/scsi/elx/efct/efct_driver.c    |  810 ++++
 drivers/scsi/elx/efct/efct_driver.h    |  109 +
 drivers/scsi/elx/efct/efct_hw.c        | 3651 +++++++++++++++++
 drivers/scsi/elx/efct/efct_hw.h        |  782 ++++
 drivers/scsi/elx/efct/efct_hw_queues.c |  677 ++++
 drivers/scsi/elx/efct/efct_io.c        |  191 +
 drivers/scsi/elx/efct/efct_io.h        |  166 +
 drivers/scsi/elx/efct/efct_lio.c       | 1697 ++++++++
 drivers/scsi/elx/efct/efct_lio.h       |  189 +
 drivers/scsi/elx/efct/efct_scsi.c      | 1164 ++++++
 drivers/scsi/elx/efct/efct_scsi.h      |  214 +
 drivers/scsi/elx/efct/efct_unsol.c     |  495 +++
 drivers/scsi/elx/efct/efct_unsol.h     |   17 +
 drivers/scsi/elx/efct/efct_xport.c     | 1280 ++++++
 drivers/scsi/elx/efct/efct_xport.h     |  186 +
 drivers/scsi/elx/include/efc_common.h  |   44 +
 drivers/scsi/elx/libefc/efc.h          |   69 +
 drivers/scsi/elx/libefc/efc_cmds.c     |  877 ++++
 drivers/scsi/elx/libefc/efc_cmds.h     |   34 +
 drivers/scsi/elx/libefc/efc_device.c   | 1600 ++++++++
 drivers/scsi/elx/libefc/efc_device.h   |   72 +
 drivers/scsi/elx/libefc/efc_domain.c   | 1095 +++++
 drivers/scsi/elx/libefc/efc_domain.h   |   54 +
 drivers/scsi/elx/libefc/efc_els.c      | 1152 ++++++
 drivers/scsi/elx/libefc/efc_els.h      |  107 +
 drivers/scsi/elx/libefc/efc_fabric.c   | 1565 +++++++
 drivers/scsi/elx/libefc/efc_fabric.h   |  116 +
 drivers/scsi/elx/libefc/efc_lib.c      |   73 +
 drivers/scsi/elx/libefc/efc_node.c     | 1157 ++++++
 drivers/scsi/elx/libefc/efc_node.h     |  191 +
 drivers/scsi/elx/libefc/efc_nport.c    |  825 ++++
 drivers/scsi/elx/libefc/efc_nport.h    |   50 +
 drivers/scsi/elx/libefc/efc_sm.c       |   54 +
 drivers/scsi/elx/libefc/efc_sm.h       |  197 +
 drivers/scsi/elx/libefc/efclib.h       |  629 +++
 drivers/scsi/elx/libefc_sli/sli4.c     | 5185 ++++++++++++++++++++++++
 drivers/scsi/elx/libefc_sli/sli4.h     | 4106 +++++++++++++++++++
 42 files changed, 30919 insertions(+)
 create mode 100644 drivers/scsi/elx/Kconfig
 create mode 100644 drivers/scsi/elx/Makefile
 create mode 100644 drivers/scsi/elx/efct/efct_driver.c
 create mode 100644 drivers/scsi/elx/efct/efct_driver.h
 create mode 100644 drivers/scsi/elx/efct/efct_hw.c
 create mode 100644 drivers/scsi/elx/efct/efct_hw.h
 create mode 100644 drivers/scsi/elx/efct/efct_hw_queues.c
 create mode 100644 drivers/scsi/elx/efct/efct_io.c
 create mode 100644 drivers/scsi/elx/efct/efct_io.h
 create mode 100644 drivers/scsi/elx/efct/efct_lio.c
 create mode 100644 drivers/scsi/elx/efct/efct_lio.h
 create mode 100644 drivers/scsi/elx/efct/efct_scsi.c
 create mode 100644 drivers/scsi/elx/efct/efct_scsi.h
 create mode 100644 drivers/scsi/elx/efct/efct_unsol.c
 create mode 100644 drivers/scsi/elx/efct/efct_unsol.h
 create mode 100644 drivers/scsi/elx/efct/efct_xport.c
 create mode 100644 drivers/scsi/elx/efct/efct_xport.h
 create mode 100644 drivers/scsi/elx/include/efc_common.h
 create mode 100644 drivers/scsi/elx/libefc/efc.h
 create mode 100644 drivers/scsi/elx/libefc/efc_cmds.c
 create mode 100644 drivers/scsi/elx/libefc/efc_cmds.h
 create mode 100644 drivers/scsi/elx/libefc/efc_device.c
 create mode 100644 drivers/scsi/elx/libefc/efc_device.h
 create mode 100644 drivers/scsi/elx/libefc/efc_domain.c
 create mode 100644 drivers/scsi/elx/libefc/efc_domain.h
 create mode 100644 drivers/scsi/elx/libefc/efc_els.c
 create mode 100644 drivers/scsi/elx/libefc/efc_els.h
 create mode 100644 drivers/scsi/elx/libefc/efc_fabric.c
 create mode 100644 drivers/scsi/elx/libefc/efc_fabric.h
 create mode 100644 drivers/scsi/elx/libefc/efc_lib.c
 create mode 100644 drivers/scsi/elx/libefc/efc_node.c
 create mode 100644 drivers/scsi/elx/libefc/efc_node.h
 create mode 100644 drivers/scsi/elx/libefc/efc_nport.c
 create mode 100644 drivers/scsi/elx/libefc/efc_nport.h
 create mode 100644 drivers/scsi/elx/libefc/efc_sm.c
 create mode 100644 drivers/scsi/elx/libefc/efc_sm.h
 create mode 100644 drivers/scsi/elx/libefc/efclib.h
 create mode 100644 drivers/scsi/elx/libefc_sli/sli4.c
 create mode 100644 drivers/scsi/elx/libefc_sli/sli4.h
Signature · 1 line
2.26.2