Skip to content

PCI/ASPM: Cleanup

Bjorn Helgaas linux-pci 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest12 patches 1 replyIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12PCI/ASPM: Move pci_clear_and_set_dword() earlierdrivers/pci/pcie/aspm.c+11 -110 replies
2/12PCI/ASPM: Move LTR path check to where it's useddrivers/pci/pcie/aspm.c+8 -90 replies
3/12PCI/ASPM: Use 'parent' and 'child' for readabilitydrivers/pci/pcie/aspm.c+5 -40 replies
4/12PCI/ASPM: Remove struct aspm_register_info.supportdrivers/pci/pcie/aspm.c include/uapi/linux/pci_regs.h+16 -110 replies
5/12PCI/ASPM: Remove struct aspm_register_info.enableddrivers/pci/pcie/aspm.c+6 -80 replies
6/12PCI/ASPM: Remove struct aspm_register_info.latency_encodingdrivers/pci/pcie/aspm.c+10 -140 replies
7/12PCI/ASPM: Remove struct aspm_register_info.l1ss_cap_ptrdrivers/pci/pcie/aspm.c drivers/pci/probe.c include/linux/pci.h+19 -210 replies
8/12PCI/ASPM: Remove struct aspm_register_info.l1ss_ctl2 (unused)drivers/pci/pcie/aspm.c+1 -40 replies
9/12PCI/ASPM: Remove struct aspm_register_info.l1ss_ctl1drivers/pci/pcie/aspm.c+14 -120 replies
10/12PCI/ASPM: Pass L1SS Capabilities value, not struct aspm_register_infodrivers/pci/pcie/aspm.c+8 -90 replies
11/12PCI/ASPM: Remove struct aspm_register_info.l1ss_capdrivers/pci/pcie/aspm.c+21 -320 replies
12/12PCI/ASPM: Remove struct pcie_link_state.l1ssdrivers/pci/pcie/aspm.c+20 -351 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/12] PCI/ASPM: Cleanup

From: Bjorn Helgaas <[email protected]>

This is a v3 posting of Saheed's ASPM cleanup.

The intent is that this is strictly cleanup, no functional changes at all. We want to simplify the code by removing struct aspm_register_info and pcie_get_aspm_reg(). These are only used to read and store register info, but the info is only used in one place, so the function and struct only make things more complicated.

Previous postings:

v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]

Bjorn Helgaas (5):
PCI/ASPM: Move pci_clear_and_set_dword() earlier
PCI/ASPM: Move LTR path check to where it's used
PCI/ASPM: Use 'parent' and 'child' for readability PCI/ASPM: Remove struct aspm_register_info.l1ss_ctl2 (unused) PCI/ASPM: Pass L1SS Capabilities value, not struct aspm_register_info

Saheed O. Bolarinwa (7):
PCI/ASPM: Remove struct aspm_register_info.support PCI/ASPM: Remove struct aspm_register_info.enabled PCI/ASPM: Remove struct aspm_register_info.latency_encoding PCI/ASPM: Remove struct aspm_register_info.l1ss_cap_ptr PCI/ASPM: Remove struct aspm_register_info.l1ss_ctl1 PCI/ASPM: Remove struct aspm_register_info.l1ss_cap PCI/ASPM: Remove struct pcie_link_state.l1ss

 drivers/pci/pcie/aspm.c       | 265 +++++++++++++++-------------------
 drivers/pci/probe.c           |   3 +
 include/linux/pci.h           |   1 +
 include/uapi/linux/pci_regs.h |   2 +
 4 files changed, 120 insertions(+), 151 deletions(-)
Signature · 1 line
2.25.1