Skip to content

Various Polaris fixes and optimizations

Evan Quan amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest40 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/40drm/amd/pm: correct the checks for polaris kickersdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c+48 -490 replies
2/40drm/amd/pm: populate smc vddc tabledrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+26 -00 replies
3/40drm/amd/pm: populate smc samu tabledrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+53 -00 replies
4/40drm/amd/pm: correct vddci table setupdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+2 -20 replies
5/40drm/amd/pm: correct sclk table setupdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+21 -20 replies
6/40drm/amd/pm: correct mclk table setupdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+8 -120 replies
7/40drm/amd/pm: correct the ACPI table setup V2drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+2 -10 replies
8/40drm/amd/pm: correct the BootLinkLevel setupdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+1 -10 replies
9/40drm/amd/pm: add pptable VRHotLevel settingdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+3 -00 replies
10/40drm/amd/pm: drop arb table first byte workarounddrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+0 -310 replies
11/40drm/amdgpu: correct CG_ACLK_CNTL settingdrivers/gpu/drm/amd/amdgpu/gfx_v8_0.c+11 -30 replies
12/40drm/amd/pm: add PWR_CKS_CNTL settingdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+11 -40 replies
13/40drm/amd/powerplay: separate Polaris fan table setup from Tongadrivers/gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c+87 -10 replies
14/40drm/amd/pm: optimize AC timing programmingdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+1 -10 replies
15/40drm/amd/pm: drop redundant efuse mask calculationsdrivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c +1 more+10 -60 replies
16/40drm/amd/pm: correct the settings for ro range minimum and maximumdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.h+65 -00 replies
17/40drm/amd/pm: correct polaris10 clock stretcher data table settingdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+11 -310 replies
18/40drm/amd/pm: setup zero rpm parameters for polaris10drivers/gpu/drm/amd/pm/inc/smu7_ppsmc.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_thermal.c drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+29 -00 replies
19/40drm/amd/pm: add edc leakage controller settingdrivers/gpu/drm/amd/include/atombios.h drivers/gpu/drm/amd/pm/inc/smu7_ppsmc.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c +3 more+252 -00 replies
20/40drm/amd/pm: add mc register table initializationdrivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c +1 more+58 -00 replies
21/40drm/amd/pm: correct VR shared rail infodrivers/gpu/drm/amd/include/atombios.h drivers/gpu/drm/amd/pm/inc/smu74_discrete.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c +2 more+34 -20 replies
22/40drm/amd/pm: correct the checks for sclk/mclk SS supportdrivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h +1 more+26 -10 replies
23/40drm/amd/pm: correct Polaris powertune table setupdrivers/gpu/drm/amd/pm/inc/hwmgr.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c+85 -10 replies
24/40drm/amd/pm: correct Polaris DIDT configurationsdrivers/gpu/drm/amd/pm/inc/smu7_ppsmc.h drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c+34 -20 replies
25/40drm/amd/pm: correct avfs fuse settingsdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+23 -320 replies
26/40drm/amd/pm: correct vddc phase control settingdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+24 -140 replies
27/40drm/amd/pm: correct VRconfig settingdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+14 -10 replies
28/40drm/amd/pm: correct platformcaps setupdrivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+19 -40 replies
29/40drm/amd/pm: correct smc voltage controller setupdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+2 -10 replies
30/40drm/amd/pm: correct sclk/mclk dpm enablementdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+9 -30 replies
31/40drm/amd/pm: correct the way to get the highest vddcdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+28 -20 replies
32/40drm/amd/pm: correct clk/voltage dependence setupdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+2 -00 replies
33/40drm/amd/pm: correct pcie spc cap setupdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+2 -00 replies
34/40drm/amd/pm: correct SMC sclk/mclk boot level setupdrivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c+8 -00 replies
35/40drm/amd/pm: correct vddc_dep_on_dal_pwrl setupdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c+15 -30 replies
36/40drm/amd/pm: fulfill the Polaris implementation for get_clock_by_type_with_latency()drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+67 -00 replies
37/40drm/amd/pm: enable Polaris watermark table settingdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+60 -13 replies
38/40drm/amd/pm: correct the mclk switching settingdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.h+108 -170 replies
39/40drm/amd/pm: reconfigure smc on display vbitimeout setting changedrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.h+7 -00 replies
40/40drm/amd/pm: drop redundant display settingdrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c+0 -120 replies

Reviews trailers per patch

All 40 patches have a Reviewed-by or Acked-by.

PatchAlex Deucher
1/40A-b
2/40A-b
3/40A-b
4/40A-b
5/40A-b
6/40A-b
7/40A-b
8/40A-b
9/40A-b
10/40A-b
11/40A-b
12/40A-b
13/40A-b
14/40A-b
15/40A-b
16/40A-b
17/40A-b
18/40A-b
19/40A-b
20/40A-b
21/40A-b
22/40A-b
23/40A-b
24/40A-b
25/40A-b
26/40A-b
27/40A-b
28/40A-b
29/40A-b
30/40A-b
31/40A-b
32/40A-b
33/40A-b
34/40A-b
35/40A-b
36/40A-b
37/40A-b
38/40A-b
39/40A-b
40/40A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/40] Various Polaris fixes and optimizations

The fixes and optimizations include:
- Enable zero rpm fan feature
- Reduce the idle power for multiple displays setup
- Fix screen flicker issue seen on some mutiple displays setup
- Enable mclk switch for multiple synced displays
- Other alignments with Windows

Evan Quan (40):
drm/amd/pm: correct the checks for polaris kickers drm/amd/pm: populate smc vddc table
drm/amd/pm: populate smc samu table
drm/amd/pm: correct vddci table setup
drm/amd/pm: correct sclk table setup
drm/amd/pm: correct mclk table setup
drm/amd/pm: correct the ACPI table setup V2 drm/amd/pm: correct the BootLinkLevel setup drm/amd/pm: add pptable VRHotLevel setting
drm/amd/pm: drop arb table first byte workaround drm/amdgpu: correct CG_ACLK_CNTL setting
drm/amd/pm: add PWR_CKS_CNTL setting drm/amd/powerplay: separate Polaris fan table setup from Tonga drm/amd/pm: optimize AC timing programming
drm/amd/pm: drop redundant efuse mask calculations drm/amd/pm: correct the settings for ro range minimum and maximum drm/amd/pm: correct polaris10 clock stretcher data table setting drm/amd/pm: setup zero rpm parameters for polaris10 drm/amd/pm: add edc leakage controller setting drm/amd/pm: add mc register table initialization drm/amd/pm: correct VR shared rail info
drm/amd/pm: correct the checks for sclk/mclk SS support drm/amd/pm: correct Polaris powertune table setup drm/amd/pm: correct Polaris DIDT configurations drm/amd/pm: correct avfs fuse settings
drm/amd/pm: correct vddc phase control setting drm/amd/pm: correct VRconfig setting
drm/amd/pm: correct platformcaps setup
drm/amd/pm: correct smc voltage controller setup drm/amd/pm: correct sclk/mclk dpm enablement drm/amd/pm: correct the way to get the highest vddc drm/amd/pm: correct clk/voltage dependence setup drm/amd/pm: correct pcie spc cap setup
drm/amd/pm: correct SMC sclk/mclk boot level setup drm/amd/pm: correct vddc_dep_on_dal_pwrl setup drm/amd/pm: fulfill the Polaris implementation for
get_clock_by_type_with_latency()
drm/amd/pm: enable Polaris watermark table setting drm/amd/pm: correct the mclk switching setting drm/amd/pm: reconfigure smc on display vbitimeout setting change drm/amd/pm: drop redundant display setting

 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |  39 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c       |  34 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c         |  14 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |  24 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c  |  11 +-
 drivers/gpu/drm/amd/include/atombios.h        |  20 +-
 drivers/gpu/drm/amd/pm/inc/hwmgr.h            |   1 +
 drivers/gpu/drm/amd/pm/inc/smu74_discrete.h   |   3 +-
 drivers/gpu/drm/amd/pm/inc/smu7_ppsmc.h       |   6 +
 .../gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c    |  10 +-
 .../drm/amd/pm/powerplay/hwmgr/ppatomctrl.c   | 125 +++-
 .../drm/amd/pm/powerplay/hwmgr/ppatomctrl.h   |  28 +-
 .../drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h |  66 ++
 .../powerplay/hwmgr/process_pptables_v1_0.c   | 107 +++-
 .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c   | 572 ++++++++++++++++--
 .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.h   |  20 +
 .../amd/pm/powerplay/hwmgr/smu7_powertune.c   |  34 +-
 .../drm/amd/pm/powerplay/hwmgr/smu7_thermal.c |  11 +
 .../drm/amd/pm/powerplay/hwmgr/smu_helper.c   |  18 +-
 .../drm/amd/pm/powerplay/smumgr/fiji_smumgr.c |   3 +-
 .../pm/powerplay/smumgr/polaris10_smumgr.c    | 356 +++++++----
 .../pm/powerplay/smumgr/polaris10_smumgr.h    |   1 +
 .../amd/pm/powerplay/smumgr/vegam_smumgr.c    |   3 +-
 23 files changed, 1266 insertions(+), 240 deletions(-)
Signature · 6 lines
2.28.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx