Skip to content

microvm: add second ioapic

Gerd Hoffmann qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 8 repliesIn review
  2. v212 patches 7 repliesSuperseded
  3. v14 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- pick up some review tags.
- replace magic numbers with #defines.
- add asl changes to commit messages.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12disable xhci msixhw/usb/hcd-xhci-pci.c+1 -12 replies
2/12x86: rewrite gsi_handler()hw/i386/x86.c+10 -40 replies
3/12x86: add support for second ioapichw/i386/acpi-common.c hw/i386/x86.c include/hw/i386/ioapic.h +2 more+37 -11 reply
4/12microvm: make number of virtio transports runtime changeablehw/i386/microvm.c include/hw/i386/microvm.h+8 -31 reply
5/12microvm: make pcie irq base runtime changeablehw/i386/microvm.c include/hw/i386/microvm.h+7 -61 reply
6/12microvm: drop microvm_gsi_handler()hw/i386/microvm.c+1 -131 reply
7/12microvm: add second ioapichw/i386/microvm.c include/hw/i386/microvm.h tests/qtest/bios-tables-test.c+57 -91 reply
8/12tests/acpi: allow updates for expected data filestests/qtest/bios-tables-test-allowed-diff.h+2 -00 replies
9/12tests/acpi: add data files for ioapic2 test varianttests/data/acpi/microvm/APIC.ioapic2 tests/data/acpi/microvm/DSDT.ioapic2+0 -00 replies
10/12tests/acpi: add ioapic2=on test for microvmtests/qtest/bios-tables-test.c+12 -00 replies
11/12tests/acpi: update expected data filestests/data/acpi/microvm/APIC.ioapic2 tests/data/acpi/microvm/DSDT.ioapic2+0 -00 replies
12/12tests/acpi: disallow updates for expected data filestests/qtest/bios-tables-test-allowed-diff.h+0 -20 replies

Reviews trailers per patch

6 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIgor MammedovMichael S. TsirkinSergio Lopez
SeriesR-b
1/12
2/12R-b
3/12R-b
4/12R-b
5/12R-b R-b
6/12R-b R-b
7/12R-b
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/12] microvm: add second ioapic

Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices from 8 to 24.

v3:
- pick up some review tags.
- replace magic numbers with #defines.
- add asl changes to commit messages.
v2:
- reorganize code a bit.
- add ioapic2= option to microvm.

Gerd Hoffmann (12):
[testing] disable xhci msix
x86: rewrite gsi_handler()
x86: add support for second ioapic
microvm: make number of virtio transports runtime changeable
microvm: make pcie irq base runtime changeable
microvm: drop microvm_gsi_handler()
microvm: add second ioapic
tests/acpi: allow updates for expected data files tests/acpi: add data files for ioapic2 test variant tests/acpi: add ioapic2=on test for microvm tests/acpi: update expected data files
tests/acpi: disallow updates for expected data files

 include/hw/i386/ioapic.h             |   2 +
 include/hw/i386/ioapic_internal.h    |   2 +-
 include/hw/i386/microvm.h            |   6 +-
 include/hw/i386/x86.h                |   3 +
 hw/i386/acpi-common.c                |  10 ++++
 hw/i386/microvm.c                    |  82 ++++++++++++++++++++-------
 hw/i386/x86.c                        |  35 ++++++++++--
 hw/usb/hcd-xhci-pci.c                |   2 +-
 tests/qtest/bios-tables-test.c       |  20 +++++--
 tests/data/acpi/microvm/APIC.ioapic2 | Bin 0 -> 82 bytes
 tests/data/acpi/microvm/DSDT.ioapic2 | Bin 0 -> 365 bytes
 11 files changed, 129 insertions(+), 33 deletions(-)
 create mode 100644 tests/data/acpi/microvm/APIC.ioapic2
 create mode 100644 tests/data/acpi/microvm/DSDT.ioapic2
Signature · 1 line
2.27.0