Skip to content

blk-mq/nvme-tcp: fix timed out related races

Ming Lei linux-block linux-nvme 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesIn review
  2. v14 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- re-order patch3 and patch4
- fix comment
- improve patch "nvme: tcp: fix race between timeout and normal completion"

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4blk-mq: check rq->state explicitly in blk_mq_tagset_count_completed_rqsblock/blk-flush.c block/blk-mq-tag.c+3 -10 replies
2/4blk-mq: fix blk_mq_request_completedinclude/linux/blk-mq.h+7 -10 replies
3/4nvme: tcp: complete non-IO requests atomicallydrivers/nvme/host/tcp.c+37 -35 replies
4/4nvme: tcp: fix race between timeout and normal completiondrivers/nvme/host/tcp.c+39 -190 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchYi Zhang
1/4T-b
2/4T-b
3/4T-b
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/4] blk-mq/nvme-tcp: fix timed out related races

Hi,

The 1st 2 patches fixes request completion related races.

The 2nd 3 patches fixes/improves nvme-tcp error recovery.

With the 4 patches, nvme/012 can pass on nvme-tcp in Zhang Yi's test machine.

V2:
- re-order patch3 and patch4
- fix comment
- improve patch "nvme: tcp: fix race between timeout and normal completion"

Ming Lei (4):
blk-mq: check rq->state explicitly in
blk_mq_tagset_count_completed_rqs
blk-mq: fix blk_mq_request_completed
nvme: tcp: complete non-IO requests atomically
nvme: tcp: fix race between timeout and normal completion

 block/blk-flush.c       |  2 +
 block/blk-mq-tag.c      |  2 +-
 drivers/nvme/host/tcp.c | 98 ++++++++++++++++++++++++++++++++---------
 include/linux/blk-mq.h  |  8 +++-
 4 files changed, 86 insertions(+), 24 deletions(-)
CC Chao Leng <[email protected]>
Cc Sagi Grimberg <[email protected]>
Cc Yi Zhang <[email protected]>
Signature · 1 line
2.25.2