Skip to content

nvme-fc: clean up error recovery implementation

James Smart linux-nvme 2 versions – Applied

Status from this message: applied to nvme-5.10.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesApplied
  2. v14 patches 4 repliesSuperseded

Changes in v2 from the cover letter

Extracted v1's patch4 (the track error_recovery patch) into it's own patch as it is a fix, not a cleanup. That patch was posted on its own.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3nvme-fc: remove err_work work itemdrivers/nvme/host/fc.c+10 -300 replies
2/3nvme-fc: eliminate terminate_io use by nvme_fc_error_recoverydrivers/nvme/host/fc.c+84 -1032 replies
3/3nvme-fc: remove nvme_fc_terminate_io()drivers/nvme/host/fc.c+16 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] nvme-fc: clean up error recovery implementation

After reviewing the error_recovery paths to address the abort on the io to cover timeouts on connecting ios, it became clear that some of the thing in the way it was coded were unnecessary.

This patch set cleans up those items and refactors. It then addresses the failure case of io errors during reconnect which wants to take the create failure cases, but there is no status back from the core routines to trigger that path.

Note: this assumes the patch "nvme_fc: track error_recovery while connecting" has been applied already

V2:
Extracted v1's patch4 (the track error_recovery patch) into it's own patch as it is a fix, not a cleanup. That patch was posted on its own.

James Smart (3):
nvme-fc: remove err_work work item
nvme-fc: eliminate terminate_io use by nvme_fc_error_recovery
nvme-fc: remove nvme_fc_terminate_io()

 drivers/nvme/host/fc.c | 258 ++++++++++++++++-------------------------
 1 file changed, 101 insertions(+), 157 deletions(-)
Signature · 1 line
2.26.2

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme