Skip to content

ui: build spice and opengl as module.

Gerd Hoffmann qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14spice: add module helpersinclude/ui/qemu-spice-module.h include/ui/qemu-spice.h ui/meson.build +2 more+48 -40 replies
2/14spice: add QemuSpiceOps, move migrate_infoinclude/ui/qemu-spice-module.h include/ui/qemu-spice.h monitor/misc.c +2 more+21 -61 reply
3/14spice: move qemu_spice_init() to QemuSpiceOps.include/ui/qemu-spice-module.h include/ui/qemu-spice.h softmmu/vl.c +2 more+9 -70 replies
4/14spice: move display_init() to QemuSpiceOps.include/ui/qemu-spice-module.h include/ui/qemu-spice.h softmmu/vl.c +2 more+12 -80 replies
5/14spice: move add_interface() to QemuSpiceOps.audio/spiceaudio.c chardev/spice.c include/ui/qemu-spice-module.h +3 more+16 -90 replies
6/14spice: move auth functions to QemuSpiceOps.include/ui/qemu-spice-module.h include/ui/qemu-spice.h monitor/qmp-cmds.c +2 more+25 -200 replies
7/14spice: move display_add_client() to QemuSpiceOps.include/ui/qemu-spice-module.h include/ui/qemu-spice.h monitor/qmp-cmds.c +2 more+11 -80 replies
8/14spice: wire up monitor in QemuSpiceOps.include/ui/qemu-spice-module.h ui/spice-core.c ui/spice-module.c+22 -10 replies
9/14spice: load module when enabled on the cmdlinesoftmmu/vl.c+5 -10 replies
10/14modules: dependencies infrastructureutil/module.c+27 -50 replies
11/14modules: add spice dependenciesutil/module.c+5 -00 replies
12/14spice: flip modules switchui/meson.build+10 -10 replies
13/14opengl: build egl-headless display modularui/meson.build+7 -10 replies
14/14opengl: build opengl helper code modularui/meson.build util/module.c+14 -10 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc-André Lureau
SeriesR-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] ui: build spice and opengl as module.

- Add QemuSpiceOps, reorganize spice stubs.
- Add support for module dependencies.
- Build spice-core modular, and make the existing spice modules (audio, chardev, qxl) depend on spice-core.
- Build egl-headless display and opengl helpers modular (pretty easy thanks to module dependencies).

Gerd Hoffmann (14):
spice: add module helpers
spice: add QemuSpiceOps, move migrate_info
spice: move qemu_spice_init() to QemuSpiceOps.
spice: move display_init() to QemuSpiceOps.
spice: move add_interface() to QemuSpiceOps.
spice: move auth functions to QemuSpiceOps.
spice: move display_add_client() to QemuSpiceOps.
spice: wire up monitor in QemuSpiceOps.
spice: load module when enabled on the cmdline
modules: dependencies infrastructure
modules: add spice dependencies
spice: flip modules switch
opengl: build egl-headless display modular
opengl: build opengl helper code modular

 include/ui/qemu-spice-module.h | 44 ++++++++++++++++++
 include/ui/qemu-spice.h        | 42 +----------------
 audio/spiceaudio.c             |  4 +-
 chardev/spice.c                |  2 +-
 monitor/misc.c                 |  2 +-
 monitor/qmp-cmds.c             |  6 +--
 softmmu/vl.c                   | 10 ++--
 ui/spice-core.c                | 31 +++++++++----
 ui/spice-input.c               |  6 +--
 ui/spice-module.c              | 85 ++++++++++++++++++++++++++++++++++
 util/module.c                  | 44 ++++++++++++++++--
 ui/meson.build                 | 28 +++++++++--
 12 files changed, 232 insertions(+), 72 deletions(-)
 create mode 100644 include/ui/qemu-spice-module.h
 create mode 100644 ui/spice-module.c
Signature · 1 line
2.27.0