add max SIMD bitwidth to EAL
Get series with b4
b4 am [email protected]Versions newest first
- v10 Latest18 patches 1 replyIn review
Changes in v10 from the cover letter
- Updated API namespace and moved it to rte_vect.h,
- Split patch 2 and merged relevant parts in patch 1,
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | eal: control max SIMD bitwidthdoc/ doc/ doc/ +9 more | +194 | 0 replies | |
| 2/18 | doc: describe how to enable AVX512doc/ doc/ | +37 | 0 replies | |
| 3/18 | net/i40e: check max SIMD bitwidthdrivers/ | +13 | 0 replies | |
| 4/18 | net/axgbe: check max SIMD bitwidthdrivers/ | +3 | 0 replies | |
| 5/18 | net/bnxt: check max SIMD bitwidthdrivers/ | +5 | 0 replies | |
| 6/18 | net/enic: check max SIMD bitwidthdrivers/ | +3 | 0 replies | |
| 7/18 | net/fm10k: check max SIMD bitwidthdrivers/ | +7 | 0 replies | |
| 8/18 | net/iavf: check max SIMD bitwidthdrivers/ | +11 | 0 replies | |
| 9/18 | net/ice: check max SIMD bitwidthdrivers/ | +11 | 0 replies | |
| 10/18 | net/ixgbe: check max SIMD bitwidthdrivers/ | +5 | 0 replies | |
| 11/18 | net/mlx5: check max SIMD bitwidthdrivers/ | +3 | 0 replies | |
| 12/18 | net/virtio: check max SIMD bitwidthdrivers/ | +9 | 0 replies | |
| 13/18 | distributor: check max SIMD bitwidthlib/ | +3 | 0 replies | |
| 14/18 | member: check max SIMD bitwidthlib/ | +3 | 0 replies | |
| 15/18 | efd: check max SIMD bitwidthlib/ | +6 | 0 replies | |
| 16/18 | net: check max SIMD bitwidthlib/ | +86 | 0 replies | |
| 17/18 | node: choose vector path at runtimelib/ lib/ lib/ | +12 | 0 replies | |
| 18/18 | acl: check max SIMD bitwidthdoc/ lib/ lib/ | +47 | 0 replies |
Reviews trailers per patch
All 18 patches have a Reviewed-by or Acked-by.
| Patch | Konstantin Ananyev | Ruifeng Wang | Ray Kinsella | Kevin Laatz | Amaranath Somalapuram | Hyong Youb Kim | Somnath Kotur | Qi Zhang | Bruce Richardson | Haiyue Wang | Viacheslav Ovsiienko | Chenbo Xia | Maxime Coquelin | Yipeng Wang | David Hunt | Nithin Dabilpuram | Jasvinder Singh |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1/18 | A-b | R-b | A-b | ||||||||||||||
| 2/18 | A-b | ||||||||||||||||
| 3/18 | A-b | ||||||||||||||||
| 4/18 | A-b | ||||||||||||||||
| 5/18 | A-b | ||||||||||||||||
| 6/18 | A-b | ||||||||||||||||
| 7/18 | A-b | ||||||||||||||||
| 8/18 | R-b | ||||||||||||||||
| 9/18 | A-b | ||||||||||||||||
| 10/18 | A-b | R-b | |||||||||||||||
| 11/18 | A-b | ||||||||||||||||
| 12/18 | R-b | A-b | |||||||||||||||
| 13/18 | A-b | ||||||||||||||||
| 14/18 | A-b | ||||||||||||||||
| 15/18 | A-b | ||||||||||||||||
| 16/18 | A-b | ||||||||||||||||
| 17/18 | A-b | ||||||||||||||||
| 18/18 | A-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 17 reviewers.
Cover letter [dpdk-dev] [PATCH v10 00/18] add max SIMD bitwidth to EAL
From: Ciara Power <[email protected]>
A number of components in DPDK have optional AVX-512 or other vector code paths which can be selected at runtime. Rather than having each component provide its own mechanism to select a code path, this patchset adds support for a single setting to control what code paths are used. This can be used to enable some non-default code paths e.g. ones using AVX-512, but also to limit the code paths to certain vector widths, or to scalar code only, which is useful for testing.
The max SIMD bitwidth setting can be set by the app itself through use of the available API, or can be overriden by a commandline argument passed by the user.
v10:
- Updated API namespace and moved it to rte_vect.h,
- Split patch 2 and merged relevant parts in patch 1,
v9:
- Rebased onto main.
- Added release note.
v8:
- Rebased onto main.
- Fixed ACL patch to include AVX512X32 as a default option,
and modified docs to reflect that change.
v7: Fixed comments on v6.
v6:
- Rebased on main.
- Added ACL patch based on recent changes to the library.
- Modified net library patch based on recent rework.
- Fixed comments on the v5.
v5: Fixed cc list.
v4:
- Dropped LPM patch as the lookupx4 function is called from SSE/NEON headers, so is already on a vectorised path. Given the performance impact for an unnecessary change, it was decided the check is not needed.
- Renamed enum values for readability.
- Added patch to add check for node library.
- Reworked net patch to choose default handlers rather than scalar by default.
- Updated some Doxygen comments.
- Fixed some other small comments on v3.
v3:
- Added patch to add check for LPM lib
- Modified default max bitwidth for Arm to disable max SIMD bitwidth, which will allow for SVE.
- Added "0" as an acceptable value for command-line flag, which internally is used as UINT16_MAX to essentially disable max SIMD bitwidth limits.
- Made suggested changes to net lib patch.
- Rebased onto main.
v2:
- Added some documentation.
- Modified default max bitwidth for Arm.
- Moved mlx5 condition check into existing check vec support function.
- Added max SIMD bitwidth checks to some libraries.
Ciara Power (18):
eal: control max SIMD bitwidth
doc: describe how to enable AVX512
net/i40e: check max SIMD bitwidth
net/axgbe: check max SIMD bitwidth
net/bnxt: check max SIMD bitwidth
net/enic: check max SIMD bitwidth
net/fm10k: check max SIMD bitwidth
net/iavf: check max SIMD bitwidth
net/ice: check max SIMD bitwidth
net/ixgbe: check max SIMD bitwidth
net/mlx5: check max SIMD bitwidth
net/virtio: check max SIMD bitwidth
distributor: check max SIMD bitwidth
member: check max SIMD bitwidth
efd: check max SIMD bitwidth
net: check max SIMD bitwidth
node: choose vector path at runtime
acl: check max SIMD bitwidth
doc/guides/howto/avx512.rst | 36 ++++++ doc/guides/howto/index.rst | 1 + doc/guides/linux_gsg/eal_args.include.rst | 16 +++ .../prog_guide/env_abstraction_layer.rst | 34 +++++ .../prog_guide/packet_classif_access_ctrl.rst | 16 +-- doc/guides/rel_notes/release_20_11.rst | 6 + drivers/net/axgbe/axgbe_rxtx.c | 4 +- drivers/net/bnxt/bnxt_ethdev.c | 7 +- drivers/net/enic/enic_rxtx_vec_avx2.c | 4 +- drivers/net/fm10k/fm10k_ethdev.c | 10 +- drivers/net/i40e/i40e_rxtx.c | 19 ++- drivers/net/iavf/iavf_rxtx.c | 17 ++- drivers/net/ice/ice_rxtx.c | 17 ++- drivers/net/ixgbe/ixgbe_rxtx.c | 6 +- drivers/net/mlx5/mlx5_rxtx_vec.c | 3 + drivers/net/virtio/virtio_ethdev.c | 10 +- lib/librte_acl/rte_acl.c | 53 +++++--- lib/librte_acl/rte_acl.h | 1 + lib/librte_distributor/rte_distributor.c | 4 +- lib/librte_eal/arm/include/rte_vect.h | 2 + lib/librte_eal/common/eal_common_options.c | 66 ++++++++++ lib/librte_eal/common/eal_internal_cfg.h | 8 ++ lib/librte_eal/common/eal_options.h | 2 + lib/librte_eal/include/generic/rte_vect.h | 53 +++++++- lib/librte_eal/ppc/include/rte_vect.h | 2 + lib/librte_eal/rte_eal_exports.def | 3 + lib/librte_eal/rte_eal_version.map | 2 + lib/librte_eal/x86/include/rte_vect.h | 2 + lib/librte_efd/rte_efd.c | 8 +- lib/librte_member/rte_member_ht.c | 4 +- lib/librte_net/rte_net_crc.c | 117 +++++++++++++----- lib/librte_node/ip4_lookup.c | 15 ++- lib/librte_node/ip4_lookup_neon.h | 2 +- lib/librte_node/ip4_lookup_sse.h | 2 +- 34 files changed, 458 insertions(+), 94 deletions(-) create mode 100644 doc/guides/howto/avx512.rst
Signature · 1 line
2.23.0