net/virtio-user: fix server mode
Status from this message: Applied to dpdk-next-virtio/main.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 6 repliesApplied
- v23 patches 10 repliesSuperseded
- v11 patch 6 repliesSuperseded
Changes in v3 from the cover letter
Fix potential concurrency problem on get/set state Handle STATUS protocol feature flag
Fix undefined behaviour if STATUS feature is not supported Ensure packed virtqueues are reset on reconnection
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | net/virtio-user: fix backend selection if stat failsdrivers/ drivers/ drivers/ | +13 | 0 replies | |
| 2/6 | net/virtio-user: don't set/get_status until FEATURES_OKdrivers/ | +6 | 0 replies | |
| 3/6 | net/virtio-user: ignore result if STATUS is unsupporteddrivers/ drivers/ | +15 | 1 reply | |
| 4/6 | net/virtio-user: lock-protect status updatesdrivers/ drivers/ drivers/ | +16 | 1 reply | |
| 5/6 | net/virtio-user: don't assume vhost status featuredrivers/ drivers/ | +14 | 1 reply | |
| 6/6 | net/virtio-user: set status on socket reconnectdrivers/ | +15 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Maxime Coquelin | Kevin Traynor | JiangYuX |
|---|---|---|---|
| Series | T-b | ||
| 1/6 | R-b | A-b | |
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | R-b | ||
| 5/6 | R-b | ||
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [dpdk-dev] [PATCH v3 0/6] net/virtio-user: fix server mode
A number of issues have been detected that currently break virtio-user server mode.
This series addresses such issues.
Note that virtio-user server mode is broken by design and many of the problems that it currently has should be fixed by a bigger rework.
--v2->v3:
Fix potential concurrency problem on get/set state Handle STATUS protocol feature flag
Fix undefined behaviour if STATUS feature is not supported Ensure packed virtqueues are reset on reconnection
v1->v2:
Added patch 2 and 3 addressing additional issues
Check errno to select vhost-user backend and log the detected backend type
Adrian Moreno (6):
net/virtio-user: fix backend selection if stat fails net/virtio-user: don't set/get_status until FEATURES_OK net/virtio-user: ignore result if STATUS is unsupported net/virtio-user: lock-protect status updates net/virtio-user: don't assume vhost status feature net/virtio-user: set status on socket reconnect
drivers/net/virtio/virtio_user/vhost_user.c | 14 ++--- .../net/virtio/virtio_user/virtio_user_dev.c | 53 +++++++++++++------ .../net/virtio/virtio_user/virtio_user_dev.h | 5 +- drivers/net/virtio/virtio_user_ethdev.c | 40 ++++++++++---- 4 files changed, 78 insertions(+), 34 deletions(-)
Signature · 1 line
2.26.2