util/vfio-helpers: Allow using multiple MSIX IRQs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest19 patches 18 repliesIn review
- v116 patches 17 repliesSuperseded
Changes in v2 from the cover letter
- Addressed Stefan comment in patch #14
"Pass minimum page size to qemu_vfio_open_pci"
(check the page size is in range with device)
- To reduce (and simplify) changes in patch #14, added new patch #2 "Introduce device/iommu 'page_size_min' variables"
- Added "Trace controller capabilities" useful to test the previous changes
- "Set request_alignment at initialization" reported by Stefan (and tested by Eric off-list).
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | block/nvme: Correct minimum device page sizeblock/ | +1 | 1 reply | |
| 2/19 | block/nvme: Set request_alignment at initializationblock/ | +1 | 2 replies | |
| 3/19 | block/nvme: Introduce device/iommu 'page_size_min' variablesblock/ | +4 | 2 replies | |
| 4/19 | block/nvme: Trace controller capabilitiesblock/ block/ | +11 | 2 replies | |
| 5/19 | util/vfio-helpers: Improve reporting unsupported IOMMU typeutil/ | +1 | 0 replies | |
| 6/19 | util/vfio-helpers: Trace PCI I/O config accessesutil/ util/ | +10 | 1 reply | |
| 7/19 | util/vfio-helpers: Trace PCI BAR region infoutil/ util/ | +9 | 1 reply | |
| 8/19 | util/vfio-helpers: Trace where BARs are mappedutil/ util/ | +3 | 0 replies | |
| 9/19 | util/vfio-helpers: Improve DMA trace eventsutil/ util/ | +5 | 0 replies | |
| 10/19 | util/vfio-helpers: Convert vfio_dump_mapping to trace eventsutil/ util/ | +5 | 0 replies | |
| 11/19 | util/vfio-helpers: Let qemu_vfio_dma_map() propagate Errorblock/ include/ util/ | +15 | 1 reply | |
| 12/19 | util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Errorutil/ | +4 | 1 reply | |
| 13/19 | util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report()util/ | +2 | 0 replies | |
| 14/19 | util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci()block/ include/ util/ | +22 | 1 reply | |
| 15/19 | util/vfio-helpers: Report error when IOMMU page size is not supportedutil/ util/ | +27 | 1 reply | |
| 16/19 | util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs()include/ util/ util/ | +70 | 1 reply | |
| 17/19 | util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq()include/ util/ util/ | +38 | 1 reply | |
| 18/19 | block/nvme: Switch to using the MSIX APIblock/ | +12 | 2 replies | |
| 19/19 | util/vfio-helpers: Remove now unused qemu_vfio_pci_init_irq()include/ util/ | +0 | 0 replies |
Reviews trailers per patch
18 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Stefan Hajnoczi | Fam Zheng | Eric Auger |
|---|---|---|---|
| 1/19 | R-b | R-b | |
| 2/19 | R-b | R-b | |
| 3/19 | R-b | ||
| 4/19 | R-b | ||
| 5/19 | R-b | R-b | |
| 6/19 | R-b | R-b | |
| 7/19 | R-b | R-b | |
| 8/19 | R-b | R-b | |
| 9/19 | R-b | R-b | |
| 10/19 | R-b | R-b | |
| 11/19 | R-b | R-b | |
| 12/19 | R-b | R-b | |
| 13/19 | R-b | R-b | |
| 14/19 | |||
| 15/19 | R-b | ||
| 16/19 | R-b | ||
| 17/19 | R-b | R-b | |
| 18/19 | R-b | ||
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/19] util/vfio-helpers: Allow using multiple MSIX IRQs
This series allow using multiple MSIX IRQs
We currently share a single IRQ between 2 NVMe queues (ADMIN and I/O). This series still uses 1 shared IRQ but prepare for using multiple ones.
Since v1:
- Addressed Stefan comment in patch #14
"Pass minimum page size to qemu_vfio_open_pci"
(check the page size is in range with device)
- To reduce (and simplify) changes in patch #14, added new patch #2 "Introduce device/iommu 'page_size_min' variables"
- Added "Trace controller capabilities" useful to test the previous changes
- "Set request_alignment at initialization" reported by Stefan (and tested by Eric off-list).
Missing review: 2,3,4,14
$ git backport-diff -u v1 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respective= ly
001/19:[----] [--] 'block/nvme: Correct minimum device page size' 002/19:[down] 'block/nvme: Set request_alignment at initialization' 003/19:[down] 'block/nvme: Introduce device/iommu 'page_size_min' variables' 004/19:[down] 'block/nvme: Trace controller capabilities' 005/19:[----] [--] 'util/vfio-helpers: Improve reporting unsupported IOMMU ty= pe'
006/19:[----] [-C] 'util/vfio-helpers: Trace PCI I/O config accesses' 007/19:[----] [-C] 'util/vfio-helpers: Trace PCI BAR region info' 008/19:[----] [-C] 'util/vfio-helpers: Trace where BARs are mapped' 009/19:[----] [-C] 'util/vfio-helpers: Improve DMA trace events' 010/19:[----] [-C] 'util/vfio-helpers: Convert vfio_dump_mapping to trace eve= nts'
011/19:[----] [-C] 'util/vfio-helpers: Let qemu_vfio_dma_map() propagate Erro= r'
012/19:[----] [--] 'util/vfio-helpers: Let qemu_vfio_do_mapping() propagate E= rror'
013/19:[----] [--] 'util/vfio-helpers: Let qemu_vfio_verify_mappings() use er= ror_report()'
014/19:[0017] [FC] 'util/vfio-helpers: Pass minimum page size to qemu_vfio_op= en_pci()'
015/19:[----] [-C] 'util/vfio-helpers: Report error when IOMMU page size is n= ot supported'
016/19:[----] [--] 'util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs= ()'
017/19:[----] [--] 'util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq()' 018/19:[----] [-C] 'block/nvme: Switch to using the MSIX API' 019/19:[----] [--] 'util/vfio-helpers: Remove now unused qemu_vfio_pci_init_i= rq()'
Philippe Mathieu-Daud=C3=A9 (19):
block/nvme: Correct minimum device page size
block/nvme: Set request_alignment at initialization block/nvme: Introduce device/iommu 'page_size_min' variables block/nvme: Trace controller capabilities util/vfio-helpers: Improve reporting unsupported IOMMU type util/vfio-helpers: Trace PCI I/O config accesses util/vfio-helpers: Trace PCI BAR region info util/vfio-helpers: Trace where BARs are mapped util/vfio-helpers: Improve DMA trace events util/vfio-helpers: Convert vfio_dump_mapping to trace events util/vfio-helpers: Let qemu_vfio_dma_map() propagate Error util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report() util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci() util/vfio-helpers: Report error when IOMMU page size is not supported util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs() util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq() block/nvme: Switch to using the MSIX API util/vfio-helpers: Remove now unused qemu_vfio_pci_init_irq()
include/qemu/vfio-helpers.h | 15 ++- block/nvme.c | 58 +++++++++--- util/vfio-helpers.c | 183 +++++++++++++++++++++++++++--------- block/trace-events | 1 + util/trace-events | 13 ++- 5 files changed, 208 insertions(+), 62 deletions(-)
--=20
2.26.2