Skip to content

util/vfio-helpers: Allow using multiple MSIX IRQs

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 18 repliesIn review
  2. v116 patches 17 repliesSuperseded

Changes in v2 from the cover letter

- Addressed Stefan comment in patch #14
"Pass minimum page size to qemu_vfio_open_pci"
(check the page size is in range with device)
- To reduce (and simplify) changes in patch #14, added new patch #2 "Introduce device/iommu 'page_size_min' variables"
- Added "Trace controller capabilities" useful to test the previous changes
- "Set request_alignment at initialization" reported by Stefan (and tested by Eric off-list).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19block/nvme: Correct minimum device page sizeblock/nvme.c+1 -11 reply
2/19block/nvme: Set request_alignment at initializationblock/nvme.c+1 -02 replies
3/19block/nvme: Introduce device/iommu 'page_size_min' variablesblock/nvme.c+4 -12 replies
4/19block/nvme: Trace controller capabilitiesblock/nvme.c block/trace-events+11 -02 replies
5/19util/vfio-helpers: Improve reporting unsupported IOMMU typeutil/vfio-helpers.c+1 -10 replies
6/19util/vfio-helpers: Trace PCI I/O config accessesutil/trace-events util/vfio-helpers.c+10 -01 reply
7/19util/vfio-helpers: Trace PCI BAR region infoutil/trace-events util/vfio-helpers.c+9 -01 reply
8/19util/vfio-helpers: Trace where BARs are mappedutil/trace-events util/vfio-helpers.c+3 -00 replies
9/19util/vfio-helpers: Improve DMA trace eventsutil/trace-events util/vfio-helpers.c+5 -30 replies
10/19util/vfio-helpers: Convert vfio_dump_mapping to trace eventsutil/trace-events util/vfio-helpers.c+5 -150 replies
11/19util/vfio-helpers: Let qemu_vfio_dma_map() propagate Errorblock/nvme.c include/qemu/vfio-helpers.h util/vfio-helpers.c+15 -131 reply
12/19util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Errorutil/vfio-helpers.c+4 -41 reply
13/19util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report()util/vfio-helpers.c+2 -20 replies
14/19util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci()block/nvme.c include/qemu/vfio-helpers.h util/vfio-helpers.c+22 -31 reply
15/19util/vfio-helpers: Report error when IOMMU page size is not supportedutil/trace-events util/vfio-helpers.c+27 -21 reply
16/19util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs()include/qemu/vfio-helpers.h util/trace-events util/vfio-helpers.c+70 -21 reply
17/19util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq()include/qemu/vfio-helpers.h util/trace-events util/vfio-helpers.c+38 -01 reply
18/19block/nvme: Switch to using the MSIX APIblock/nvme.c+12 -22 replies
19/19util/vfio-helpers: Remove now unused qemu_vfio_pci_init_irq()include/qemu/vfio-helpers.h util/vfio-helpers.c+0 -450 replies

Reviews trailers per patch

18 of 19 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziFam ZhengEric Auger
1/19R-b R-b
2/19R-b R-b
3/19R-b
4/19R-b
5/19R-b R-b
6/19R-b R-b
7/19R-b R-b
8/19R-b R-b
9/19R-b R-b
10/19R-b R-b
11/19R-b R-b
12/19R-b R-b
13/19R-b R-b
14/19
15/19R-b
16/19R-b
17/19R-b R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/19] util/vfio-helpers: Allow using multiple MSIX IRQs

This series allow using multiple MSIX IRQs
We currently share a single IRQ between 2 NVMe queues (ADMIN and I/O). This series still uses 1 shared IRQ but prepare for using multiple ones.

Since v1:
- Addressed Stefan comment in patch #14
"Pass minimum page size to qemu_vfio_open_pci"
(check the page size is in range with device)
- To reduce (and simplify) changes in patch #14, added new patch #2 "Introduce device/iommu 'page_size_min' variables"
- Added "Trace controller capabilities" useful to test the previous changes
- "Set request_alignment at initialization" reported by Stefan (and tested by Eric off-list).

Missing review: 2,3,4,14

$ git backport-diff -u v1
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respective=
ly

001/19:[----] [--] 'block/nvme: Correct minimum device page size' 002/19:[down] 'block/nvme: Set request_alignment at initialization' 003/19:[down] 'block/nvme: Introduce device/iommu 'page_size_min' variables' 004/19:[down] 'block/nvme: Trace controller capabilities' 005/19:[----] [--] 'util/vfio-helpers: Improve reporting unsupported IOMMU ty= pe'
006/19:[----] [-C] 'util/vfio-helpers: Trace PCI I/O config accesses' 007/19:[----] [-C] 'util/vfio-helpers: Trace PCI BAR region info' 008/19:[----] [-C] 'util/vfio-helpers: Trace where BARs are mapped' 009/19:[----] [-C] 'util/vfio-helpers: Improve DMA trace events' 010/19:[----] [-C] 'util/vfio-helpers: Convert vfio_dump_mapping to trace eve= nts'
011/19:[----] [-C] 'util/vfio-helpers: Let qemu_vfio_dma_map() propagate Erro= r'
012/19:[----] [--] 'util/vfio-helpers: Let qemu_vfio_do_mapping() propagate E= rror'
013/19:[----] [--] 'util/vfio-helpers: Let qemu_vfio_verify_mappings() use er= ror_report()'
014/19:[0017] [FC] 'util/vfio-helpers: Pass minimum page size to qemu_vfio_op= en_pci()'
015/19:[----] [-C] 'util/vfio-helpers: Report error when IOMMU page size is n= ot supported'
016/19:[----] [--] 'util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs= ()'
017/19:[----] [--] 'util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq()' 018/19:[----] [-C] 'block/nvme: Switch to using the MSIX API' 019/19:[----] [--] 'util/vfio-helpers: Remove now unused qemu_vfio_pci_init_i= rq()'

Philippe Mathieu-Daud=C3=A9 (19):
block/nvme: Correct minimum device page size
block/nvme: Set request_alignment at initialization block/nvme: Introduce device/iommu 'page_size_min' variables block/nvme: Trace controller capabilities util/vfio-helpers: Improve reporting unsupported IOMMU type util/vfio-helpers: Trace PCI I/O config accesses util/vfio-helpers: Trace PCI BAR region info util/vfio-helpers: Trace where BARs are mapped util/vfio-helpers: Improve DMA trace events util/vfio-helpers: Convert vfio_dump_mapping to trace events util/vfio-helpers: Let qemu_vfio_dma_map() propagate Error util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report() util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci() util/vfio-helpers: Report error when IOMMU page size is not supported util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs() util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq() block/nvme: Switch to using the MSIX API util/vfio-helpers: Remove now unused qemu_vfio_pci_init_irq()

 include/qemu/vfio-helpers.h |  15 ++-
 block/nvme.c                |  58 +++++++++---
 util/vfio-helpers.c         | 183 +++++++++++++++++++++++++++---------
 block/trace-events          |   1 +
 util/trace-events           |  13 ++-
 5 files changed, 208 insertions(+), 62 deletions(-)

--=20
2.26.2