Skip to content

hw/clock: Inline and remove CLOCK_PERIOD_TO_HZ/CLOCK_PERIOD_TO_NS macro

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4qdev-monitor: Display frequencies scaled to SI unitsoftmmu/qdev-monitor.c+5 -31 reply
2/4hw/core/clock: trace clock values in Hz instead of nshw/core/clock.c hw/core/trace-events+7 -50 replies
3/4hw/clock: Inline and remove CLOCK_PERIOD_TO_HZ()include/hw/clock.h+5 -30 replies
4/4hw/clock: Inline and remove CLOCK_PERIOD_TO_NS()include/hw/clock.h+8 -31 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchLuc MichelDamien HeddeAlistair FrancisPhilippe Mathieu-Daudé
1/4R-b R-b R-b
2/4R-b R-b T-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] hw/clock: Inline and remove CLOCK_PERIOD_TO_HZ/CLOCK_PERIOD_TO_NS macro

Following discussion and analysis from Peter:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg05853.html

Last patch is RFC because I doubt using 128-bit is what we want... but I'm not sure how to round it neither.

Future possible cleanup: un-inline these helpers.

Luc Michel (1):
hw/core/clock: trace clock values in Hz instead of ns

Philippe Mathieu-Daudé (3):
qdev-monitor: Display frequencies scaled to SI unit hw/clock: Inline and remove CLOCK_PERIOD_TO_HZ() hw/clock: Inline and remove CLOCK_PERIOD_TO_NS()

 include/hw/clock.h     | 19 +++++++++++++------
 hw/core/clock.c        |  8 +++++---
 softmmu/qdev-monitor.c |  8 +++++---
 hw/core/trace-events   |  4 ++--
 4 files changed, 25 insertions(+), 14 deletions(-)
Signature · 1 line
2.26.2