Skip to content

ide: fix SRST (again)

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ide: run diagnostic after SRSThw/ide/core.c+2 -40 replies
2/3ide: perform SRST as early as possiblehw/ide/core.c+1 -30 replies
3/3ide: clear SRST after SRST finisheshw/ide/core.c+2 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchMark Cave-Ayland
SeriesT-b
1/3T-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] ide: fix SRST (again)

My last fix for SRST wasn't entirely correct and caused a regression; namely we need to mime execution of the diagnostic command. If we don't, Linux bins the IDE device as 'horked'.

For detailed reading on the SRST protocol, I recommend checking out the ATA8-APT specification.

John Snow (3):
ide: run diagnostic after SRST
ide: perform SRST as early as possible
ide: clear SRST after SRST finishes

 hw/ide/core.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
Signature · 1 line
2.26.2