Skip to content

KVM: VMX: Clean up Hyper-V PV TLB flush

Sean Christopherson kvm lkml 2 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 11 repliesApplied
  2. v210 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- Add a patch to pass the root_hpa instead of pgd to vmx_load_mmu_pgd() and retrieve the active PCID only when necessary. [Vitaly]
- Selectively collects reviews (skipped a few due to changes). [Vitaly]
- Explicitly invalidate hv_tlb_eptp instead of leaving it valid when the mismatch tracker "knows" it's invalid. [Vitaly]
- Change the last patch to use "hv_root_ept" instead of "hv_tlb_pgd" to better reflect what is actually being tracked.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/11KVM: x86: Get active PCID only when writing a CR3 valuearch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu.h arch/x86/kvm/svm/svm.c +2 more+12 -142 replies
2/11KVM: VMX: Track common EPTP for Hyper-V's paravirt TLB flusharch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+10 -111 reply
3/11KVM: VMX: Stash kvm_vmx in a local variable for Hyper-V paravirt TLB flusharch/x86/kvm/vmx/vmx.c+7 -60 replies
4/11KVM: VMX: Fold Hyper-V EPTP checking into it's only callerarch/x86/kvm/vmx/vmx.c+20 -241 reply
5/11KVM: VMX: Do Hyper-V TLB flush iff vCPU's EPTP hasn't been flushedarch/x86/kvm/vmx/vmx.c+8 -151 reply
6/11KVM: VMX: Invalidate hv_tlb_eptp to denote an EPTP mismatcharch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+23 -191 reply
7/11KVM: VMX: Don't invalidate hv_tlb_eptp if the new EPTP matchesarch/x86/kvm/vmx/vmx.c+2 -10 replies
8/11KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgdarch/x86/kvm/vmx/vmx.c+16 -70 replies
9/11KVM: VMX: Define Hyper-V paravirt TLB flush fields iff Hyper-V is enabledarch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+8 -11 reply
10/11KVM: VMX: Skip additional Hyper-V TLB EPTP flushes if one failsarch/x86/kvm/vmx/vmx.c+9 -11 reply
11/11KVM: VMX: Track root HPA instead of EPTP for paravirt Hyper-V TLB flusharch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+42 -471 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchVitaly Kuznetsov
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/11] KVM: VMX: Clean up Hyper-V PV TLB flush

Clean up KVM's PV TLB flushing when running with EPT on Hyper-V, i.e. as a nested VMM. No real goal in mind other than the sole patch in v1, which is a minor change to avoid a future mixup when TDX also wants to define .remote_flush_tlb. Everything else is opportunistic clean up.

Patch 1 legitimately tested on VMX (no SVM), everything else effectively build tested only.

v3:
- Add a patch to pass the root_hpa instead of pgd to vmx_load_mmu_pgd() and retrieve the active PCID only when necessary. [Vitaly]
- Selectively collects reviews (skipped a few due to changes). [Vitaly]
- Explicitly invalidate hv_tlb_eptp instead of leaving it valid when the mismatch tracker "knows" it's invalid. [Vitaly]
- Change the last patch to use "hv_root_ept" instead of "hv_tlb_pgd" to better reflect what is actually being tracked.

v2: Rewrite everything.

Sean Christopherson (11):
KVM: x86: Get active PCID only when writing a CR3 value
KVM: VMX: Track common EPTP for Hyper-V's paravirt TLB flush
KVM: VMX: Stash kvm_vmx in a local variable for Hyper-V paravirt TLB
flush
KVM: VMX: Fold Hyper-V EPTP checking into it's only caller
KVM: VMX: Do Hyper-V TLB flush iff vCPU's EPTP hasn't been flushed
KVM: VMX: Invalidate hv_tlb_eptp to denote an EPTP mismatch
KVM: VMX: Don't invalidate hv_tlb_eptp if the new EPTP matches
KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd
KVM: VMX: Define Hyper-V paravirt TLB flush fields iff Hyper-V is
enabled
KVM: VMX: Skip additional Hyper-V TLB EPTP flushes if one fails
KVM: VMX: Track root HPA instead of EPTP for paravirt Hyper-V TLB
flush

 arch/x86/include/asm/kvm_host.h |   4 +-
 arch/x86/kvm/mmu.h              |   2 +-
 arch/x86/kvm/svm/svm.c          |   4 +-
 arch/x86/kvm/vmx/vmx.c          | 134 ++++++++++++++++++--------------
 arch/x86/kvm/vmx/vmx.h          |  19 ++---
 5 files changed, 87 insertions(+), 76 deletions(-)
Signature · 1 line
2.28.0