qga: Fix several guest-get-devices issues
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | qga: Rename guest-get-devices return member 'address' to 'id'qga/ qga/ | +17 | 3 replies | |
| 2/4 | qga: Use common time encoding for guest-get-devices 'driver-date'qga/ qga/ | +13 | 1 reply | |
| 3/4 | qga-win: Fix guest-get-devices error API violationsqga/ | +2 | 2 replies | |
| 4/4 | qga: Flatten simple union GuestDeviceIdqga/ qga/ | +12 | 2 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Marc-André Lureau |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | |
| 3/4 | R-b | R-b |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] qga: Fix several guest-get-devices issues
To be frank, I'm disappointed the code passed review in this state. There are excuses for each of the issues addressed in this series (PATCH 1 naming is hard, PATCH 2 recognizing non-local relations is hard, PATCH 3 mistakes on error paths are easy to miss, PATCH 4 can't expect all reviewers to know "no more simple unions, please"). Still, having so many of them escape notice is disappointing.
Please review.
Markus Armbruster (4):
qga: Rename guest-get-devices return member 'address' to 'id'
qga: Use common time encoding for guest-get-devices 'driver-date'
qga-win: Fix guest-get-devices error API violations
qga: Flatten simple union GuestDeviceId
qga/qapi-schema.json | 29 +++++++++++++++++++---------- qga/commands-win32.c | 39 ++++++++++++++++++++------------------- 2 files changed, 39 insertions(+), 29 deletions(-)
Signature · 1 line
2.26.2