Skip to content

qga: Fix several guest-get-devices issues

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4qga: Rename guest-get-devices return member 'address' to 'id'qga/commands-win32.c qga/qapi-schema.json+17 -163 replies
2/4qga: Use common time encoding for guest-get-devices 'driver-date'qga/commands-win32.c qga/qapi-schema.json+13 -101 reply
3/4qga-win: Fix guest-get-devices error API violationsqga/commands-win32.c+2 -32 replies
4/4qga: Flatten simple union GuestDeviceIdqga/commands-win32.c qga/qapi-schema.json+12 -52 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMarc-André Lureau
1/4R-b R-b
2/4R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] qga: Fix several guest-get-devices issues

To be frank, I'm disappointed the code passed review in this state. There are excuses for each of the issues addressed in this series (PATCH 1 naming is hard, PATCH 2 recognizing non-local relations is hard, PATCH 3 mistakes on error paths are easy to miss, PATCH 4 can't expect all reviewers to know "no more simple unions, please"). Still, having so many of them escape notice is disappointing.

Please review.

Markus Armbruster (4):
qga: Rename guest-get-devices return member 'address' to 'id'
qga: Use common time encoding for guest-get-devices 'driver-date'
qga-win: Fix guest-get-devices error API violations
qga: Flatten simple union GuestDeviceId

 qga/qapi-schema.json | 29 +++++++++++++++++++----------
 qga/commands-win32.c | 39 ++++++++++++++++++++-------------------
 2 files changed, 39 insertions(+), 29 deletions(-)
Signature · 1 line
2.26.2