Skip to content

cxgb4/ch_ktls: Fixes in nic tls code

Rohit Maheshwari netdev 7 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest12 patches 1 replyApplied
  2. v512 patches 0 repliesSuperseded
  3. v410 patches 6 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/21 of 10 patches0 repliesSuperseded
v3 posting 1/210 patches0 repliesSuperseded
v27 patches3 repliesSuperseded
v17 patches2 repliesSuperseded

v1->v2 from the cover letter

- Corrected fixes tag issue.
- Marked chcr_ktls_sw_fallback() static.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/12cxgb4/ch_ktls: decrypted bit is not enoughdrivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h drivers/net/ethernet/chelsio/cxgb4/sge.c +1 more+8 -50 replies
2/12ch_ktls: Correction in finding correct lengthdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+8 -70 replies
3/12ch_ktls: Update cheksum informationdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+11 -40 replies
4/12cxgb4/ch_ktls: creating skbs causes panicdrivers/net/ethernet/chelsio/cxgb4/cxgb4.h drivers/net/ethernet/chelsio/cxgb4/sge.c drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+226 -1690 replies
5/12ch_ktls: Correction in trimmed_len calculationdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+7 -40 replies
6/12ch_ktls: missing handling of header alonedrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+11 -140 replies
7/12ch_ktls: Correction in middle record handlingdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+31 -190 replies
8/12ch_ktls: packet handling prior to start markerdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+33 -50 replies
9/12ch_ktls: don't free skb before sending FINdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+10 -20 replies
10/12ch_ktls/cxgb4: handle partial tag alone SKBsdrivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c +1 more+119 -10 replies
11/12ch_ktls: tcb update fails sometimesdrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+8 -40 replies
12/12ch_ktls: stop the txq if reaches thresholddrivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c+15 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [net v6 00/12] cxgb4/ch_ktls: Fixes in nic tls code

This series helps in fixing multiple nic ktls issues. Series is broken into 12 patches.

Patch 1 avoids deciding tls packet based on decrypted bit. If its a retransmit packet which has tls handshake and finish (for encryption), decrypted bit won't be set there, and so we can't rely on decrypted bit.

Patch 2 helps supporting linear skb. SKBs were assumed non-linear. Corrected the length extraction.

Patch 3 fixes the checksum offload update in WR.

Patch 4 fixes kernel panic happening due to creating new skb for each record. As part of fix driver will use same skb to send out one tls record (partial data) of the same SKB.

Patch 5 fixes the problem of skb data length smaller than remaining data of the record.

Patch 6 fixes the handling of SKBs which has tls header alone pkt, but not starting from beginning.

Patch 7 avoids sending extra data which is used to make a record 16 byte aligned. We don't need to retransmit those extra few bytes.

Patch 8 handles the cases where retransmit packet has tls starting exchanges which are prior to tls start marker.

Patch 9 fixes the problem os skb free before HW knows about tcp FIN.

Patch 10 handles the small packet case which has partial TAG bytes only. HW can't handle those, hence using sw crypto for such pkts.

Patch 11 corrects the potential tcb update problem.

Patch 12 stops the queue if queue reaches threshold value.

v1->v2:
- Corrected fixes tag issue.
- Marked chcr_ktls_sw_fallback() static.

v2->v3:
- Replaced GFP_KERNEL with GFP_ATOMIC.
- Removed mixed fixes.

v3->v4:
- Corrected fixes tag issue.

v4->v5:
- Separated mixed fixes from patch 4.

v5-v6:
- Fixes tag should be at the end.

Rohit Maheshwari (12):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls: Correction in finding correct length
ch_ktls: Update cheksum information
cxgb4/ch_ktls: creating skbs causes panic
ch_ktls: Correction in trimmed_len calculation
ch_ktls: missing handling of header alone
ch_ktls: Correction in middle record handling
ch_ktls: packet handling prior to start marker
ch_ktls: don't free skb before sending FIN
ch_ktls/cxgb4: handle partial tag alone SKBs
ch_ktls: tcb update fails sometimes
ch_ktls: stop the txq if reaches threshold

 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h    |   3 +
 .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c    |   2 +
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |   1 +
 .../net/ethernet/chelsio/cxgb4/cxgb4_uld.h    |   6 +
 drivers/net/ethernet/chelsio/cxgb4/sge.c      | 111 +++-
 .../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 582 +++++++++++-------
 .../chelsio/inline_crypto/ch_ktls/chcr_ktls.h |   1 +
 7 files changed, 478 insertions(+), 228 deletions(-)
Signature · 1 line
2.18.1