Skip to content

rcu/nocb: De-offload and re-offload support v3

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16rcu: Implement rcu_segcblist_is_offloaded() config dependentkernel/rcu/rcu_segcblist.h kernel/rcu/tree.c+8 -150 replies
2/16rcu: Turn enabled/offload states into a common flaginclude/linux/rcu_segcblist.h kernel/rcu/rcu_segcblist.c kernel/rcu/rcu_segcblist.h+28 -70 replies
3/16rcu: Provide basic callback offloading state machine bitsinclude/linux/rcu_segcblist.h kernel/rcu/rcu_segcblist.c kernel/rcu/rcu_segcblist.h +1 more+128 -30 replies
4/16rcu/nocb: Always init segcblist on CPU upkernel/rcu/tree.c+9 -30 replies
5/16rcu: De-offloading CB kthreadinclude/linux/rcupdate.h kernel/rcu/rcu_segcblist.c kernel/rcu/rcu_segcblist.h +2 more+126 -234 replies
6/16rcu/nocb: Don't deoffload an offline CPU with pending workkernel/rcu/tree_plugin.h+8 -00 replies
7/16rcu: De-offloading GP kthreadkernel/rcu/tree_plugin.h+51 -30 replies
8/16rcu: Re-offload supportinclude/linux/rcupdate.h kernel/rcu/tree_plugin.h+138 -210 replies
9/16rcu: Shutdown nocb timer on de-offloadingkernel/rcu/tree.h kernel/rcu/tree_plugin.h+12 -10 replies
10/16rcu: Flush bypass before setting SEGCBLIST_SOFTIRQ_ONLYkernel/rcu/tree_plugin.h+9 -20 replies
11/16rcu: Set SEGCBLIST_SOFTIRQ_ONLY at the very last stage of de-offloadingkernel/rcu/tree_plugin.h+8 -10 replies
12/16rcu/nocb: Only cond_resched() from actual offloaded batch processingkernel/rcu/tree.c+1 -20 replies
13/16rcu: Process batch locally as long as offloading isn't completekernel/rcu/rcu_segcblist.h kernel/rcu/tree.c+14 -10 replies
14/16rcu: Locally accelerate callbacks as long as offloading isn't completekernel/rcu/tree.c+3 -40 replies
15/16rcutorture: Test runtime toggling of CPUs' callback offloadingDocumentation/admin-guide/kernel-parameters.txt kernel/rcu/rcutorture.c kernel/rcu/tree_plugin.h+93 -40 replies
16/16tools/rcutorture: Support nocb toggle in TREE01tools/testing/selftests/rcutorture/configs/rcu/TREE01.boot+3 -10 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by.

PatchPaul E. McKenney
1/16
2/16Inspired-by
3/16Inspired-by
4/16Inspired-by
5/16Inspired-by
6/16
7/16Inspired-by
8/16Inspired-by
9/16Inspired-by
10/16Inspired-by
11/16Inspired-by
12/16Inspired-by
13/16Inspired-by
14/16Inspired-by
15/16
16/16Inspired-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] rcu/nocb: De-offload and re-offload support v3

Hi,

This is the third attempt to make rcu-nocb mutable at runtime. See v2 there: https://lwn.net/Articles/832031/

Many fixes included and rcutorture support:

03: Whitespace fix
04: Add "rcu/nocb: Always init segcblist on CPU up" (Thanks rcutorture!)
05: Add return value for failure on (de)offloading
06: Add "rcu/nocb: Don't deoffload an offline CPU with pending work" (Thanks Paul!) 12: Add "rcu/nocb: Only cond_resched() from actual offloaded batch processing" (Thanks rcutorture!) 14: Write a real and more self-confident changelog
15/16: Add rcutorture support (thanks Paul!)

My last remaining worry, as exposed in 13/16, is that __call_rcu_core() isn't called during transition states. I need to see how I can handle that.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
rcu/nocb-toggle-v2

HEAD: 0247cd09fd48a38741e5cc6634810985b405baca

Thanks,
Frederic
---

Frederic Weisbecker (15):
rcu: Implement rcu_segcblist_is_offloaded() config dependent
rcu: Turn enabled/offload states into a common flag
rcu: Provide basic callback offloading state machine bits rcu/nocb: Always init segcblist on CPU up
rcu: De-offloading CB kthread
rcu/nocb: Don't deoffload an offline CPU with pending work
rcu: De-offloading GP kthread
rcu: Re-offload support
rcu: Shutdown nocb timer on de-offloading
rcu: Flush bypass before setting SEGCBLIST_SOFTIRQ_ONLY
rcu: Set SEGCBLIST_SOFTIRQ_ONLY at the very last stage of de-offloading rcu/nocb: Only cond_resched() from actual offloaded batch processing
rcu: Process batch locally as long as offloading isn't complete
rcu: Locally accelerate callbacks as long as offloading isn't complete tools/rcutorture: Support nocb toggle in TREE01

Paul E. McKenney (1):
rcutorture: Test runtime toggling of CPUs' callback offloading

 Documentation/admin-guide/kernel-parameters.txt    |   8 +
 include/linux/rcu_segcblist.h                      | 119 +++++++-
 include/linux/rcupdate.h                           |   4 +
 kernel/rcu/rcu_segcblist.c                         |  13 +-
 kernel/rcu/rcu_segcblist.h                         |  45 ++-
 kernel/rcu/rcutorture.c                            |  86 +++++-
 kernel/rcu/tree.c                                  |  47 +--
 kernel/rcu/tree.h                                  |   2 +
 kernel/rcu/tree_plugin.h                           | 330 +++++++++++++++++++--
 .../selftests/rcutorture/configs/rcu/TREE01.boot   |   4 +-
 10 files changed, 603 insertions(+), 55 deletions(-)