Skip to content

USB: serial: keyspan_pda: fix up write implementation

Johan Hovold linux-arm-kernel linux-usb lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14USB: serial: keyspan_pda: fix dropped unthrottle interruptsdrivers/usb/serial/keyspan_pda.c+2 -20 replies
2/14USB: serial: keyspan_pda: fix write deadlockdrivers/usb/serial/keyspan_pda.c+4 -30 replies
3/14USB: serial: keyspan_pda: fix stalled writesdrivers/usb/serial/keyspan_pda.c+1 -10 replies
4/14USB: serial: keyspan_pda: fix write-wakeup use-after-freedrivers/usb/serial/keyspan_pda.c+3 -140 replies
5/14USB: serial: keyspan_pda: fix tx-unthrottle use-after-freedrivers/usb/serial/keyspan_pda.c+4 -00 replies
6/14USB: serial: keyspan_pda: fix write unthrottlingdrivers/usb/serial/keyspan_pda.c+20 -90 replies
7/14USB: serial: keyspan_pda: refactor write-room handlingdrivers/usb/serial/keyspan_pda.c+50 -630 replies
8/14USB: serial: keyspan_pda: fix write implementationdrivers/usb/serial/keyspan_pda.c+51 -580 replies
9/14USB: serial: keyspan_pda: increase transmitter thresholddrivers/usb/serial/keyspan_pda.c+1 -10 replies
10/14USB: serial: keyspan_pda: add write-fifo supportdrivers/usb/serial/keyspan_pda.c+55 -600 replies
11/14USB: serial: keyspan_pda: clean up xircom/entrega supportdrivers/usb/serial/Kconfig drivers/usb/serial/Makefile drivers/usb/serial/keyspan_pda.c+13 -753 replies
12/14USB: serial: keyspan_pda: clean up comments and whitespacedrivers/usb/serial/keyspan_pda.c+56 -600 replies
13/14USB: serial: keyspan_pda: use BIT() macrodrivers/usb/serial/keyspan_pda.c+13 -120 replies
14/14USB: serial: keyspan_pda: drop redundant usb-serial pointerdrivers/usb/serial/keyspan_pda.c+2 -30 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSebastian Andrzej SiewiorGreg Kroah-Hartman
SeriesA-b R-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] USB: serial: keyspan_pda: fix up write implementation

This series fixes a number of long-standing issues with the keyspan_pda driver and reworks its write implementation so that it can be used with any line discipline or for a system console.

The last few patches cleans up the xircom device support and some style issues.

Johan

Johan Hovold (14):
USB: serial: keyspan_pda: fix dropped unthrottle interrupts
USB: serial: keyspan_pda: fix write deadlock
USB: serial: keyspan_pda: fix stalled writes
USB: serial: keyspan_pda: fix write-wakeup use-after-free
USB: serial: keyspan_pda: fix tx-unthrottle use-after-free
USB: serial: keyspan_pda: fix write unthrottling
USB: serial: keyspan_pda: refactor write-room handling
USB: serial: keyspan_pda: fix write implementation
USB: serial: keyspan_pda: increase transmitter threshold
USB: serial: keyspan_pda: add write-fifo support
USB: serial: keyspan_pda: clean up xircom/entrega support
USB: serial: keyspan_pda: clean up comments and whitespace
USB: serial: keyspan_pda: use BIT() macro
USB: serial: keyspan_pda: drop redundant usb-serial pointer

 drivers/usb/serial/Kconfig       |  19 +-
 drivers/usb/serial/Makefile      |   1 -
 drivers/usb/serial/keyspan_pda.c | 548 +++++++++++++------------------
 3 files changed, 241 insertions(+), 327 deletions(-)
Signature · 1 line
2.26.2