Skip to content

trailer fixes

Anders Waldenborg git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21trailer: change token_{from,matches}_item into taking conf_infotrailer.c+11 -111 reply
2/21trailer: don't use 'struct arg_item' for storing configtrailer.c+17 -140 replies
3/21doc: mention canonicalization in git i-t manualDocumentation/git-interpret-trailers.txt+5 -01 reply
4/21pretty: allow using aliases in %(trailer:key=xyz)Documentation/pretty-formats.txt pretty.c t/t4205-log-pretty-formats.sh +2 more+19 -51 reply
5/21trailer: rename 'free_all' to 'free_all_trailer_items'trailer.c+2 -22 replies
6/21t4205: add test for trailer in log with nonstandard separatort/t4205-log-pretty-formats.sh+12 -04 replies
7/21trailer: simplify 'arg_item' lifetimetrailer.c+16 -160 replies
8/21trailer: keep track of conf in trailer_itemtrailer.c+10 -41 reply
9/21trailer: refactor print_tok_val into taking itemtrailer.c+7 -70 replies
10/21trailer: move trailer token canonicalization print timetrailer.c+17 -250 replies
11/21trailer: remember separator used in inputtrailer.c+25 -120 replies
12/21trailer: handle configured nondefault separators explicitlytrailer.c+39 -201 reply
13/21trailer: add option to make canonicalization optionalDocumentation/git-interpret-trailers.txt builtin/interpret-trailers.c t/t7513-interpret-trailers.sh +2 more+67 -41 reply
14/21trailer: move skipping of blank lines to own loop when finding trailertrailer.c+6 -40 replies
15/21trailer: factor out classify_trailer_linetrailer.c+74 -490 replies
16/21t7513: add failing test for configured trailing line classificationt/t7513-interpret-trailers.sh+29 -00 replies
17/21trailer: don't treat line with prefix of known trailer as knownt/t7513-interpret-trailers.sh trailer.c+19 -161 reply
18/21trailer: factor out config lookup to separate functiontrailer.c+15 -130 replies
19/21trailer: move config lookup out of parse_trailertrailer.c+8 -90 replies
20/21trailer: add failing tests for matching trailers against inputt/t7513-interpret-trailers.sh+35 -00 replies
21/21trailer: only do prefix matching for configured trailers on commandlinet/t7513-interpret-trailers.sh trailer.c+22 -90 replies

Reviews trailers per patch

None of the 21 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian Couder
SeriesR-b
1/21
2/21
3/21
4/21
5/21
6/21
7/21
8/21
9/21
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/21] trailer fixes

This patch series contains a bunch fo trailer related changes. Sparked from this thread:
https://public-inbox.org/git/[email protected]/T/#r3dc3e4fa67b6fba95e4b2ea2c1cf1672af55a9ee

Most commits are refactors preparing for the others, the actual user visible changes are:
* Allow using aliases in pretty formatting '%(trailer:key=foo)`
* Fixes related to matching prefix rather than full trailer
* Tighten up "canonicalization" of trailers
* Add --(no-)canonicalize

Anders Waldenborg (21):
trailer: change token_{from,matches}_item into taking conf_info
trailer: don't use 'struct arg_item' for storing config
doc: mention canonicalization in git i-t manual
pretty: allow using aliases in %(trailer:key=xyz)
trailer: rename 'free_all' to 'free_all_trailer_items'
t4205: add test for trailer in log with nonstandard separator
trailer: simplify 'arg_item' lifetime
trailer: keep track of conf in trailer_item
trailer: refactor print_tok_val into taking item
trailer: move trailer token canonicalization print time
trailer: remember separator used in input
trailer: handle configured nondefault separators explicitly
trailer: add option to make canonicalization optional
trailer: move skipping of blank lines to own loop when finding trailer
trailer: factor out classify_trailer_line
t7513: add failing test for configured trailing line classification
trailer: don't treat line with prefix of known trailer as known
trailer: factor out config lookup to separate function
trailer: move config lookup out of parse_trailer
trailer: add failing tests for matching trailers against input
trailer: only do prefix matching for configured trailers on
commandline

 Documentation/git-interpret-trailers.txt |  10 +-
 Documentation/pretty-formats.txt         |   4 +-
 builtin/interpret-trailers.c             |   3 +
 pretty.c                                 |   5 +-
 t/t4205-log-pretty-formats.sh            |  18 ++
 t/t7513-interpret-trailers.sh            | 120 ++++++++
 trailer.c                                | 374 ++++++++++++++---------
 trailer.h                                |   3 +-
 8 files changed, 386 insertions(+), 151 deletions(-)
Signature · 1 line
2.25.1