mtd: pxa3xx_nand: add support for Armada 8k
Get series with b4
b4 am 20201026103649.39ff097c@xps13Versions newest first
- v2 Latest0 of 5 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/5] mtd: pxa3xx_nand: add support for Armada 8k
Hi Stefan,
Stefan Roese <[email protected]> wrote on Tue, 20 Oct 2020 10:29:52 +0200:
Quoted 27 lines
Hi Baruch,
Hi Chris,Quoted 17 lines · Baruch Siach
Hi Chris,
Quoted 5 lines · Chris Packham
Quoted 4 lines · Baruch Siach
This series adds NAND flash support to Aramda 8k systems. Patches make the necessary changes to the
pxa3xx_nanddriver and DT files.Quoted 8 lines
Quoted 3 lines
v2:
Rebase on current master. Fixes conflict with commit661c98121d4("mtd: nand:
pxa3xx: Fix not callingdev_xxxwith a device")Is it worth looking at bringing in the newer
marvell_nanddriver from Linux? I suspect that it will be easier to keep in sync with changes for the Armada 8K. I have considered it in the past but it kind of fell off my radar.Quoted 5 lines
The kernel raw nand API has seen some significant changes recently. It looks like the kernel
marvell_nanddriver relies on newer API. I'm not sure how easy would be syncing the drivers to a degree that makes porting of changes trivial. It would probably require many other changes in generic U-Boot raw NAND code.
Quoted 10 lines
I agree that without a re-sync with a more recent Linux MTD (NAND) core code, this task might prove complex and failure prone. And sync'ing the MTD core is also a pretty complex task which needs to be done very carefully, to not break any existing platforms. FWICT, nobody is working on it right now and we can't wait for this to happen and stall the development here. So from my point of view, I'm okay with updates to the current PXA NAND driver. Testing of these patches on other platforms would be very welcome though.
Quoted 1 line
Maybe Miquel can shed some light on that.
Yes, the "new" marvell_nand.c driver is using the ->exec_op() interface which is the one that must be ported to U-Boot. Many changes have been brought to the raw NAND core but everything has been carefully patched to be easily ported (besides the huge number of potential dependencies that have not been brought to U-Boot already). Bringing-in this new interface does not affect the other controller drivers though, as the ->cmdfunc() and ->cmd_ctrl() interfaces are still functional.
Thanks,
Miqu?l