gpio: exar: refactor the driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 8 repliesIn review
- v47 patches 10 repliesSuperseded
- v3 posting 2/27 patches 11 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 1/2 | 0 of 7 patches | 1 reply | Superseded | |
| v2 | 8 patches | 6 replies | Superseded | |
| v1 | 1 patch | 4 replies | Superseded |
Changes in v5 from the cover letter
- set the reg_bits to 11 in regmap config
- collect review tags from Andy
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | gpio: exar: add a newline after the copyright noticedrivers/ | +1 | 0 replies | |
| 2/7 | gpio: exar: include idr.hdrivers/ | +1 | 0 replies | |
| 3/7 | gpio: exar: switch to a simpler IDA interfacedrivers/ | +3 | 0 replies | |
| 4/7 | gpio: exar: use a helper variable for &pdev->devdrivers/ | +7 | 0 replies | |
| 5/7 | gpio: exar: unduplicate address and offset computationdrivers/ | +28 | 0 replies | |
| 6/7 | gpio: exar: switch to using regmapdrivers/ drivers/ | +43 | 0 replies | |
| 7/7 | gpio: exar: use devm action for freeing the IDA and drop remove()drivers/ | +12 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/7] gpio: exar: refactor the driver
From: Bartosz Golaszewski <[email protected]>
I just wanted to convert the driver to using simpler IDA API but ended up quickly converting it to using regmap. Unfortunately I don't have the HW to test it so marking the patches that introduce functional change as RFT and Cc'ing the original author.
v1 -> v2:
- add new regmap helper: regmap_assign_bits()
- fix lvl vs sel register access
- set value in direction_output callback
v2 -> v3:
- drop the regmap helper from series
v3 -> v4:
- renamed the regmap variable to 'regmap' as leaving the old name caused me to miss an assignment leading to a crash (culprit spotted by Andy Shevchenko)
v4 -> v5:
- set the reg_bits to 11 in regmap config
- collect review tags from Andy
Bartosz Golaszewski (7):
gpio: exar: add a newline after the copyright notice
gpio: exar: include idr.h
gpio: exar: switch to a simpler IDA interface
gpio: exar: use a helper variable for &pdev->dev
gpio: exar: unduplicate address and offset computation
gpio: exar: switch to using regmap
gpio: exar: use devm action for freeing the IDA and drop remove()
drivers/gpio/Kconfig | 1 + drivers/gpio/gpio-exar.c | 160 ++++++++++++++++++++------------------- 2 files changed, 82 insertions(+), 79 deletions(-)
Signature · 1 line
2.29.1