Skip to content

crypto: testmgr - always print the actual driver name

Eric Biggers linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4crypto: aead - add crypto_aead_driver_name()include/crypto/aead.h+5 -00 replies
2/4crypto: testmgr - always print the actual hash driver namecrypto/testmgr.c+20 -230 replies
3/4crypto: testmgr - always print the actual AEAD driver namecrypto/testmgr.c+18 -240 replies
4/4crypto: testmgr - always print the actual skcipher driver namecrypto/testmgr.c+16 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] crypto: testmgr - always print the actual driver name

When alg_test() is called from tcrypt.ko rather than from the algorithm registration code, "driver" is actually the algorithm name, not the driver name. So it shouldn't be used in places where a driver name is wanted, e.g. when reporting a test failure or when checking whether the driver is the generic driver or not.

See https://lkml.kernel.org/r/20200910122248.GA22506@Red for an example where this caused a problem. The self-tests reported "alg: ahash: md5 test failed", but it wasn't mentioned which md5 implementation it was.

Fix this by getting the driver name from the crypto tfm object that actually got allocated.

Eric Biggers (4):
crypto: aead - add crypto_aead_driver_name()
crypto: testmgr - always print the actual hash driver name
crypto: testmgr - always print the actual AEAD driver name
crypto: testmgr - always print the actual skcipher driver name

 crypto/testmgr.c      | 121 +++++++++++++++++++-----------------------
 include/crypto/aead.h |   5 ++
 2 files changed, 59 insertions(+), 67 deletions(-)

base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec

Signature · 1 line
2.29.1