Skip to content

block/nvme: Fix Aarch64 or big-endian hosts

Philippe Mathieu-Daudé qemu-devel 2 versions – Applied

Status from this message: Thanks, applied the 5.2 patches to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest25 patches 8 repliesApplied
  2. v125 patches 57 repliesSuperseded

Changes in v2 from the cover letter

- addressed Stefan and Eric review comments
- dropped unnecessary patches
- added BE fix reported by Keith

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/25MAINTAINERS: Cover 'block/nvme.h' fileMAINTAINERS+2 -00 replies
2/25block/nvme: Use hex format to display offset in trace eventsblock/trace-events+6 -60 replies
3/25block/nvme: Report warning with warn_report()block/nvme.c+2 -20 replies
4/25block/nvme: Trace controller capabilitiesblock/nvme.c block/trace-events+15 -00 replies
5/25block/nvme: Trace nvme_poll_queue() per queueblock/nvme.c block/trace-events+2 -20 replies
6/25block/nvme: Improve nvme_free_req_queue_wait() trace informationblock/nvme.c block/trace-events+2 -20 replies
7/25block/nvme: Trace queue pair creation/deletionblock/nvme.c block/trace-events+5 -00 replies
8/25block/nvme: Move definitions before structure declarationsblock/nvme.c+10 -90 replies
9/25block/nvme: Use unsigned integer for queue counter/sizeblock/nvme.c block/trace-events+23 -250 replies
10/25block/nvme: Make nvme_identify() return boolean indicating errorblock/nvme.c+7 -51 reply
11/25block/nvme: Make nvme_init_queue() return boolean indicating errorblock/nvme.c+7 -90 replies
12/25block/nvme: Introduce Completion Queue definitionsinclude/block/nvme.h+12 -62 replies
13/25block/nvme: Use definitions instead of magic values in add_io_queue()block/nvme.c+5 -40 replies
14/25block/nvme: Correctly initialize Admin Queue Attributesblock/nvme.c+3 -30 replies
15/25block/nvme: Simplify ADMIN queue accessblock/nvme.c+6 -60 replies
16/25block/nvme: Simplify nvme_cmd_sync()block/nvme.c+10 -91 reply
17/25block/nvme: Set request_alignment at initializationblock/nvme.c+1 -00 replies
18/25block/nvme: Correct minimum device page sizeblock/nvme.c+1 -10 replies
19/25block/nvme: Change size and alignment of IDENTIFY response bufferblock/nvme.c+5 -40 replies
20/25block/nvme: Change size and alignment of queueblock/nvme.c+2 -20 replies
21/25block/nvme: Change size and alignment of prp_list_pagesblock/nvme.c+6 -50 replies
22/25block/nvme: Align iov's va and size on host page sizeblock/nvme.c+8 -60 replies
23/25block/nvme: Fix use of write-only doorbells page on Aarch64 archblock/nvme.c+7 -40 replies
24/25block/nvme: Fix nvme_submit_command() on big-endian hostblock/nvme.c+1 -11 reply
25/25block/nvme: Simplify Completion Queue Command Identifier field useblock/nvme.c+3 -32 replies

Reviews trailers per patch

24 of 25 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziEric AugerKlaus JensenPhilippe Mathieu-Daudé
1/25R-b T-b R-b
2/25R-b R-b T-b
3/25R-b R-b T-b
4/25R-b R-b T-b
5/25R-b R-b T-b
6/25R-b R-b T-b
7/25R-b R-b T-b
8/25R-b R-b T-b
9/25R-b R-b T-b
10/25R-b T-b
11/25R-b T-b
12/25R-b R-b T-b
13/25R-b R-b T-b
14/25R-b R-b T-b
15/25R-b R-b T-b
16/25R-b R-b T-b
17/25R-b R-b T-b
18/25R-b R-b T-b
19/25R-b T-b R-b
20/25R-b T-b
21/25R-b T-b R-b
22/25R-b T-b R-b
23/25R-b R-b T-b
24/25R-b
25/25

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH-for-5.2 v2 00/25] block/nvme: Fix Aarch64 or big-endian hosts

Add a bit of tracing, clean around to finally fix few bugs. In particular, restore NVMe on Aarch64 host.

Since v1:
- addressed Stefan and Eric review comments
- dropped unnecessary patches
- added BE fix reported by Keith

Patches missing review: #10, #24, #25

Supersedes: <[email protected]>

Eric Auger (4):
block/nvme: Change size and alignment of IDENTIFY response buffer block/nvme: Change size and alignment of queue block/nvme: Change size and alignment of prp_list_pages block/nvme: Align iov's va and size on host page size

Philippe Mathieu-Daudé (21):
MAINTAINERS: Cover 'block/nvme.h' file
block/nvme: Use hex format to display offset in trace events block/nvme: Report warning with warn_report()
block/nvme: Trace controller capabilities
block/nvme: Trace nvme_poll_queue() per queue
block/nvme: Improve nvme_free_req_queue_wait() trace information block/nvme: Trace queue pair creation/deletion
block/nvme: Move definitions before structure declarations block/nvme: Use unsigned integer for queue counter/size block/nvme: Make nvme_identify() return boolean indicating error block/nvme: Make nvme_init_queue() return boolean indicating error block/nvme: Introduce Completion Queue definitions block/nvme: Use definitions instead of magic values in add_io_queue() block/nvme: Correctly initialize Admin Queue Attributes block/nvme: Simplify ADMIN queue access
block/nvme: Simplify nvme_cmd_sync()
block/nvme: Set request_alignment at initialization block/nvme: Correct minimum device page size
block/nvme: Fix use of write-only doorbells page on Aarch64 arch block/nvme: Fix nvme_submit_command() on big-endian host block/nvme: Simplify Completion Queue Command Identifier field use

 include/block/nvme.h |  18 ++--
 block/nvme.c         | 213 ++++++++++++++++++++++++-------------------
 MAINTAINERS          |   2 +
 block/trace-events   |  30 +++---
 4 files changed, 150 insertions(+), 113 deletions(-)
Signature · 1 line
2.26.2