Skip to content

block/export: vhost-user-blk server cleanups and tests

Stefan Hajnoczi qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12libvhost-user: follow QEMU comment stylecontrib/libvhost-user/libvhost-user.h+10 -50 replies
2/12configure: introduce --enable-vhost-user-blk-serverblock/export/export.c block/export/meson.build configure +1 more+19 -40 replies
3/12block/export: make vhost-user-blk config space little-endianblock/export/vhost-user-blk-server.c+12 -130 replies
4/12block/export: fix vhost-user-blk get_config() information leakblock/export/vhost-user-blk-server.c+3 -00 replies
5/12contrib/vhost-user-blk: fix get_config() information leakcontrib/vhost-user-blk/vhost-user-blk.c+2 -00 replies
6/12test: new qTest case to test the vhost-user-blk-servertests/qtest/libqos/libqtest.h tests/qtest/libqos/meson.build tests/qtest/libqos/vhost-user-blk.c +4 more+982 -20 replies
7/12tests/qtest: add multi-queue test case to vhost-user-blk-testtests/qtest/vhost-user-blk-test.c+76 -50 replies
8/12libqtest: add qtest_socket_server()tests/qtest/libqos/libqtest.h tests/qtest/libqtest.c+31 -170 replies
9/12vhost-user-blk-test: rename destroy_drive() to destroy_file()tests/qtest/vhost-user-blk-test.c+5 -40 replies
10/12vhost-user-blk-test: close fork child file descriptorstests/qtest/vhost-user-blk-test.c+11 -00 replies
11/12vhost-user-blk-test: drop unused return valuetests/qtest/vhost-user-blk-test.c+2 -30 replies
12/12vhost-user-blk-test: fix races by using fd passingtests/qtest/vhost-user-blk-test.c+26 -160 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchStefan HajnocziMarc-André Lureau
1/12
2/12
3/12
4/12
5/12
6/12R-b R-b
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests

This patch series solves some issues with the new vhost-user-blk-server and adds the qtest test case. The test case was not included in the pull request that introduced the vhost-user-blk server because of reliability issues that are fixed in this patch series.

Coiby Xu (1):
test: new qTest case to test the vhost-user-blk-server

Stefan Hajnoczi (11):
libvhost-user: follow QEMU comment style
configure: introduce --enable-vhost-user-blk-server block/export: make vhost-user-blk config space little-endian block/export: fix vhost-user-blk get_config() information leak contrib/vhost-user-blk: fix get_config() information leak tests/qtest: add multi-queue test case to vhost-user-blk-test
libqtest: add qtest_socket_server()
vhost-user-blk-test: rename destroy_drive() to destroy_file()
vhost-user-blk-test: close fork child file descriptors
vhost-user-blk-test: drop unused return value
vhost-user-blk-test: fix races by using fd passing

 configure                               |  15 +
 contrib/libvhost-user/libvhost-user.h   |  15 +-
 tests/qtest/libqos/libqtest.h           |  25 +
 tests/qtest/libqos/vhost-user-blk.h     |  48 ++
 block/export/export.c                   |   4 +-
 block/export/vhost-user-blk-server.c    |  28 +-
 contrib/vhost-user-blk/vhost-user-blk.c |   2 +
 tests/qtest/libqos/vhost-user-blk.c     | 129 ++++
 tests/qtest/libqtest.c                  |  76 ++-
 tests/qtest/vhost-user-blk-test.c       | 843 ++++++++++++++++++++++++
 block/export/meson.build                |   2 +-
 tests/qtest/libqos/meson.build          |   1 +
 tests/qtest/meson.build                 |   2 +
 util/meson.build                        |   2 +-
 14 files changed, 1151 insertions(+), 41 deletions(-)
 create mode 100644 tests/qtest/libqos/vhost-user-blk.h
 create mode 100644 tests/qtest/libqos/vhost-user-blk.c
 create mode 100644 tests/qtest/vhost-user-blk-test.c
Signature · 1 line
2.26.2