Skip to content

net: hdlc_fr: Improve fr_rx and add support for any Ethertype

Xie He lkml netdev 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest5 patches 3 repliesIn review
  2. v65 patches 8 repliesSuperseded
  3. v55 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches17 repliesSuperseded
v34 patches4 repliesSuperseded
v24 patches5 repliesSuperseded
v14 patches0 repliesSuperseded

Changes in v7 from the cover letter

Remove the explanation about why only a 2-byte address field is accepted because I think it is inadequate and unnecessary.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop framesdrivers/net/wan/hdlc_fr.c+6 -90 replies
2/5net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleanerdrivers/net/wan/hdlc_fr.c+20 -170 replies
3/5net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devicesdrivers/net/wan/hdlc_fr.c+3 -00 replies
4/5net: hdlc_fr: Improve the initial checks when we receive an skbdrivers/net/wan/hdlc_fr.c+1 -10 replies
5/5net: hdlc_fr: Add support for any Ethertypedrivers/net/wan/hdlc_fr.c+49 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

The main purpose of this series is the last patch. The previous 4 patches are just code clean-ups so that the last patch will not make the code too messy. The patches must be applied in sequence.

The receiving code of this driver doesn't support arbitrary Ethertype values. It only recognizes a few known Ethertypes when receiving and drops skbs with other Ethertypes.

However, the standard document RFC 2427 allows Frame Relay to support any Ethertype values. This series adds support for this.

Change from v6:
Remove the explanation about why only a 2-byte address field is accepted because I think it is inadequate and unnecessary.

Change from v5:
Small fix to the commit messages.

Change from v4:
Drop the change related to the stats.rx_dropped count. Improve the commit message by stating why only a 2-byte address field is accepted.

Change from v3:
Split the last patch into 2 patches.
Improve the commit message about the stats.rx_dropped count.

Change from v2:
Small fix to the commit messages.

Change from v1:
Small fix to the commit messages.

Xie He (5):
net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames
net: hdlc_fr: Change the use of "dev" in fr_rx to make the code
cleaner
net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC
devices
net: hdlc_fr: Improve the initial checks when we receive an skb
net: hdlc_fr: Add support for any Ethertype

 drivers/net/wan/hdlc_fr.c | 118 +++++++++++++++++++++++---------------
 1 file changed, 72 insertions(+), 46 deletions(-)
Signature · 1 line
2.27.0