Skip to content

RFC mwifiex: add fw reset quirks for Microsoft Surface

Tsuchiya Yuto linux-wireless lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mwifiex: pcie: add DMI-based quirk impl for Surface devicesdrivers/net/wireless/marvell/mwifiex/Makefile drivers/net/wireless/marvell/mwifiex/pcie.c drivers/net/wireless/marvell/mwifiex/pcie.h +2 more+132 -01 reply
2/3mwifiex: pcie: add reset_d3cold quirk for Surface gen4+ devicesdrivers/net/wireless/marvell/mwifiex/pcie.c drivers/net/wireless/marvell/mwifiex/pcie_quirks.c drivers/net/wireless/marvell/mwifiex/pcie_quirks.h+74 -90 replies
3/3mwifiex: pcie: add reset_wsid quirk for Surface 3drivers/net/wireless/marvell/mwifiex/pcie.c drivers/net/wireless/marvell/mwifiex/pcie_quirks.c drivers/net/wireless/marvell/mwifiex/pcie_quirks.h+91 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] mwifiex: add fw reset quirks for Microsoft Surface

Hello all,

This series adds firmware reset quirks for Microsoft Surface devices (PCIe-88W8897). Surface devices somehow requires quirks to reset the firmware. Otherwise, current mwifiex driver can reset only software level. This is not enough to recover from a bad state.

To do so, in the first patch, I added a DMI-based quirk implementation for Surface devices that use mwifiex chip.

The required quirk is different by generation. Surface gen3 devices (Surface 3 and Surface Pro 3) require a quirk that calls _DSM method (the third patch).
Note that Surface Pro 3 is not yet supported because of the difference between Surface 3. On Surface 3, the wifi card will be immediately removed/reprobed after the _DSM call. On the other hand, Surface Pro 3 doesn't. Need to remove/reprobe wifi card ourselves. This behavior makes the support difficult.

Surface gen4+ devices (Surface Pro 4 and later) require a quirk that puts wifi into D3cold before FLR.

While here, created new files for quirks (mwifiex/pcie_quirks.c and mwifiex/pcie_quirks.h) because the changes are a little bit too big to add into pcie.c.

Thanks,
Tsuchiya Yuto

Tsuchiya Yuto (3):
mwifiex: pcie: add DMI-based quirk impl for Surface devices
mwifiex: pcie: add reset_d3cold quirk for Surface gen4+ devices
mwifiex: pcie: add reset_wsid quirk for Surface 3

 drivers/net/wireless/marvell/mwifiex/Makefile |   1 +
 drivers/net/wireless/marvell/mwifiex/pcie.c   |  21 ++
 drivers/net/wireless/marvell/mwifiex/pcie.h   |   2 +
 .../wireless/marvell/mwifiex/pcie_quirks.c    | 246 ++++++++++++++++++
 .../wireless/marvell/mwifiex/pcie_quirks.h    |  17 ++
 5 files changed, 287 insertions(+)
 create mode 100644 drivers/net/wireless/marvell/mwifiex/pcie_quirks.c
 create mode 100644 drivers/net/wireless/marvell/mwifiex/pcie_quirks.h
Signature · 1 line
2.29.1