Skip to content

powernv/memtrace: don't abuse memory hot(un)plug infrastructure for memory allocations

David Hildenbrand linux-mm linuxppc-dev lkml stable 2 versions – Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 11 repliesApplied
  2. v14 patches 13 repliesApplied

Changes in v2 from the cover letter

- Tweaks to patch descriptions
- "powernv/memtrace: don't leak kernel memory to user space"
-- Added. Reported by Michael.
- "powernv/memtrace: fix crashing the kernel when enabling concurrently" -- Added, discovered while testing.
- "powerpc/mm: protect linear mapping modifications by a mutex" -- Added. Although we currently won't have concurrency, this is cleaner and future-proof.
- "powerepc/book3s64/hash: drop WARN_ON in hash__remove_section_mapping" -- Added. Suggested by Oscar
- "powernv/memtrace: don't abuse memory hot(un)plug infrastructure for memory allocations"
-- Reshuffle the code to make review easier.
-- Add a TODO regarding __GFP_ZERO. Adapt to changed page clearing code. -- Use GFP_KERNEL | __GFP_THISNODE | __GFP_NOWARN for allocations.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/8powernv/memtrace: don't leak kernel memory to user spacearch/powerpc/platforms/powernv/memtrace.c+22 -01 reply
2/8powernv/memtrace: fix crashing the kernel when enabling concurrentlyarch/powerpc/platforms/powernv/memtrace.c+15 -71 reply
3/8powerpc/mm: factor out creating/removing linear mappingarch/powerpc/mm/mem.c include/linux/memory_hotplug.h+31 -131 reply
4/8powerpc/mm: protect linear mapping modifications by a mutexarch/powerpc/mm/mem.c+5 -02 replies
5/8powerpc/mm: print warning in arch_remove_linear_mapping()arch/powerpc/mm/mem.c+3 -10 replies
6/8powerepc/book3s64/hash: drop WARN_ON in hash__remove_section_mappingarch/powerpc/mm/book3s64/hash_utils.c+0 -11 reply
7/8powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()arch/powerpc/mm/mem.c+4 -13 replies
8/8powernv/memtrace: don't abuse memory hot(un)plug infrastructure for memory allocationsarch/powerpc/platforms/powernv/Kconfig arch/powerpc/platforms/powernv/memtrace.c+62 -1091 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchOscar Salvador
1/8R-b
2/8R-b
3/8R-b
4/8
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] powernv/memtrace: don't abuse memory hot(un)plug infrastructure for memory allocations

Based on latest linux/master

powernv/memtrace is the only in-kernel user that rips out random memory it never added (doesn't own) in order to allocate memory without a linear mapping. Let's stop abusing memory hot(un)plug infrastructure for that - use alloc_contig_pages() for allocating memory and remove the linear mapping manually.

The original idea was discussed in:
https://lkml.kernel.org/r/[email protected]

I only tested via QEMU TCG with a single NUMA node- see patch #8 for more details.

Error handling and cleanup handling in memtrace code is a mess - that should definitely get cleaned up sooner or later. Once we have __GFP_ZERO support for alloc_contig_pages(), we can drop manual clearing. I added a TODO for now, so this series can go via the powerpc tree - the __GFP_ZERO change is then better suited via the mm tree, along with support for __GFP_ZERO.

v1 -> v2:
- Tweaks to patch descriptions
- "powernv/memtrace: don't leak kernel memory to user space"
-- Added. Reported by Michael.
- "powernv/memtrace: fix crashing the kernel when enabling concurrently" -- Added, discovered while testing.
- "powerpc/mm: protect linear mapping modifications by a mutex" -- Added. Although we currently won't have concurrency, this is cleaner and future-proof.
- "powerepc/book3s64/hash: drop WARN_ON in hash__remove_section_mapping" -- Added. Suggested by Oscar
- "powernv/memtrace: don't abuse memory hot(un)plug infrastructure for memory allocations"
-- Reshuffle the code to make review easier.
-- Add a TODO regarding __GFP_ZERO. Adapt to changed page clearing code. -- Use GFP_KERNEL | __GFP_THISNODE | __GFP_NOWARN for allocations.

David Hildenbrand (8):
powernv/memtrace: don't leak kernel memory to user space powernv/memtrace: fix crashing the kernel when enabling concurrently powerpc/mm: factor out creating/removing linear mapping powerpc/mm: protect linear mapping modifications by a mutex powerpc/mm: print warning in arch_remove_linear_mapping() powerepc/book3s64/hash: drop WARN_ON in hash__remove_section_mapping powerpc/mm: remove linear mapping if __add_pages() fails in
arch_add_memory()
powernv/memtrace: don't abuse memory hot(un)plug infrastructure for
memory allocations

 arch/powerpc/mm/book3s64/hash_utils.c     |   1 -
 arch/powerpc/mm/mem.c                     |  53 +++++--
 arch/powerpc/platforms/powernv/Kconfig    |   8 +-
 arch/powerpc/platforms/powernv/memtrace.c | 175 ++++++++++------------
 include/linux/memory_hotplug.h            |   3 +
 5 files changed, 125 insertions(+), 115 deletions(-)
Signature · 1 line
2.26.2