Skip to content

KVM: arm64: Fix get-reg-list regression

Andrew Jones kvmarm stable 3 versions – Applied

Status from this message: Applied to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesApplied
  2. v23 patches 12 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Improve commit messages [Dave]
- Add new patch to consolidate REG_HIDDEN* flags [Dave]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4KVM: arm64: Don't hide ID registers from userspacearch/arm64/kvm/sys_regs.c+1 -170 replies
2/4KVM: arm64: Consolidate REG_HIDDEN_GUEST/USERarch/arm64/kvm/sys_regs.c arch/arm64/kvm/sys_regs.h+10 -200 replies
3/4KVM: arm64: Check RAZ visibility in ID register accessorsarch/arm64/kvm/sys_regs.c arch/arm64/kvm/sys_regs.h+26 -30 replies
4/4KVM: arm64: Remove AA64ZFR0_EL1 accessorsarch/arm64/kvm/sys_regs.c+11 -500 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDave Martin
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] KVM: arm64: Fix get-reg-list regression

张东旭 <[email protected]> reported a regression seen with CentOS when migrating from an old kernel to a new one. The problem was that QEMU rejected the migration since KVM_GET_REG_LIST reported a register was missing on the destination. Extra registers are OK on the destination, but not missing ones. The regression reproduces with upstream kernels when migrating from a 4.15 or later kernel, up to one with commit 73433762fcae ("KVM: arm64/sve: System register context switch and access support"), to a kernel that includes that commit, e.g. the latest mainline (5.10-rc2).

The first patch of this series is the fix. The next two patches, which don't have any intended functional changes, allow ID_SANITISED to be used for registers that flip between exposing features and being RAZ, which allows some code to be removed.

v3:
- Improve commit messages [Dave]
- Add new patch to consolidate REG_HIDDEN* flags [Dave]

v2:
- CC stable [Marc]
- Only one RAZ flag is enough [Marc]
- Move id_visibility() up by read_id_reg() since they'll likely be maintained together [drew]

Andrew Jones (4):
KVM: arm64: Don't hide ID registers from userspace
KVM: arm64: Consolidate REG_HIDDEN_GUEST/USER
KVM: arm64: Check RAZ visibility in ID register accessors
KVM: arm64: Remove AA64ZFR0_EL1 accessors

 arch/arm64/kvm/sys_regs.c | 108 ++++++++++++--------------------------
 arch/arm64/kvm/sys_regs.h |  16 +++---
 2 files changed, 41 insertions(+), 83 deletions(-)
Signature · 6 lines
2.26.2

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm