Skip to content

qdev property code cleanup

Eduardo Habkost qemu-arm qemu-devel xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest32 patches 36 repliesIn review
  2. v353 patches 4 repliesSuperseded
  3. v244 patches 26 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v136 patches49 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32cs4231: Get rid of empty property arrayhw/audio/cs4231.c+0 -51 reply
2/32cpu: Move cpu_common_props to hw/core/cpu.ccpu.c hw/core/cpu.c include/hw/core/cpu.h+15 -160 replies
3/32qdev: Move property code to qdev-properties.[ch]hw/core/qdev-properties.c hw/core/qdev.c include/hw/qdev-core.h +2 more+159 -1570 replies
4/32qdev: Check dev->realized at set_size()hw/core/qdev-properties.c+5 -00 replies
5/32sparc: Check dev->realized at sparc_set_nwindows()target/sparc/cpu.c+6 -01 reply
6/32qdev: Don't use dev->id on set_size32() error messagehw/core/qdev-properties.c+1 -10 replies
7/32qdev: Make PropertyInfo.print method get Object* argumenthw/core/qdev-properties-system.c hw/core/qdev-properties.c include/hw/qdev-properties.h+4 -40 replies
8/32qdev: Make bit_prop_set() get Object* argumenthw/core/qdev-properties.c+6 -40 replies
9/32qdev: Make qdev_get_prop_ptr() get Object* argbackends/tpm/tpm_util.c hw/block/xen-block.c hw/core/qdev-properties-system.c +5 more+68 -1001 reply
10/32qdev: Make qdev_find_global_prop() get Object* argumenthw/core/qdev-properties-system.c hw/core/qdev-properties.c include/hw/qdev-properties.h+4 -40 replies
11/32qdev: Make check_prop_still_unset() get Object* argumenthw/core/qdev-properties-system.c+5 -50 replies
12/32qdev: Make error_set_from_qdev_prop_error() get Object* argumenthw/core/qdev-properties-system.c hw/core/qdev-properties.c hw/s390x/css.c +1 more+12 -120 replies
13/32qdev: Make qdev_propinfo_get_uint16() statichw/core/qdev-prop-internal.h hw/core/qdev-properties.c+3 -50 replies
14/32qdev: Move UUID property to qdev-properties-system.chw/core/qdev-properties-system.c hw/core/qdev-properties.c+57 -571 reply
15/32qdev: Move softmmu properties to qdev-properties-system.haudio/audio.h hw/acpi/vmgenid.c hw/arm/pxa2xx.c +73 more+158 -753 replies
16/32qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macrosinclude/hw/qdev-properties-system.h include/hw/qdev-properties.h+46 -871 reply
17/32sparc: Use DEFINE_PROP for nwindows propertytarget/sparc/cpu.c+2 -14 replies
18/32qdev: Get just property name at error_set_from_qdev_prop_error()hw/core/qdev-properties-system.c hw/core/qdev-properties.c hw/s390x/css.c +1 more+12 -122 replies
19/32qdev: Avoid using prop->name unnecessarilybackends/tpm/tpm_util.c hw/core/qdev-properties-system.c hw/core/qdev-properties.c+10 -101 reply
20/32qdev: Add name parameter to qdev_class_add_property()hw/core/qdev-properties.c+5 -40 replies
21/32qdev: Add name argument to PropertyInfo.create methodhw/core/qdev-properties.c include/hw/qdev-properties.h+5 -41 reply
22/32qdev: Wrap getters and setters in separate helpershw/core/qdev-properties.c+40 -41 reply
23/32qdev: Move dev->realized check to qdev_property_set()backends/tpm/tpm_util.c hw/block/xen-block.c hw/core/qdev-properties-system.c +5 more+18 -1885 replies
24/32qdev: Make PropertyInfo.create return ObjectProperty*hw/core/qdev-properties.c include/hw/qdev-properties.h+8 -71 reply
25/32qdev: Make qdev_class_add_property() more flexiblehw/core/qdev-properties.c+9 -83 replies
26/32qdev: Separate generic and device-specific property registrationhw/core/qdev-prop-internal.h hw/core/qdev-properties.c+71 -81 reply
27/32qdev: Rename qdev_propinfo_* to field_prop_*hw/core/qdev-prop-internal.h hw/core/qdev-properties-system.c hw/core/qdev-properties.c+69 -691 reply
28/32qdev: Move qdev_prop_tpm declaration to tpm_prop.hhw/tpm/tpm_prop.h include/hw/qdev-properties.h+2 -11 reply
29/32qdev: Rename qdev_prop_* to prop_info_*hw/core/qdev-properties.c hw/intc/arm_gicv3_common.c hw/intc/rx_icu.c +5 more+59 -590 replies
30/32qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()backends/tpm/tpm_util.c hw/block/xen-block.c hw/core/qdev-properties-system.c +5 more+67 -673 replies
31/32qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen()hw/core/qdev-properties.c+2 -31 reply
32/32tests: Add unit test for qdev array propertiestests/test-qdev-global-props.c+61 -00 replies

Reviews trailers per patch

28 of 32 patches have a Reviewed-by or Acked-by.

PatchMarc-André LureauCornelia HuckStefan BergerPaul DurrantIgor MammedovMark Cave-Ayland
1/32R-b
2/32R-b
3/32R-b
4/32R-b
5/32R-b A-b
6/32R-b
7/32R-b
8/32R-b
9/32R-b R-b A-b
10/32R-b
11/32R-b
12/32R-b R-b
13/32R-b
14/32R-b
15/32R-b
16/32R-b
17/32R-b A-b
18/32R-b R-b
19/32R-b R-b
20/32
21/32R-b
22/32R-b
23/32R-b R-b A-b R-b
24/32R-b
25/32R-b
26/32
27/32R-b
28/32R-b R-b R-b
29/32
30/32R-b R-b A-b R-b
31/32R-b R-b
32/32

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/32] qdev property code cleanup

This code contains the first 32 patches from the series:

Subject: [PATCH v3 00/53] Make qdev static property API usable by any QOM type
https://lore.kernel.org/qemu-devel/[email protected]

I'm submitting this separately so we can merge the qdev-specific cleanup while we discuss our long term plans for QOM properties.

Eduardo Habkost (32):
cs4231: Get rid of empty property array
cpu: Move cpu_common_props to hw/core/cpu.c
qdev: Move property code to qdev-properties.[ch]
qdev: Check dev->realized at set_size()
sparc: Check dev->realized at sparc_set_nwindows()
qdev: Don't use dev->id on set_size32() error message
qdev: Make PropertyInfo.print method get Object* argument
qdev: Make bit_prop_set() get Object* argument
qdev: Make qdev_get_prop_ptr() get Object* arg
qdev: Make qdev_find_global_prop() get Object* argument
qdev: Make check_prop_still_unset() get Object* argument
qdev: Make error_set_from_qdev_prop_error() get Object* argument
qdev: Make qdev_propinfo_get_uint16() static
qdev: Move UUID property to qdev-properties-system.c
qdev: Move softmmu properties to qdev-properties-system.h
qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros
sparc: Use DEFINE_PROP for nwindows property
qdev: Get just property name at error_set_from_qdev_prop_error()
qdev: Avoid using prop->name unnecessarily
qdev: Add name parameter to qdev_class_add_property()
qdev: Add name argument to PropertyInfo.create method
qdev: Wrap getters and setters in separate helpers
qdev: Move dev->realized check to qdev_property_set()
qdev: Make PropertyInfo.create return ObjectProperty*
qdev: Make qdev_class_add_property() more flexible
qdev: Separate generic and device-specific property registration
qdev: Rename qdev_propinfo_* to field_prop_*
qdev: Move qdev_prop_tpm declaration to tpm_prop.h
qdev: Rename qdev_prop_* to prop_info_*
qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()
qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen()
tests: Add unit test for qdev array properties

 audio/audio.h                       |   1 +
 hw/core/qdev-prop-internal.h        |  76 +++-
 hw/tpm/tpm_prop.h                   |   2 +
 include/hw/block/block.h            |   1 +
 include/hw/core/cpu.h               |   1 -
 include/hw/qdev-core.h              |  37 --
 include/hw/qdev-properties-system.h |  77 ++++
 include/hw/qdev-properties.h        | 289 ++++++---------
 include/net/net.h                   |   1 +
 backends/tpm/tpm_util.c             |  16 +-
 cpu.c                               |  15 -
 hw/acpi/vmgenid.c                   |   1 +
 hw/arm/pxa2xx.c                     |   1 +
 hw/arm/strongarm.c                  |   1 +
 hw/audio/cs4231.c                   |   5 -
 hw/block/fdc.c                      |   1 +
 hw/block/m25p80.c                   |   1 +
 hw/block/nand.c                     |   1 +
 hw/block/onenand.c                  |   1 +
 hw/block/pflash_cfi01.c             |   1 +
 hw/block/pflash_cfi02.c             |   1 +
 hw/block/vhost-user-blk.c           |   1 +
 hw/block/xen-block.c                |  11 +-
 hw/char/avr_usart.c                 |   1 +
 hw/char/bcm2835_aux.c               |   1 +
 hw/char/cadence_uart.c              |   1 +
 hw/char/cmsdk-apb-uart.c            |   1 +
 hw/char/debugcon.c                  |   1 +
 hw/char/digic-uart.c                |   1 +
 hw/char/escc.c                      |   1 +
 hw/char/etraxfs_ser.c               |   1 +
 hw/char/exynos4210_uart.c           |   1 +
 hw/char/grlib_apbuart.c             |   1 +
 hw/char/ibex_uart.c                 |   1 +
 hw/char/imx_serial.c                |   1 +
 hw/char/ipoctal232.c                |   1 +
 hw/char/lm32_juart.c                |   1 +
 hw/char/lm32_uart.c                 |   1 +
 hw/char/mcf_uart.c                  |   1 +
 hw/char/milkymist-uart.c            |   1 +
 hw/char/nrf51_uart.c                |   1 +
 hw/char/parallel.c                  |   1 +
 hw/char/pl011.c                     |   1 +
 hw/char/renesas_sci.c               |   1 +
 hw/char/sclpconsole-lm.c            |   1 +
 hw/char/sclpconsole.c               |   1 +
 hw/char/serial-pci-multi.c          |   1 +
 hw/char/serial.c                    |   1 +
 hw/char/spapr_vty.c                 |   1 +
 hw/char/stm32f2xx_usart.c           |   1 +
 hw/char/terminal3270.c              |   1 +
 hw/char/virtio-console.c            |   1 +
 hw/char/xilinx_uartlite.c           |   1 +
 hw/core/cpu.c                       |  15 +
 hw/core/qdev-properties-system.c    | 256 ++++++-------
 hw/core/qdev-properties.c           | 552 +++++++++++++++-------------
 hw/core/qdev.c                      | 120 ------
 hw/hyperv/vmbus.c                   |   1 +
 hw/i386/kvm/i8254.c                 |   1 +
 hw/ide/qdev.c                       |   1 +
 hw/intc/arm_gicv3_common.c          |   2 +-
 hw/intc/rx_icu.c                    |   4 +-
 hw/ipmi/ipmi_bmc_extern.c           |   1 +
 hw/ipmi/ipmi_bmc_sim.c              |   1 +
 hw/misc/allwinner-sid.c             |   1 +
 hw/misc/arm_sysctl.c                |   4 +-
 hw/misc/ivshmem.c                   |   1 +
 hw/misc/mac_via.c                   |   1 +
 hw/misc/sifive_u_otp.c              |   1 +
 hw/net/e1000e.c                     |   6 +-
 hw/net/rocker/rocker.c              |   1 +
 hw/nvram/eeprom_at24c.c             |   1 +
 hw/nvram/spapr_nvram.c              |   1 +
 hw/pci-bridge/gen_pcie_root_port.c  |   1 +
 hw/pci/pci.c                        |   1 +
 hw/ppc/pnv_pnor.c                   |   1 +
 hw/rdma/vmw/pvrdma_main.c           |   1 +
 hw/rtc/mc146818rtc.c                |   1 +
 hw/s390x/css.c                      |  13 +-
 hw/s390x/s390-pci-bus.c             |  10 +-
 hw/scsi/scsi-disk.c                 |   1 +
 hw/scsi/scsi-generic.c              |   1 +
 hw/scsi/vhost-user-scsi.c           |   1 +
 hw/sd/sd.c                          |   1 +
 hw/usb/ccid-card-passthru.c         |   1 +
 hw/usb/dev-serial.c                 |   1 +
 hw/usb/redirect.c                   |   1 +
 hw/vfio/pci-quirks.c                |  11 +-
 hw/vfio/pci.c                       |   1 +
 hw/virtio/vhost-user-fs.c           |   1 +
 hw/virtio/vhost-user-vsock.c        |   1 +
 hw/virtio/virtio-iommu-pci.c        |   1 +
 hw/xen/xen_pt.c                     |   1 +
 migration/migration.c               |   1 +
 softmmu/qdev-monitor.c              |   1 +
 target/arm/cpu.c                    |   2 +-
 target/sparc/cpu.c                  |   5 +-
 tests/test-qdev-global-props.c      |  61 +++
 98 files changed, 838 insertions(+), 826 deletions(-)
 create mode 100644 include/hw/qdev-properties-system.h
Signature · 1 line
2.28.0