qdev property code cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest32 patches 36 repliesIn review
- v353 patches 4 repliesSuperseded
- v244 patches 26 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 36 patches | 49 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/32 | cs4231: Get rid of empty property arrayhw/ | +0 | 1 reply | |
| 2/32 | cpu: Move cpu_common_props to hw/core/cpu.ccpu.c hw/ include/ | +15 | 0 replies | |
| 3/32 | qdev: Move property code to qdev-properties.[ch]hw/ hw/ include/ +2 more | +159 | 0 replies | |
| 4/32 | qdev: Check dev->realized at set_size()hw/ | +5 | 0 replies | |
| 5/32 | sparc: Check dev->realized at sparc_set_nwindows()target/ | +6 | 1 reply | |
| 6/32 | qdev: Don't use dev->id on set_size32() error messagehw/ | +1 | 0 replies | |
| 7/32 | qdev: Make PropertyInfo.print method get Object* argumenthw/ hw/ include/ | +4 | 0 replies | |
| 8/32 | qdev: Make bit_prop_set() get Object* argumenthw/ | +6 | 0 replies | |
| 9/32 | qdev: Make qdev_get_prop_ptr() get Object* argbackends/ hw/ hw/ +5 more | +68 | 1 reply | |
| 10/32 | qdev: Make qdev_find_global_prop() get Object* argumenthw/ hw/ include/ | +4 | 0 replies | |
| 11/32 | qdev: Make check_prop_still_unset() get Object* argumenthw/ | +5 | 0 replies | |
| 12/32 | qdev: Make error_set_from_qdev_prop_error() get Object* argumenthw/ hw/ hw/ +1 more | +12 | 0 replies | |
| 13/32 | qdev: Make qdev_propinfo_get_uint16() statichw/ hw/ | +3 | 0 replies | |
| 14/32 | qdev: Move UUID property to qdev-properties-system.chw/ hw/ | +57 | 1 reply | |
| 15/32 | qdev: Move softmmu properties to qdev-properties-system.haudio/ hw/ hw/ +73 more | +158 | 3 replies | |
| 16/32 | qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macrosinclude/ include/ | +46 | 1 reply | |
| 17/32 | sparc: Use DEFINE_PROP for nwindows propertytarget/ | +2 | 4 replies | |
| 18/32 | qdev: Get just property name at error_set_from_qdev_prop_error()hw/ hw/ hw/ +1 more | +12 | 2 replies | |
| 19/32 | qdev: Avoid using prop->name unnecessarilybackends/ hw/ hw/ | +10 | 1 reply | |
| 20/32 | qdev: Add name parameter to qdev_class_add_property()hw/ | +5 | 0 replies | |
| 21/32 | qdev: Add name argument to PropertyInfo.create methodhw/ include/ | +5 | 1 reply | |
| 22/32 | qdev: Wrap getters and setters in separate helpershw/ | +40 | 1 reply | |
| 23/32 | qdev: Move dev->realized check to qdev_property_set()backends/ hw/ hw/ +5 more | +18 | 5 replies | |
| 24/32 | qdev: Make PropertyInfo.create return ObjectProperty*hw/ include/ | +8 | 1 reply | |
| 25/32 | qdev: Make qdev_class_add_property() more flexiblehw/ | +9 | 3 replies | |
| 26/32 | qdev: Separate generic and device-specific property registrationhw/ hw/ | +71 | 1 reply | |
| 27/32 | qdev: Rename qdev_propinfo_* to field_prop_*hw/ hw/ hw/ | +69 | 1 reply | |
| 28/32 | qdev: Move qdev_prop_tpm declaration to tpm_prop.hhw/ include/ | +2 | 1 reply | |
| 29/32 | qdev: Rename qdev_prop_* to prop_info_*hw/ hw/ hw/ +5 more | +59 | 0 replies | |
| 30/32 | qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()backends/ hw/ hw/ +5 more | +67 | 3 replies | |
| 31/32 | qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen()hw/ | +2 | 1 reply | |
| 32/32 | tests: Add unit test for qdev array propertiestests/ | +61 | 0 replies |
Reviews trailers per patch
28 of 32 patches have a Reviewed-by or Acked-by.
| Patch | Marc-André Lureau | Cornelia Huck | Stefan Berger | Paul Durrant | Igor Mammedov | Mark Cave-Ayland |
|---|---|---|---|---|---|---|
| 1/32 | R-b | |||||
| 2/32 | R-b | |||||
| 3/32 | R-b | |||||
| 4/32 | R-b | |||||
| 5/32 | R-b | A-b | ||||
| 6/32 | R-b | |||||
| 7/32 | R-b | |||||
| 8/32 | R-b | |||||
| 9/32 | R-b | R-b | A-b | |||
| 10/32 | R-b | |||||
| 11/32 | R-b | |||||
| 12/32 | R-b | R-b | ||||
| 13/32 | R-b | |||||
| 14/32 | R-b | |||||
| 15/32 | R-b | |||||
| 16/32 | R-b | |||||
| 17/32 | R-b | A-b | ||||
| 18/32 | R-b | R-b | ||||
| 19/32 | R-b | R-b | ||||
| 20/32 | ||||||
| 21/32 | R-b | |||||
| 22/32 | R-b | |||||
| 23/32 | R-b | R-b | A-b | R-b | ||
| 24/32 | R-b | |||||
| 25/32 | R-b | |||||
| 26/32 | ||||||
| 27/32 | R-b | |||||
| 28/32 | R-b | R-b | R-b | |||
| 29/32 | ||||||
| 30/32 | R-b | R-b | A-b | R-b | ||
| 31/32 | R-b | R-b | ||||
| 32/32 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v4 00/32] qdev property code cleanup
This code contains the first 32 patches from the series:
Subject: [PATCH v3 00/53] Make qdev static property API usable by any QOM type
https://lore.kernel.org/qemu-devel/[email protected]
I'm submitting this separately so we can merge the qdev-specific cleanup while we discuss our long term plans for QOM properties.
Eduardo Habkost (32):
cs4231: Get rid of empty property array
cpu: Move cpu_common_props to hw/core/cpu.c
qdev: Move property code to qdev-properties.[ch]
qdev: Check dev->realized at set_size()
sparc: Check dev->realized at sparc_set_nwindows()
qdev: Don't use dev->id on set_size32() error message
qdev: Make PropertyInfo.print method get Object* argument
qdev: Make bit_prop_set() get Object* argument
qdev: Make qdev_get_prop_ptr() get Object* arg
qdev: Make qdev_find_global_prop() get Object* argument
qdev: Make check_prop_still_unset() get Object* argument
qdev: Make error_set_from_qdev_prop_error() get Object* argument
qdev: Make qdev_propinfo_get_uint16() static
qdev: Move UUID property to qdev-properties-system.c
qdev: Move softmmu properties to qdev-properties-system.h
qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros
sparc: Use DEFINE_PROP for nwindows property
qdev: Get just property name at error_set_from_qdev_prop_error()
qdev: Avoid using prop->name unnecessarily
qdev: Add name parameter to qdev_class_add_property()
qdev: Add name argument to PropertyInfo.create method
qdev: Wrap getters and setters in separate helpers
qdev: Move dev->realized check to qdev_property_set()
qdev: Make PropertyInfo.create return ObjectProperty*
qdev: Make qdev_class_add_property() more flexible
qdev: Separate generic and device-specific property registration
qdev: Rename qdev_propinfo_* to field_prop_*
qdev: Move qdev_prop_tpm declaration to tpm_prop.h
qdev: Rename qdev_prop_* to prop_info_*
qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()
qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen()
tests: Add unit test for qdev array properties
audio/audio.h | 1 + hw/core/qdev-prop-internal.h | 76 +++- hw/tpm/tpm_prop.h | 2 + include/hw/block/block.h | 1 + include/hw/core/cpu.h | 1 - include/hw/qdev-core.h | 37 -- include/hw/qdev-properties-system.h | 77 ++++ include/hw/qdev-properties.h | 289 ++++++--------- include/net/net.h | 1 + backends/tpm/tpm_util.c | 16 +- cpu.c | 15 - hw/acpi/vmgenid.c | 1 + hw/arm/pxa2xx.c | 1 + hw/arm/strongarm.c | 1 + hw/audio/cs4231.c | 5 - hw/block/fdc.c | 1 + hw/block/m25p80.c | 1 + hw/block/nand.c | 1 + hw/block/onenand.c | 1 + hw/block/pflash_cfi01.c | 1 + hw/block/pflash_cfi02.c | 1 + hw/block/vhost-user-blk.c | 1 + hw/block/xen-block.c | 11 +- hw/char/avr_usart.c | 1 + hw/char/bcm2835_aux.c | 1 + hw/char/cadence_uart.c | 1 + hw/char/cmsdk-apb-uart.c | 1 + hw/char/debugcon.c | 1 + hw/char/digic-uart.c | 1 + hw/char/escc.c | 1 + hw/char/etraxfs_ser.c | 1 + hw/char/exynos4210_uart.c | 1 + hw/char/grlib_apbuart.c | 1 + hw/char/ibex_uart.c | 1 + hw/char/imx_serial.c | 1 + hw/char/ipoctal232.c | 1 + hw/char/lm32_juart.c | 1 + hw/char/lm32_uart.c | 1 + hw/char/mcf_uart.c | 1 + hw/char/milkymist-uart.c | 1 + hw/char/nrf51_uart.c | 1 + hw/char/parallel.c | 1 + hw/char/pl011.c | 1 + hw/char/renesas_sci.c | 1 + hw/char/sclpconsole-lm.c | 1 + hw/char/sclpconsole.c | 1 + hw/char/serial-pci-multi.c | 1 + hw/char/serial.c | 1 + hw/char/spapr_vty.c | 1 + hw/char/stm32f2xx_usart.c | 1 + hw/char/terminal3270.c | 1 + hw/char/virtio-console.c | 1 + hw/char/xilinx_uartlite.c | 1 + hw/core/cpu.c | 15 + hw/core/qdev-properties-system.c | 256 ++++++------- hw/core/qdev-properties.c | 552 +++++++++++++++------------- hw/core/qdev.c | 120 ------ hw/hyperv/vmbus.c | 1 + hw/i386/kvm/i8254.c | 1 + hw/ide/qdev.c | 1 + hw/intc/arm_gicv3_common.c | 2 +- hw/intc/rx_icu.c | 4 +- hw/ipmi/ipmi_bmc_extern.c | 1 + hw/ipmi/ipmi_bmc_sim.c | 1 + hw/misc/allwinner-sid.c | 1 + hw/misc/arm_sysctl.c | 4 +- hw/misc/ivshmem.c | 1 + hw/misc/mac_via.c | 1 + hw/misc/sifive_u_otp.c | 1 + hw/net/e1000e.c | 6 +- hw/net/rocker/rocker.c | 1 + hw/nvram/eeprom_at24c.c | 1 + hw/nvram/spapr_nvram.c | 1 + hw/pci-bridge/gen_pcie_root_port.c | 1 + hw/pci/pci.c | 1 + hw/ppc/pnv_pnor.c | 1 + hw/rdma/vmw/pvrdma_main.c | 1 + hw/rtc/mc146818rtc.c | 1 + hw/s390x/css.c | 13 +- hw/s390x/s390-pci-bus.c | 10 +- hw/scsi/scsi-disk.c | 1 + hw/scsi/scsi-generic.c | 1 + hw/scsi/vhost-user-scsi.c | 1 + hw/sd/sd.c | 1 + hw/usb/ccid-card-passthru.c | 1 + hw/usb/dev-serial.c | 1 + hw/usb/redirect.c | 1 + hw/vfio/pci-quirks.c | 11 +- hw/vfio/pci.c | 1 + hw/virtio/vhost-user-fs.c | 1 + hw/virtio/vhost-user-vsock.c | 1 + hw/virtio/virtio-iommu-pci.c | 1 + hw/xen/xen_pt.c | 1 + migration/migration.c | 1 + softmmu/qdev-monitor.c | 1 + target/arm/cpu.c | 2 +- target/sparc/cpu.c | 5 +- tests/test-qdev-global-props.c | 61 +++ 98 files changed, 838 insertions(+), 826 deletions(-) create mode 100644 include/hw/qdev-properties-system.h
Signature · 1 line
2.28.0