Skip to content

ARM: remove set_fs callers and implementation

Arnd Bergmann linux-arch linux-arm-kernel linux-hardening linux-mm lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 10 repliesIn review
  2. v49 patches 5 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10mm/maccess: fix unaligned copy_{from,to}_kernel_nofaultmm/maccess.c+22 -60 replies
2/10ARM: traps: use get_kernel_nofault instead of set_fs()arch/arm/kernel/traps.c+16 -310 replies
3/10ARM: oabi-compat: add epoll_pwait handlerarch/arm/kernel/sys_oabi-compat.c arch/arm/tools/syscall.tbl+36 -40 replies
4/10ARM: syscall: always store thread_info->abi_syscallarch/arm/include/asm/syscall.h arch/arm/include/asm/thread_info.h arch/arm/include/uapi/asm/unistd.h +3 more+21 -103 replies
5/10ARM: oabi-compat: rework epoll_wait/epoll_pwait emulationarch/arm/include/asm/syscall.h arch/arm/kernel/sys_oabi-compat.c arch/arm/tools/syscall.tbl +2 more+49 -720 replies
6/10ARM: oabi-compat: rework sys_semtimedop emulationarch/arm/kernel/sys_oabi-compat.c include/linux/syscalls.h ipc/sem.c+99 -480 replies
7/10ARM: oabi-compat: rework fcntl64() emulationarch/arm/kernel/sys_oabi-compat.c+60 -330 replies
8/10ARM: uaccess: add __{get,put}_kernel_nofaultarch/arm/include/asm/uaccess.h+83 -405 replies
9/10ARM: uaccess: remove set_fs() implementationarch/arm/Kconfig arch/arm/include/asm/ptrace.h arch/arm/include/asm/thread_info.h +8 more+7 -860 replies
10/10ARM: oabi-compat: fix oabi epoll sparse warningarch/arm/kernel/sys_oabi-compat.c+1 -10 replies

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph HellwigLinus WalleijArnd Bergmann
SeriesA-b
1/10R-b R-b
2/10R-b R-b
3/10R-b
4/10
5/10
6/10
7/10
8/10R-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/10] ARM: remove set_fs callers and implementation

From: Arnd Bergmann <[email protected]>

Hi Christoph, Russell,

This is the rebased version of my ARM set_fs patches on top of v5.14-rc2. There were a couple of minor conflicts that I resolved, but otherwise this is still identical to the version I tested earlier.

The one notable change this time is that I rename thread_info->syscall to thread_info->abi_syscall, to clarify that this field now contains both the ABI bits (0x900000 for OABI, 0x000000 for EABI) in kernels that support both, and every access to this has to mask out the bits it needs. As Russell mentioned before, having a 'syscall' field that not just contains the syscall number is confusing and error-prone, so I hope this change is good enough.

I have tested the oabi-compat changes using the LTP tests for the three modified syscalls using an Armv7 kernel and a Debian 5 OABI user space.

I also tested the syscall_get_nr() in all combinations of OABI/EABI kernel user space and fixed the bugs I found after Russell pointed out those issues in the early versions.

Linus Walleij did additional testing of v4 on Footbridge with OABI user space.

With this and the m68k changes getting merged, we are very close to eliminating set_fs completely.

Russell, you can pull these from

https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git arm-setfs_v5

or I can add them to the ARM patch tracker if you prefer.

Arnd

v4: https://lore.kernel.org/linux-arm-kernel/[email protected]/
v3: https://lore.kernel.org/linux-arm-kernel/[email protected]/
v2: https://lore.kernel.org/linux-arm-kernel/[email protected]/
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

Arnd Bergmann (9):
mm/maccess: fix unaligned copy_{from,to}_kernel_nofault
ARM: traps: use get_kernel_nofault instead of set_fs()
ARM: oabi-compat: add epoll_pwait handler
ARM: syscall: always store thread_info->abi_syscall
ARM: oabi-compat: rework epoll_wait/epoll_pwait emulation
ARM: oabi-compat: rework sys_semtimedop emulation
ARM: oabi-compat: rework fcntl64() emulation
ARM: uaccess: add __{get,put}_kernel_nofault
ARM: uaccess: remove set_fs() implementation
ARM: oabi-compat: fix oabi epoll sparse warning

 arch/arm/Kconfig                   |   1 -
 arch/arm/include/asm/ptrace.h      |   1 -
 arch/arm/include/asm/syscall.h     |  16 ++-
 arch/arm/include/asm/thread_info.h |   6 +-
 arch/arm/include/asm/uaccess-asm.h |   6 -
 arch/arm/include/asm/uaccess.h     | 169 ++++++++++++-----------
 arch/arm/include/uapi/asm/unistd.h |   1 +
 arch/arm/kernel/asm-offsets.c      |   3 +-
 arch/arm/kernel/entry-common.S     |  20 +--
 arch/arm/kernel/process.c          |   7 +-
 arch/arm/kernel/ptrace.c           |  14 +-
 arch/arm/kernel/signal.c           |   8 --
 arch/arm/kernel/sys_oabi-compat.c  | 214 +++++++++++++++++------------
 arch/arm/kernel/traps.c            |  47 +++----
 arch/arm/lib/copy_from_user.S      |   3 +-
 arch/arm/lib/copy_to_user.S        |   3 +-
 arch/arm/tools/syscall.tbl         |   2 +-
 fs/eventpoll.c                     |   5 +-
 include/linux/eventpoll.h          |  18 +++
 include/linux/syscalls.h           |   3 +
 ipc/sem.c                          |  84 ++++++-----
 mm/maccess.c                       |  28 +++-
 22 files changed, 361 insertions(+), 298 deletions(-)
Signature · 1 line
2.29.2