Skip to content

qdev/qom: Remove explicit type names from error_setg() calls

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20qom: Add prefix to error message inside object_property_parse()qom/object.c+11 -01 reply
2/20qdev: Stop using error_set_from_qdev_prop_error() for netdev propertyhw/core/qdev-properties-system.c+3 -40 replies
3/20qdev: Stop using error_set_from_qdev_prop_error() for audiodev propertyhw/core/qdev-properties-system.c+1 -30 replies
4/20qdev: Stop using error_set_from_qdev_prop_error() for mac propertyhw/core/qdev-properties-system.c+1 -10 replies
5/20qdev: Stop using error_set_from_qdev_prop_error() for devfn propertyhw/core/qdev-properties-system.c+1 -10 replies
6/20qdev: Stop using error_set_from_qdev_prop_error() for PCI host device propertyhw/core/qdev-properties-system.c+1 -10 replies
7/20qdev: Stop using error_set_from_qdev_prop_error() for css devno propertyhw/s390x/css.c+1 -10 replies
8/20qdev: Delete unused error_set_from_qdev_prop_error() functionhw/core/qdev-properties.c include/hw/qdev-properties.h+0 -240 replies
9/20cryptodev: Remove unnecessary prefix from error messagebackends/cryptodev.c+1 -20 replies
10/20memfd: Remove unnecessary prefix from error messagebackends/hostmem-memfd.c+1 -21 reply
11/20tpm_util: Remove unnecessary prefix from error messagebackends/tpm/tpm_util.c+1 -20 replies
12/20qdev: drive: Remove unnecessary prefix from error messagehw/core/qdev-properties-system.c+1 -20 replies
13/20qdev: chardev: Remove unnecessary prefix from error messagehw/core/qdev-properties-system.c+3 -50 replies
14/20i386: Remove unnecessary prefix from error messagetarget/i386/cpu.c+1 -11 reply
15/20qerror: Delete unused QERR_PROPERTY_VALUE_BAD macroinclude/qapi/qmp/qerror.h+0 -30 replies
16/20nvdimm: Remove unnecessary prefix from error messagehw/mem/nvdimm.c+2 -41 reply
17/20colo-compare: Remove unnecessary prefix from error messagenet/colo-compare.c+3 -60 replies
18/20filter-dump: Remove unnecessary prefix from error messagenet/dump.c+1 -20 replies
19/20filter-buffer: Remove unnecessary prefix from error messagenet/filter-buffer.c+1 -20 replies
20/20qom: Remove error prefix check at object_property_parse()qom/object.c+2 -80 replies

Reviews trailers per patch

4 of 20 patches have a Reviewed-by or Acked-by.

PatchIgor Mammedov
1/20R-b
2/20
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20R-b
11/20
12/20
13/20
14/20R-b
15/20
16/20R-b
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] qdev/qom: Remove explicit type names from error_setg() calls

Based-on: [email protected]
Git branch: https://gitlab.com/ehabkost/qemu/-/commits/work/prop-error-reporting

One of the obstacles when refactoring the QOM property parsing code are the references to the object itself in the error code, to generate "Property '<TYPE>.<PROP>' can't take value ..." error messages. This makes it hard to isolate the string parsing code into functions that are independent from QOM.

The simple solution for that would be to just remove the prefix and have less descriptive error messages.

A slightly better solution is to make the code that parses -device and -object add a
"Property '<TYPE>.<PROP>' can't take value '<VALUE>': "
prefix automatically when encountering an error when setting a property. This is the approach implemented in this series.

Eduardo Habkost (20):
qom: Add prefix to error message inside object_property_parse()
qdev: Stop using error_set_from_qdev_prop_error() for netdev property
qdev: Stop using error_set_from_qdev_prop_error() for audiodev
property
qdev: Stop using error_set_from_qdev_prop_error() for mac property
qdev: Stop using error_set_from_qdev_prop_error() for devfn property
qdev: Stop using error_set_from_qdev_prop_error() for PCI host device
property
qdev: Stop using error_set_from_qdev_prop_error() for css devno
property
qdev: Delete unused error_set_from_qdev_prop_error() function
cryptodev: Remove unnecessary prefix from error message
memfd: Remove unnecessary prefix from error message
tpm_util: Remove unnecessary prefix from error message
qdev: drive: Remove unnecessary prefix from error message
qdev: chardev: Remove unnecessary prefix from error message
i386: Remove unnecessary prefix from error message
qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro
nvdimm: Remove unnecessary prefix from error message
colo-compare: Remove unnecessary prefix from error message
filter-dump: Remove unnecessary prefix from error message
filter-buffer: Remove unnecessary prefix from error message
qom: Remove error prefix check at object_property_parse()

 include/hw/qdev-properties.h     |  2 --
 include/qapi/qmp/qerror.h        |  3 ---
 backends/cryptodev.c             |  3 +--
 backends/hostmem-memfd.c         |  3 +--
 backends/tpm/tpm_util.c          |  3 +--
 hw/core/qdev-properties-system.c | 28 +++++++++++-----------------
 hw/core/qdev-properties.c        | 22 ----------------------
 hw/mem/nvdimm.c                  |  6 ++----
 hw/s390x/css.c                   |  2 +-
 net/colo-compare.c               |  9 +++------
 net/dump.c                       |  3 +--
 net/filter-buffer.c              |  3 +--
 qom/object.c                     |  5 +++++
 target/i386/cpu.c                |  2 +-
 14 files changed, 28 insertions(+), 66 deletions(-)
Signature · 1 line
2.28.0