Skip to content

MT7621 PCIe PHY

Sergio Paracuellos linux-devicetree lkml 3 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 2 repliesApplied
  2. v54 patches 2 repliesSuperseded
  3. v44 patches 7 repliesSuperseded

Changes in v6 from the cover letter

- Change definition name to XTAL_MASK to fix its use in one line.
- Fix XTAL_MASK mask value after use it with 'FIELD_GET'.
- Add comment in 'mt7621_phy_rmw' about why 'regmap_write_bits' cannot be used.
- Rebase series on the top of 'next' branch of 'linux-phy' tree.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHYDocumentation/devicetree/bindings/phy/mediatek,mt7621-pci-phy.yaml+36 -00 replies
2/4phy: ralink: Add PHY driver for MT7621 PCIe PHYdrivers/phy/ralink/Kconfig drivers/phy/ralink/Makefile drivers/phy/ralink/phy-mt7621-pci.c+361 -00 replies
3/4MAINTAINERS: add MT7621 PHY PCI maintainerMAINTAINERS+6 -00 replies
4/4staging: mt7621-pci-phy: remove driver from stagingdrivers/staging/Kconfig drivers/staging/Makefile drivers/staging/mt7621-pci-phy/Kconfig +4 more+0 -4260 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchRob HerringGreg Kroah-Hartman
1/4R-b
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] MT7621 PCIe PHY

This series adds support for the PCIe PHY found in the Mediatek MT7621 SoC.

There is also a 'mt7621-pci' driver which is the controller part which is still in staging and is a client of this phy.

Both drivers have been tested together in a gnubee1 board.

This series are rebased on the top of linux-phy:
commit 768a711e2d4b ("phy: samsung: phy-exynos-pcie: fix typo 'tunning'")

Changes in v6:
- Change definition name to XTAL_MASK to fix its use in one line.
- Fix XTAL_MASK mask value after use it with 'FIELD_GET'.
- Add comment in 'mt7621_phy_rmw' about why 'regmap_write_bits' cannot be used.
- Rebase series on the top of 'next' branch of 'linux-phy' tree.

Changes in v5:
- PATCH 1/4: Recollect Rob's Reviewed-by of bindings.
- PATCH 4/4: Recollect Greg's Acked-by for removing stuff from staging area.
- Use 'devm_platform_ioremap_resource' instead of using 'platform_get_resource' and 'devm_ioremap_resource'.
- Make Vinod's review comments changes in [0]:
* Use FIELD_GET and FIELD_PREP apis and avoid multiple *_VAL and *_SHIFT custom definitions.
* Remove phy-read and phy-write internal functions and directly call regmap_read and regmap_write in 'mt7621_phy_rmw'.
* Change some traces from info to debug log level.
* Note that I have maintained 'mt7621_phy_rmw' instead of use 'regmap_update_bits'. This is because in order to get a reliable boot registers must be written event the contained value in that register is the same. I have preferred doing in this way instead of using 'regmap_update_bits_base' passing 'false' for async and 'true' for the force write. If this way of using 'regmap_update_bits_base' is preferred just let me know.

Changes in v4:
- Bindings moved from txt to yaml so previous Rob's Reviewed-by is not in the new patch with the yaml file.
- 'phy-cells' property means now if phy is dual-ported.
- Avoid custom 'xlate' function and properly set registers when the phy is dual ported.
- Add use of 'builtin_platform_driver'.
- Added a patch including myself as maintainer in the MAINTAINERS file.
- Add a patch removing patch from staging to make easier the complete inclusion and avoid possible problems might appear in 'linux-next' if the series are included.

Changes in v3:
- Recollect Rob's Reviewed-by of bindings.
- Make Kishon Vijay suggested changes in v2:
(See https://lkml.org/lkml/2019/4/17/53)
- Kconfig:
* Add depends on COMPILE_TEST
* Select REGMAP_MMIO
- Make use of 'soc_device_attribute' and 'soc_device_match'
- Use regmap mmio API instead of directly 'readl' and 'writel'.
- Use 'platform_get_resource' instead of 'of_address_to_resource'.

Changes in v2:
- Reorder patches to get bindings first in the series.
- Don't use child nodes in the device tree. Use #phy-cells=1 instead.
- Update driver code with new 'xlate' function for the new device tree.
- Minor changes in driver's macros changing some spaces to tabs.

Thanks in advance for your time.

Best regards,
Sergio Paracuellos

[0]: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-November/148864.html

Sergio Paracuellos (4):
dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY
phy: ralink: Add PHY driver for MT7621 PCIe PHY
MAINTAINERS: add MT7621 PHY PCI maintainer
staging: mt7621-pci-phy: remove driver from staging

 .../phy}/mediatek,mt7621-pci-phy.yaml         |   2 +-
 MAINTAINERS                                   |   6 +
 drivers/phy/ralink/Kconfig                    |   8 ++
 drivers/phy/ralink/Makefile                   |   1 +
 .../ralink/phy-mt7621-pci.c}                  | 115 +++++++-----------
 drivers/staging/Kconfig                       |   2 -
 drivers/staging/Makefile                      |   1 -
 drivers/staging/mt7621-pci-phy/Kconfig        |   8 --
 drivers/staging/mt7621-pci-phy/Makefile       |   2 -
 drivers/staging/mt7621-pci-phy/TODO           |   4 -
 10 files changed, 63 insertions(+), 86 deletions(-)
 rename {drivers/staging/mt7621-pci-phy => Documentation/devicetree/bindings/phy}/mediatek,mt7621-pci-phy.yaml (92%)
 rename drivers/{staging/mt7621-pci-phy/pci-mt7621-phy.c => phy/ralink/phy-mt7621-pci.c} (76%)
 delete mode 100644 drivers/staging/mt7621-pci-phy/Kconfig
 delete mode 100644 drivers/staging/mt7621-pci-phy/Makefile
 delete mode 100644 drivers/staging/mt7621-pci-phy/TODO
Signature · 1 line
2.25.1