Skip to content

RFC Secure Launch early PCR extend support

Daniel P. Smith linux-integrity lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tpm: Move TPM TIS definitions out of TIS core headerdrivers/char/tpm/tpm_tis_core.h drivers/char/tpm/tpm_tis_defs.h+82 -590 replies
2/4tpm: Move core definitions and buffer management out of main TPM headerinclude/linux/tpm.h include/linux/tpm_buffer.h include/linux/tpm_core.h+310 -2671 reply
3/4tpm: Conditionally use static buffer in TPM buffer managementinclude/linux/tpm_buffer.h+12 -01 reply
4/4x86: Add early PCR extend support for Secure Launcharch/x86/boot/compressed/Makefile arch/x86/boot/compressed/early_pcr_extend.c arch/x86/boot/compressed/early_pcr_extend.h+405 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/4] Secure Launch early PCR extend support

This RFC is a break out of the prerequisite TPM functionality for the larger Secure Launch capability. This TPM/PCR subset is in a separate smaller patch set being sent as an RFC to get early feedback before the whole Secure Launch patch set is resubmitted. This patch RFC, if accepted, will be part of the overall Secure Launch patch set.

TPMs support numerous operations, the majority of which will never be used by the Secure Launch feature in the compressed kernel. Given that, this RFC does not seek to implement a TPM driver but merely enough logic for the PCR extend operation with a reasonable reuse of the mainline TPM driver.

In this RFC is the early_pcr_extend functionality that is built from shared headers with the mainline TPM driver for common definitions and TPM buffer functionality. The early_pcr_extend balances the introduction of new logic to communicate with the TPM without having to introduce unrelated hardware features not already available under the compressed kernel. The target usage of early_pcr_extend is to support DRTM capable hardware under Secure Launch. Historically the authors have not encountered any DRTM capable hardware that uses any other interface other than the TPM Interface Specification (TIS) FIFO software interface. To minimize the impact to code size and avoid unnecessary functionality in the compressed kernel, the early_pcr_extend provides a very limited implementation of the FIFO interface necessary to set locality and carry out the extend operation.

For the sake of completeness, a discussion on the proposed refactoring of the mainline driver FIFO and TPM command handling for reuse in the compressed kernel needs to be addressed. After reviewing the mainline TPM driver for a second time, we have arrived at the conclusion that the driver is too entangled with the mainline kernel functionality which makes refactoring highly impractical. The following are a few examples of this entanglement. The mainline TPM driver is built around the tpm_chip structure which uses definitions not available in the compressed kernel. It is likely that bringing these definitions into the compressed kernel purely to make the tpm_chip structure available, would be found to be unacceptable. Therefore it would be necessary to create a compressed kernel representation which would end up with a majority of tpm_chip structure being stubbed out since very little of this abstraction is required for the one TPM command that will be used. Another concern is that the mainline TPM driver FIFO interface is heavily reliant on timers implemented with mainline kernel jiffies for interacting with the TPM. The compressed kernel does not have access to jiffies. In the compressed kernel, jiffies have not been initialized and timers have not been started. Therefore the use of jiffies would have to be abstracted out of the mainline TPM driver resulting in a significant refactoring or borderline rewrite of the driver.

We believe that the approach we are presenting here should be satisfactory. We feel it is clear that we are not trying to create a new TPM driver. We have split up the TPM headers to be able to reuse almost all the needed definitions/ structures. In addition, we switched to using the mainline TPM driver's buffer functions. The remaining code to do the extend is minimal and appropriate for the compressed kernel environment.

Thank you,
Daniel P. Smith and Ross Philipson

Daniel P. Smith (4):
tpm: Move TPM TIS definitions out of TIS core header
tpm: Move core definitions and buffer management out of main TPM
header
tpm: Conditionally use static buffer in TPM buffer management
x86: Add early PCR extend support for Secure Launch

 arch/x86/boot/compressed/Makefile           |   2 +
 arch/x86/boot/compressed/early_pcr_extend.c | 311 ++++++++++++++++++++++++++++
 arch/x86/boot/compressed/early_pcr_extend.h |  92 ++++++++
 drivers/char/tpm/tpm_tis_core.h             |  60 +-----
 drivers/char/tpm/tpm_tis_defs.h             |  81 ++++++++
 include/linux/tpm.h                         | 269 +-----------------------
 include/linux/tpm_buffer.h                  | 135 ++++++++++++
 include/linux/tpm_core.h                    | 185 +++++++++++++++++
 8 files changed, 809 insertions(+), 326 deletions(-)
 create mode 100644 arch/x86/boot/compressed/early_pcr_extend.c
 create mode 100644 arch/x86/boot/compressed/early_pcr_extend.h
 create mode 100644 drivers/char/tpm/tpm_tis_defs.h
 create mode 100644 include/linux/tpm_buffer.h
 create mode 100644 include/linux/tpm_core.h
Signature · 1 line
2.11.0