Skip to content

arm/arm64: Allow the rescheduling IPI to bypass irq_enter/exit

Marc Zyngier linux-arm-kernel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 14 repliesIn review
  2. v12 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6genirq: Add __irq_modify_status() helper to clear/set special flagsinclude/linux/irq.h kernel/irq/chip.c kernel/irq/settings.h+21 -40 replies
2/6genirq: Allow an interrupt to be marked as 'raw'include/linux/irq.h kernel/irq/Kconfig kernel/irq/debugfs.c +2 more+33 -58 replies
3/6arm64: Mark the recheduling IPI as raw interruptarch/arm64/Kconfig arch/arm64/kernel/smp.c+5 -01 reply
4/6arm: Mark the recheduling IPI as raw interruptarch/arm/Kconfig arch/arm/kernel/smp.c+5 -00 replies
5/6genirq: Drop IRQ_HIDDEN from IRQF_MODIFY_MASKarch/arm/kernel/smp.c arch/arm64/kernel/smp.c include/linux/irq.h+3 -30 replies
6/6genirq: Rename IRQ_HIDDEN to IRQ_IPIarch/arm/kernel/smp.c arch/arm64/kernel/smp.c include/linux/irq.h +3 more+10 -101 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchWill Deacon
1/6
2/6
3/6A-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] arm/arm64: Allow the rescheduling IPI to bypass irq_enter/exit

This is the second version of my earlier series [1], which aims at fixing (or papering over, depending on how you look at things) a performance regression seen on arm64 for reched IPI heavy workloads (such as "perf bench sched pipe").

As eloquently described by Thomas in his earlier replies [2], the current situation is less than ideal on most architecture except x86, and my conclusion is that what was broken in 5.9 wouldn't be more broken in 5.10 with these patches (and addresses the performance regression).

Needless to say, I intend to try and help fixing the issues Thomas mentioned, and I believe that Mark (cc'd) already has something that could be used as a healthy starting point (Mark, do correct me if I misrepresented your work).

Thanks,

	M.

* From v1:
- Added a new __irq_modify_status() helper
- Renamed IRQ_NAKED to IRQ_RAW
- Renamed IRQ_HIDDEN to IRQ_IPI
- Applied the same workaround to 32bit ARM for completeness

[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]/

Marc Zyngier (6):
genirq: Add __irq_modify_status() helper to clear/set special flags
genirq: Allow an interrupt to be marked as 'raw'
arm64: Mark the recheduling IPI as raw interrupt
arm: Mark the recheduling IPI as raw interrupt
genirq: Drop IRQ_HIDDEN from IRQF_MODIFY_MASK
genirq: Rename IRQ_HIDDEN to IRQ_IPI

 arch/arm/Kconfig        |  1 +
 arch/arm/kernel/smp.c   |  6 +++++-
 arch/arm64/Kconfig      |  1 +
 arch/arm64/kernel/smp.c |  6 +++++-
 include/linux/irq.h     | 11 ++++++++---
 kernel/irq/Kconfig      |  3 +++
 kernel/irq/chip.c       | 12 ++++++++++--
 kernel/irq/debugfs.c    |  3 ++-
 kernel/irq/irqdesc.c    | 17 ++++++++++++-----
 kernel/irq/proc.c       |  2 +-
 kernel/irq/settings.h   | 33 +++++++++++++++++++++++++++------
 11 files changed, 75 insertions(+), 20 deletions(-)
Signature · 1 line
2.28.0