Skip to content

Convert mlx5 to use auxiliary bus

Leon Romanovsky alsa-devel linux-rdma lkml netdev virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 17 repliesIn review

Changes in v1 from the cover letter

* Renamed _mlx5_rescan_driver to be mlx5_rescan_driver_locked like in other parts of the mlx5 driver.
* Renamed MLX5_INTERFACE_PROTOCOL_VDPA to tbe MLX5_INTERFACE_PROTOCOL_VNET as a preparation to coming series from Eli C.
* Some small naming renames in mlx5_vdpa.
* Refactored adev index code to make Parav's SF series to apply more easily.
* Fixed devlink reload bug that caused to lost TCP connection.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11net/mlx5: Don't skip vport checkdrivers/net/ethernet/mellanox/mlx5/core/esw/devlink_port.c drivers/net/ethernet/mellanox/mlx5/core/eswitch.c drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c+14 -10 replies
2/11net/mlx5: Properly convey driver version to firmwaredrivers/net/ethernet/mellanox/mlx5/core/main.c+5 -11 reply
3/11net/mlx5_core: Clean driver version and namedrivers/net/ethernet/mellanox/mlx5/core/devlink.c drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +4 more+12 -132 replies
4/11vdpa/mlx5: Make hardware definitions visible to all mlx5 devicesdrivers/vdpa/mlx5/net/main.c drivers/vdpa/mlx5/net/mlx5_vnet.c include/linux/mlx5/mlx5_ifc_vdpa.h+5 -53 replies
5/11net/mlx5: Register mlx5 devices to auxiliary virtual busdrivers/net/ethernet/mellanox/mlx5/core/Kconfig drivers/net/ethernet/mellanox/mlx5/core/dev.c drivers/net/ethernet/mellanox/mlx5/core/main.c +2 more+325 -113 replies
6/11vdpa/mlx5: Connect mlx5_vdpa to auxiliary busdrivers/net/ethernet/mellanox/mlx5/core/dev.c drivers/vdpa/mlx5/Makefile drivers/vdpa/mlx5/net/main.c +2 more+72 -1096 replies
7/11net/mlx5e: Connect ethernet part to auxiliary busdrivers/net/ethernet/mellanox/mlx5/core/dev.c drivers/net/ethernet/mellanox/mlx5/core/en_main.c drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +5 more+181 -890 replies
8/11RDMA/mlx5: Convert mlx5_ib to use auxiliary busdrivers/infiniband/hw/mlx5/ib_rep.c drivers/infiniband/hw/mlx5/ib_rep.h drivers/infiniband/hw/mlx5/main.c +5 more+251 -1040 replies
9/11net/mlx5: Delete custom device management logicdrivers/net/ethernet/mellanox/mlx5/core/dev.c drivers/net/ethernet/mellanox/mlx5/core/lag.c drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h +1 more+18 -3180 replies
10/11net/mlx5: Simplify eswitch mode checkdrivers/infiniband/hw/mlx5/counters.c drivers/infiniband/hw/mlx5/ib_rep.c drivers/infiniband/hw/mlx5/ib_rep.h +6 more+16 -301 reply
11/11RDMA/mlx5: Remove IB representors dead codedrivers/infiniband/hw/mlx5/ib_rep.c drivers/infiniband/hw/mlx5/ib_rep.h+7 -551 reply

Reviews trailers per patch

6 of 11 patches have a Reviewed-by or Acked-by.

PatchEli CohenParav PanditRoi Dayan
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11
6/11
7/11
8/11
9/11
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH mlx5-next v1 00/11] Convert mlx5 to use auxiliary bus

From: Leon Romanovsky <[email protected]>

Changelog:
v1:
* Renamed _mlx5_rescan_driver to be mlx5_rescan_driver_locked like in other parts of the mlx5 driver.
* Renamed MLX5_INTERFACE_PROTOCOL_VDPA to tbe MLX5_INTERFACE_PROTOCOL_VNET as a preparation to coming series from Eli C.
* Some small naming renames in mlx5_vdpa.
* Refactored adev index code to make Parav's SF series to apply more easily.
* Fixed devlink reload bug that caused to lost TCP connection.
v0:
https://lore.kernel.org/lkml/[email protected]/

--------------------------------------------------------------

Hi,

This patch set converts mlx5 driver to use auxiliary bus [1].

In this series, we are connecting three subsystems (VDPA, netdev and RDMA) through mlx5_core PCI driver. That driver is responsible to create proper devices based on supported firmware.

First four patches are preparitions and fixes that were spotted during code development, rest is the conversion itself.

Thanks

[1]
https://lore.kernel.org/lkml/[email protected]

Leon Romanovsky (11):
net/mlx5: Don't skip vport check
net/mlx5: Properly convey driver version to firmware net/mlx5_core: Clean driver version and name vdpa/mlx5: Make hardware definitions visible to all mlx5 devices net/mlx5: Register mlx5 devices to auxiliary virtual bus vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus net/mlx5e: Connect ethernet part to auxiliary bus RDMA/mlx5: Convert mlx5_ib to use auxiliary bus net/mlx5: Delete custom device management logic net/mlx5: Simplify eswitch mode check
RDMA/mlx5: Remove IB representors dead code

 drivers/infiniband/hw/mlx5/counters.c         |   7 -
 drivers/infiniband/hw/mlx5/ib_rep.c           | 113 ++--
 drivers/infiniband/hw/mlx5/ib_rep.h           |  45 +-
 drivers/infiniband/hw/mlx5/main.c             | 148 +++--
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |   4 +-
 .../net/ethernet/mellanox/mlx5/core/Kconfig   |   1 +
 drivers/net/ethernet/mellanox/mlx5/core/dev.c | 567 ++++++++++++------
 .../net/ethernet/mellanox/mlx5/core/devlink.c |   4 +-
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |   4 +-
 .../net/ethernet/mellanox/mlx5/core/en_main.c | 135 ++---
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  42 +-
 .../net/ethernet/mellanox/mlx5/core/en_rep.h  |   6 +-
 .../net/ethernet/mellanox/mlx5/core/en_tc.c   |   8 +-
 .../mellanox/mlx5/core/esw/devlink_port.c     |   2 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch.c |  28 +-
 .../mellanox/mlx5/core/eswitch_offloads.c     |   6 +
 .../mellanox/mlx5/core/ipoib/ethtool.c        |   2 +-
 drivers/net/ethernet/mellanox/mlx5/core/lag.c |  58 +-
 .../net/ethernet/mellanox/mlx5/core/main.c    |  50 +-
 .../ethernet/mellanox/mlx5/core/mlx5_core.h   |  33 +-
 drivers/vdpa/mlx5/Makefile                    |   2 +-
 drivers/vdpa/mlx5/net/main.c                  |  76 ---
 drivers/vdpa/mlx5/net/mlx5_vnet.c             |  53 +-
 drivers/vdpa/mlx5/net/mlx5_vnet.h             |  24 -
 include/linux/mlx5/driver.h                   |  34 +-
 include/linux/mlx5/eswitch.h                  |   8 +-
 .../linux/mlx5/mlx5_ifc_vdpa.h                |   6 +-
 27 files changed, 818 insertions(+), 648 deletions(-)
 delete mode 100644 drivers/vdpa/mlx5/net/main.c
 delete mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
 rename drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h => include/linux/mlx5/mlx5_ifc_vdpa.h (97%)

--
2.28.0