test/lpm: fix rcu qsbr perf test
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest4 patches 5 repliesIn review
- v44 patches 3 repliesSuperseded
- v34 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 4 patches | 18 replies | Superseded |
Changes in v5 from the cover letter
- Update logic for routes inserted by each writer in multi writer test to avoid possibility of routes getting skipped
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | test/lpm: fix cycle calculation in rcu qsbr perfapp/ | +16 | 1 reply | |
| 2/4 | test/lpm: return error on failure in rcu qsbr perfapp/ | +10 | 1 reply | |
| 3/4 | test/lpm: remove error checking in rcu qsbr perfapp/ | +8 | 1 reply | |
| 4/4 | test/lpm: avoid code duplication in rcu qsbr perfapp/ | +81 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Ruifeng Wang | Honnappa Nagarahalli | Vladimir Medvedkin |
|---|---|---|---|
| 1/4 | R-b | R-b | A-b |
| 2/4 | R-b | R-b | A-b |
| 3/4 | R-b | R-b | A-b |
| 4/4 | R-b | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [dpdk-dev] [PATCH v5 0/4] test/lpm: fix rcu qsbr perf test
Fix LPM adds, LPM deletes, and cycle calculation.
Return error if LPM add/delete fails in multi-writer test. Return error if single or multi writer test fails
Remove redundant error checking for readers.
Combine single and multi threaded test cases to avoid code duplication.
---
v5:
- Update logic for routes inserted by each writer in multi writer test to avoid possibility of routes getting skipped
v4:
- Return error if rcu qsbr test fails
- Improve multi writer test to enable more than 2 writers
v3:
- Add 'goto error'
- Remove unnecessary if statement
v2:
- Add more details about the fix to the commit message
- Replace hard coded values with an enum
- Remove lock acquire/release for single writer
Dharmik Thakkar (4):
test/lpm: fix cycle calculation in rcu qsbr perf test/lpm: return error on failure in rcu qsbr perf test/lpm: remove error checking in rcu qsbr perf test/lpm: avoid code duplication in rcu qsbr perf
app/test/test_lpm_perf.c | 380 +++++++++------------------------------ 1 file changed, 88 insertions(+), 292 deletions(-)
Signature · 1 line
2.17.1