Skip to content

btrfs: preparation patches for subpage support

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 65 repliesIn review

Changes in v1 from the cover letter

- Separate prep patches from the huge subpage patchset

- Rebased to misc-next

- Add more commit message for patch "btrfs: extent_io: remove the extent_start/extent_len for end_bio_extent_readpage()" With one runtime example to explain why we are doing the same thing.

- Fix the assert_spin_lock() usage
What we really want is lockdep_assert_held()

- Re-iterate the reason why some extent io tests are invalid This is especially important since later patches will reduce extent_buffer::pages[] to bare minimal, killing the ability to handle certain invalid extent buffers.

- Use sectorsize_bits for division
During the convert, we should only use sectorsize_bits for division, this solves the hassle on 32bit system to do division. But we should not use sectorsize_bits no brain, as bit shift is not straight forward as multiple/division.

- Address the comments for btrfs_lookup_bio_sums() cleanup patchset From naming to macro usages, all of those comments should further improve the readability.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32btrfs: extent_io: remove the extent_start/extent_len for end_bio_extent_readpage()fs/btrfs/extent_io.c+3 -307 replies
2/32btrfs: extent_io: integrate page status update into endio_readpage_release_extent()fs/btrfs/extent_io.c+28 -105 replies
3/32btrfs: extent_io: add lockdep_assert_held() for attach_extent_buffer_page()fs/btrfs/extent_io.c+9 -00 replies
4/32btrfs: extent_io: extract the btree page submission code into its own helper functionfs/btrfs/extent_io.c+69 -472 replies
5/32btrfs: extent-io-tests: remove invalid testsfs/btrfs/tests/extent-io-tests.c+11 -150 replies
6/32btrfs: extent_io: calculate inline extent buffer page size based on page sizefs/btrfs/extent_io.c fs/btrfs/extent_io.h+8 -61 reply
7/32btrfs: extent_io: make btrfs_fs_info::buffer_radix to take sector size devided valuesfs/btrfs/extent_io.c+4 -40 replies
8/32btrfs: extent_io: sink less common parameters for __set_extent_bit()fs/btrfs/extent-io-tree.h fs/btrfs/extent_io.c+59 -242 replies
9/32btrfs: extent_io: sink less common parameters for __clear_extent_bit()fs/btrfs/extent-io-tree.h fs/btrfs/extent_io.c fs/btrfs/extent_map.c+56 -210 replies
10/32btrfs: disk_io: grab fs_info from extent_buffer::fs_info directly for btrfs_mark_buffer_dirty()fs/btrfs/disk-io.c+1 -42 replies
11/32btrfs: disk-io: make csum_tree_block() handle sectorsize smaller than page sizefs/btrfs/disk-io.c+3 -34 replies
12/32btrfs: disk-io: extract the extent buffer verification from btrfs_validate_metadata_buffer()fs/btrfs/disk-io.c+43 -354 replies
13/32btrfs: disk-io: accept bvec directly for csum_dirty_buffer()fs/btrfs/disk-io.c+3 -21 reply
14/32btrfs: inode: make btrfs_readpage_end_io_hook() follow sector sizefs/btrfs/inode.c+11 -14 replies
15/32btrfs: introduce a helper to determine if the sectorsize is smaller than PAGE_SIZEfs/btrfs/ctree.h+5 -07 replies
16/32btrfs: extent_io: allow find_first_extent_bit() to find a range with exact bits matchfs/btrfs/block-group.c fs/btrfs/dev-replace.c fs/btrfs/disk-io.c +7 more+40 -242 replies
17/32btrfs: extent_io: don't allow tree block to cross page boundary for subpage supportfs/btrfs/extent_io.c+7 -05 replies
18/32btrfs: extent_io: update num_extent_pages() to support subpage sized extent bufferfs/btrfs/extent_io.h+9 -21 reply
19/32btrfs: handle sectorsize < PAGE_SIZE case for extent buffer accessorsfs/btrfs/ctree.c fs/btrfs/ctree.h fs/btrfs/extent_io.c +1 more+88 -392 replies
20/32btrfs: disk-io: only clear EXTENT_LOCK bit for extent_invalidatepage()fs/btrfs/extent_io.c+10 -21 reply
21/32btrfs: extent-io: make type of extent_state::state to be at least 32 bitsfs/btrfs/extent-io-tree.h fs/btrfs/extent_io.c fs/btrfs/extent_io.h+45 -421 reply
22/32btrfs: file-item: use nodesize to determine whether we need readahead for btrfs_lookup_bio_sums()fs/btrfs/file-item.c+5 -11 reply
23/32btrfs: file-item: remove the btrfs_find_ordered_sum() call in btrfs_lookup_bio_sums()fs/btrfs/file-item.c fs/btrfs/ordered-data.c fs/btrfs/ordered-data.h+11 -511 reply
24/32btrfs: file-item: refactor btrfs_lookup_bio_sums() to handle out-of-order bvecsfs/btrfs/compression.c fs/btrfs/ctree.h fs/btrfs/file-item.c +1 more+159 -891 reply
25/32btrfs: scrub: distinguish scrub_page from regular pagefs/btrfs/scrub.c+51 -510 replies
26/32btrfs: scrub: remove the @force parameter of scrub_pages()fs/btrfs/scrub.c+9 -50 replies
27/32btrfs: scrub: use flexible array for scrub_page::csumsfs/btrfs/scrub.c+30 -113 replies
28/32btrfs: scrub: refactor scrub_find_csum()fs/btrfs/scrub.c+51 -200 replies
29/32btrfs: scrub: introduce scrub_page::page_len for subpage supportfs/btrfs/scrub.c+25 -115 replies
30/32btrfs: scrub: always allocate one full page for one sector for RAID56fs/btrfs/scrub.c+15 -20 replies
31/32btrfs: scrub: support subpage tree block scrubfs/btrfs/scrub.c+10 -41 reply
32/32btrfs: scrub: support subpage data scrubfs/btrfs/scrub.c+6 -20 replies

Reviews trailers per patch

12 of 32 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/32
2/32
3/32R-b
4/32
5/32
6/32R-b
7/32R-b
8/32
9/32
10/32R-b R-b
11/32R-b
12/32R-b
13/32R-b
14/32
15/32
16/32
17/32
18/32R-b
19/32
20/32R-b
21/32R-b
22/32R-b
23/32R-b
24/32
25/32
26/32
27/32
28/32
29/32
30/32
31/32
32/32

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/32] btrfs: preparation patches for subpage support

This is the rebased preparation branch for all patches not yet merged into misc-next.
It can be fetched from github:
https://github.com/adam900710/linux/tree/subpage_prep_rebased

This patchset includes all the unmerged preparation patches for subpage support.

The patchset is sent without the main core for subpage support, as myself has proven that, big patchset bombarding won't really make reviewers happy, but only make the author happy (for a very short time).

But we still got 32 patches for them, thus we still need a summary for the patchset:

Patch 01~21: Generic preparation patches.
Mostly pave the way for metadata and data read.

Patch 22~24: Recent btrfs_lookup_bio_sums() cleanup
The most subpage unrelated patches, but still helps refactor related functions for incoming subpage support.

Patch 25~32: Scrub support for subpage.
Since scrub is completely unrelated to regular data/meta read write, the scrub support for subpage can be implemented independently and easily.

Changelog:
v1:
- Separate prep patches from the huge subpage patchset

- Rebased to misc-next

- Add more commit message for patch "btrfs: extent_io: remove the extent_start/extent_len for end_bio_extent_readpage()" With one runtime example to explain why we are doing the same thing.

- Fix the assert_spin_lock() usage
What we really want is lockdep_assert_held()

- Re-iterate the reason why some extent io tests are invalid This is especially important since later patches will reduce extent_buffer::pages[] to bare minimal, killing the ability to handle certain invalid extent buffers.

- Use sectorsize_bits for division
During the convert, we should only use sectorsize_bits for division, this solves the hassle on 32bit system to do division. But we should not use sectorsize_bits no brain, as bit shift is not straight forward as multiple/division.

- Address the comments for btrfs_lookup_bio_sums() cleanup patchset From naming to macro usages, all of those comments should further improve the readability.

Qu Wenruo (32):
btrfs: extent_io: remove the extent_start/extent_len for
end_bio_extent_readpage()
btrfs: extent_io: integrate page status update into
endio_readpage_release_extent()
btrfs: extent_io: add lockdep_assert_held() for
attach_extent_buffer_page()
btrfs: extent_io: extract the btree page submission code into its own
helper function
btrfs: extent-io-tests: remove invalid tests
btrfs: extent_io: calculate inline extent buffer page size based on
page size
btrfs: extent_io: make btrfs_fs_info::buffer_radix to take sector size
devided values
btrfs: extent_io: sink less common parameters for __set_extent_bit()
btrfs: extent_io: sink less common parameters for __clear_extent_bit()
btrfs: disk_io: grab fs_info from extent_buffer::fs_info directly for
btrfs_mark_buffer_dirty()
btrfs: disk-io: make csum_tree_block() handle sectorsize smaller than
page size
btrfs: disk-io: extract the extent buffer verification from
btrfs_validate_metadata_buffer()
btrfs: disk-io: accept bvec directly for csum_dirty_buffer()
btrfs: inode: make btrfs_readpage_end_io_hook() follow sector size
btrfs: introduce a helper to determine if the sectorsize is smaller
than PAGE_SIZE
btrfs: extent_io: allow find_first_extent_bit() to find a range with
exact bits match
btrfs: extent_io: don't allow tree block to cross page boundary for
subpage support
btrfs: extent_io: update num_extent_pages() to support subpage sized
extent buffer
btrfs: handle sectorsize < PAGE_SIZE case for extent buffer accessors
btrfs: disk-io: only clear EXTENT_LOCK bit for extent_invalidatepage()
btrfs: extent-io: make type of extent_state::state to be at least 32
bits
btrfs: file-item: use nodesize to determine whether we need readahead
for btrfs_lookup_bio_sums()
btrfs: file-item: remove the btrfs_find_ordered_sum() call in
btrfs_lookup_bio_sums()
btrfs: file-item: refactor btrfs_lookup_bio_sums() to handle
out-of-order bvecs
btrfs: scrub: distinguish scrub_page from regular page
btrfs: scrub: remove the @force parameter of scrub_pages()
btrfs: scrub: use flexible array for scrub_page::csums
btrfs: scrub: refactor scrub_find_csum()
btrfs: scrub: introduce scrub_page::page_len for subpage support
btrfs: scrub: always allocate one full page for one sector for RAID56
btrfs: scrub: support subpage tree block scrub
btrfs: scrub: support subpage data scrub

 fs/btrfs/block-group.c           |   2 +-
 fs/btrfs/compression.c           |   5 +-
 fs/btrfs/ctree.c                 |   5 +-
 fs/btrfs/ctree.h                 |  45 ++-
 fs/btrfs/dev-replace.c           |   2 +-
 fs/btrfs/disk-io.c               |  98 ++++---
 fs/btrfs/extent-io-tree.h        |  88 ++++--
 fs/btrfs/extent-tree.c           |   2 +-
 fs/btrfs/extent_io.c             | 478 +++++++++++++++++++------------
 fs/btrfs/extent_io.h             |  21 +-
 fs/btrfs/extent_map.c            |   2 +-
 fs/btrfs/file-item.c             | 256 +++++++++++------
 fs/btrfs/free-space-cache.c      |   2 +-
 fs/btrfs/inode.c                 |  17 +-
 fs/btrfs/ordered-data.c          |  44 ---
 fs/btrfs/ordered-data.h          |   2 -
 fs/btrfs/relocation.c            |   2 +-
 fs/btrfs/scrub.c                 | 293 ++++++++++++-------
 fs/btrfs/struct-funcs.c          |  18 +-
 fs/btrfs/tests/extent-io-tests.c |  26 +-
 fs/btrfs/transaction.c           |   4 +-
 fs/btrfs/volumes.c               |   2 +-
 22 files changed, 870 insertions(+), 544 deletions(-)
Signature · 1 line
2.29.2