Skip to content

json: resolve multiple test case failures

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests: json: add missing test case outputtests/py/bridge/reject.t tests/py/bridge/reject.t.json tests/py/inet/sets.t.json +2 more+150 -40 replies
2/3tests: avoid warning and add missing json test casestests/py/inet/dnat.t tests/py/inet/dnat.t.json+57 -20 replies
3/3json: add missing nat_type flag and netmap nat flagsrc/json.c src/parser_json.c tests/py/ip/snat.t.json+211 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 0/3] json: resolve multiple test case failures

Over the last few months nft gained a few new features and test cases that either do not have a json test case or fail in json mode.

First two patches only touch the test cases themselves, but the snat.t failure turned out to be due to lack of feature parity with the normal bison parser.

Thus that patch adds needed export/import facility for nat_type and the netmap flag.

 src/json.c                     |   43 +++++++++++++---
 src/parser_json.c              |   70 +++++++++++++++++++++++++-
 tests/py/bridge/reject.t       |    2 
 tests/py/bridge/reject.t.json  |   72 +++++++++++++++++++++++++++
 tests/py/inet/dnat.t           |    4 -
 tests/py/inet/dnat.t.json      |   55 ++++++++++++++++++++
 tests/py/inet/sets.t.json      |   74 ++++++++++++++++++++++++++++
 tests/py/ip/icmp.t.json        |    4 -
 tests/py/ip/icmp.t.json.output |    2 
 tests/py/ip/snat.t.json        |  108 +++++++++++++++++++++++++++++++++++++++++
 10 files changed, 418 insertions(+), 16 deletions(-)