Skip to content

dpdk-pmdinfo: python lint cleanups

Stephen Hemminger dpdk-dev 1 version Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 2 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7dpdk-pmdinfo: replace string.split with splitusertools/dpdk-pmdinfo.py+1 -20 replies
2/7dpdk-pmdinfo: replace io.open with openusertools/dpdk-pmdinfo.py+6 -70 replies
3/7dpdk-pmdinfo: remove unnecessary paren and elseusertools/dpdk-pmdinfo.py+16 -180 replies
4/7dpdk-pmdinfo: replace is False and is Trueusertools/dpdk-pmdinfo.py+12 -120 replies
5/7dpdk-pmdinfo: fix indentationusertools/dpdk-pmdinfo.py+2 -20 replies
6/7dpdk-pmdinfo: replace deprecated optparse with argparseusertools/dpdk-pmdinfo.py+32 -381 reply
7/7dpdk-pmdinfo: do not use len(x) to test for emptyusertools/dpdk-pmdinfo.py+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/7] dpdk-pmdinfo: python lint cleanups

Ran dpdk-pmdinfo through Python3 lint and it had lots of complaints. These are the obvious simple ones to fix. Skipped adding docstrings everywhere and doing large scale variable recasing.

v2 - split out the pmdinfo specific part
incorporate feedback from Bruce about last use of len()

Stephen Hemminger (7):
dpdk-pmdinfo: replace string.split with split
dpdk-pmdinfo: replace io.open with open
dpdk-pmdinfo: remove unnecessary paren and else
dpdk-pmdinfo: replace is False and is True
dpdk-pmdinfo: fix indentation
dpdk-pmdinfo: replace deprecated optparse with argparse
dpdk-pmdinfo: do not use len(x) to test for empty

 usertools/dpdk-pmdinfo.py | 132 ++++++++++++++++++--------------------
 1 file changed, 61 insertions(+), 71 deletions(-)
Signature · 1 line
2.27.0