gpio: pcie-idio-24: Fix IRQ handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | gpio: pcie-idio-24: Fix irq mask when maskingdrivers/ | +1 | 1 reply | |
| 2/3 | gpio: pcie-idio-24: Fix IRQ Enable Register valuedrivers/ | +4 | 1 reply | |
| 3/3 | gpio: pcie-idio-24: Enable PEX8311 interruptsdrivers/ | +51 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | William Breathitt Gray |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling
This patch set fixes the irq_mask/irq_unmask functions and enables the PLX PEX8311 local interrupts.
With the current version of the driver, gpiomon (from libgpiod) or a poll(2) on the sysfs value are not working. According to /proc/interrupts, there is no interruption triggered.
The main issue is that the local interrupts are not forwarded by the PEX8311 to the PCI.
There is also two bugs:
- The IRQ mask is not correctly updated when unmasking an interruption.
- The COS Enable Register value is not correctly updated when masking/unmasking an interruption.
It seems this problems exist since the initial commit.
Arnaud de Turckheim (3):
gpio: pcie-idio-24: Fix irq mask when masking
gpio: pcie-idio-24: Fix IRQ Enable Register value
gpio: pcie-idio-24: Enable PEX8311 interrupts
drivers/gpio/gpio-pcie-idio-24.c | 62 ++++++++++++++++++++++++++++---- 1 file changed, 56 insertions(+), 6 deletions(-)
Signature · 1 line
2.25.1