Skip to content

arm64: dts: ti: Cleanup mix of "okay" and "disabled"

Nishanth Menon linux-arm-kernel linux-devicetree lkml 4 versions – Applied

Status from this message: I have applied this revision to branch ti-k3-dts-next on [1].

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesApplied
  2. v35 patches 2 repliesApplied
  3. v25 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches7 repliesSuperseded

Changes in v4 from the cover letter

- drops the fixes tags (as this is not strictly a stable fix)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi levelarch/arm64/boot/dts/ti/k3-am65-main.dtsi arch/arm64/boot/dts/ti/k3-am654-base-board.dts+16 -80 replies
2/5arm64: dts: ti: k3-j721e*: Cleanup disabled nodes at SoC dtsi levelarch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts arch/arm64/boot/dts/ti/k3-j721e-main.dtsi+47 -270 replies
3/5arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for cryptoarch/arm64/boot/dts/ti/k3-am65-main.dtsi arch/arm64/boot/dts/ti/k3-j721e-main.dtsi+0 -31 reply
4/5arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USBarch/arm64/boot/dts/ti/k3-am654-base-board.dts+0 -80 replies
5/5arm64: dts: ti: am65/j721e/j7200: Mark firmware used uart as "reserved"arch/arm64/boot/dts/ti/k3-am654-base-board.dts arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts+4 -40 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchTomi ValkeinenTony LindgrenVignesh RaghavendraRoger QuadrosTero KristoKeerthy
1/5R-b R-b
2/5R-b R-b
3/5R-b A-b R-b
4/5R-b A-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH V4 0/5] arm64: dts: ti: Cleanup mix of "okay" and "disabled"

Hi,

V4 changes:
- drops the fixes tags (as this is not strictly a stable fix)

Repost. older versions v3[3] v2[2] v1[1]

Summarising the blurb of the discussion[4] we have had, there are few options one could take when dealing with SoC dtsi and board dts:

a. SoC dtsi provide nodes as a super-set default (aka enabled) state and
to prevent messy board files, when more boards are added per SoC, we optimize and disable commonly un-used nodes in board-common.dtsi
b. SoC dtsi disables all hardware dependent nodes by default and board
dts files enable nodes based on a need basis.
c. Subjectively pick and choose which nodes we will disable by default
in SoC dtsi and over the years we can optimize things and change default state depending on the need.

While there are pros and cons on each of these approaches, the right thing to do will be to stick with device tree default standards and work within those established rules. So, we choose to go with option (a).

NOTE: There is a known risk of "omission" that new board dts developers might miss reviewing both the board schematics in addition to all the dt nodes of the SoC when setting appropriate nodes status to "disable" or "reserved" in the board dts. This can expose issues in drivers which may not anticipate an incomplete node(example: missing appropriate board properties) being in "okay" state. These cases are considered as bugs and need to be fixed in the drivers as and when identified.

Nishanth Menon (5):
arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level
arm64: dts: ti: k3-j721e*: Cleanup disabled nodes at SoC dtsi level
arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay"
for crypto
arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to
"okay" for USB
arm64: dts: ti: am65/j721e/j7200: Mark firmware used uart as
"reserved"

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      |  9 ----
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 26 ++++++----
 .../dts/ti/k3-j7200-common-proc-board.dts     |  4 +-
 .../dts/ti/k3-j721e-common-proc-board.dts     | 50 ++++++++++++++++++-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 28 -----------
 5 files changed, 67 insertions(+), 50 deletions(-)

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[2] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[3] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[4] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Signature · 1 line
2.29.2